diff mbox

[tegrarcm,v1,6/8] tegrarcm: increase USB timeout

Message ID 1426639141-12060-8-git-send-email-jimmzhang@nvidia.com
State Deferred
Headers show

Commit Message

jimmzhang March 18, 2015, 12:38 a.m. UTC 
From: Allen Martin <amartin@nvidia.com>

Increase USB timeout from 1ms to 3ms to avoid flashing failure
happened when a long USB cable (5ft ?) is used.

Signed-off-by: Allen Martin <amartin@nvidia.com>
Signed-off-by: Jimmy Zhang <jimmzhang@nvidia.com>
---
 src/usb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stephen Warren March 19, 2015, 7:35 p.m. UTC | #1 
On 03/17/2015 06:38 PM, Jimmy Zhang wrote:
> From: Allen Martin <amartin@nvidia.com>
>
> Increase USB timeout from 1ms to 3ms to avoid flashing failure
> happened when a long USB cable (5ft ?) is used.

This really doesn't make any sense; cable length isn't going to make 
more than some ns of timing difference, unless corrupted packets cause 
lots of retries. I'd suggest replacing the bad cable if that's really 
the cause.
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/src/usb.c b/src/usb.c
index ed2ff28eef8d..4a0d8da46e5b 100644
--- a/src/usb.c
+++ b/src/usb.c
@@ -35,7 +35,7 @@ 
 #include "debug.h"
 
 // USB xfer timeout in ms
-#define USB_TIMEOUT 1000
+#define USB_TIMEOUT 3000
 
 #define USB_XFER_MAX 4096