From patchwork Thu Oct 9 09:16:49 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandre Courbot X-Patchwork-Id: 397946 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 679D31400B2 for ; Thu, 9 Oct 2014 20:16:56 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750942AbaJIJQz (ORCPT ); Thu, 9 Oct 2014 05:16:55 -0400 Received: from hqemgate14.nvidia.com ([216.228.121.143]:3518 "EHLO hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750824AbaJIJQy (ORCPT ); Thu, 9 Oct 2014 05:16:54 -0400 Received: from hqnvupgp08.nvidia.com (Not Verified[216.228.121.13]) by hqemgate14.nvidia.com id ; Thu, 09 Oct 2014 02:17:45 -0700 Received: from hqemhub01.nvidia.com ([172.20.12.94]) by hqnvupgp08.nvidia.com (PGP Universal service); Thu, 09 Oct 2014 02:16:40 -0700 X-PGP-Universal: processed; by hqnvupgp08.nvidia.com on Thu, 09 Oct 2014 02:16:40 -0700 Received: from percival.nvidia.com (172.20.144.16) by hqemhub01.nvidia.com (172.20.150.30) with Microsoft SMTP Server (TLS) id 8.3.342.0; Thu, 9 Oct 2014 02:16:53 -0700 From: Alexandre Courbot To: Thierry Reding CC: , , , Alexandre Courbot Subject: [PATCH] drm: tegra: Check return value of drm_vblank_get() Date: Thu, 9 Oct 2014 18:16:49 +0900 Message-ID: <1412846209-28630-1-git-send-email-acourbot@nvidia.com> X-Mailer: git-send-email 2.1.2 X-NVConfidentiality: public MIME-Version: 1.0 Sender: linux-tegra-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org drm_vblank_get() can return an error, which we should propagate. Signed-off-by: Alexandre Courbot --- drivers/gpu/drm/tegra/dc.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/tegra/dc.c b/drivers/gpu/drm/tegra/dc.c index 6553fd238685..b08df07cad47 100644 --- a/drivers/gpu/drm/tegra/dc.c +++ b/drivers/gpu/drm/tegra/dc.c @@ -699,6 +699,7 @@ static int tegra_dc_page_flip(struct drm_crtc *crtc, struct drm_framebuffer *fb, { struct tegra_dc *dc = to_tegra_dc(crtc); struct drm_device *drm = crtc->dev; + int ret; if (dc->event) return -EBUSY; @@ -706,7 +707,9 @@ static int tegra_dc_page_flip(struct drm_crtc *crtc, struct drm_framebuffer *fb, if (event) { event->pipe = dc->pipe; dc->event = event; - drm_vblank_get(drm, dc->pipe); + ret = drm_vblank_get(drm, dc->pipe); + if (ret < 0) + return ret; } tegra_dc_set_base(dc, 0, 0, fb);