From patchwork Tue Sep 30 07:22:00 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomeu Vizoso X-Patchwork-Id: 394795 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 6E85E14009A for ; Tue, 30 Sep 2014 17:22:37 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752073AbaI3HWX (ORCPT ); Tue, 30 Sep 2014 03:22:23 -0400 Received: from mail-wi0-f169.google.com ([209.85.212.169]:42692 "EHLO mail-wi0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751889AbaI3HWU (ORCPT ); Tue, 30 Sep 2014 03:22:20 -0400 Received: by mail-wi0-f169.google.com with SMTP id cc10so896780wib.4 for ; Tue, 30 Sep 2014 00:22:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id; bh=B8O45QKV9ZSOK9Eusi0JzsMH8uhwsHuW2QsJh0t8xQQ=; b=B5KAuvSrZTh9IFjNym5MdlpEQn1+CTd4QAay7lFOpeZ27Xw+J9Vz1d2FU6FLRV8PFi Py1v0l/bGlv+xmVdNv5gPEkp3RK7riNKjxn5VTVFflnqI3djMSNjbZb+x0ZncJDi5weB idw1ZIfW/n76flJSjMSB2fwHwEi3mtZAFAwMg84/pukhC2D4/+CJ3qgsAMOhWoglmG7v V+Pda/rardfwkHLh+1SOrzR811RnxY+kvQlnyOpILHdTj/k4T18C4WKZDq7qya71tKgK oUNRDcey04oumv6HwvfsjkDbhVII9S8IhCXQu2YSCE5BTiD9g46eDwPu1vvLP/8mEO6T p9BA== X-Received: by 10.195.13.114 with SMTP id ex18mr24511371wjd.89.1412061739167; Tue, 30 Sep 2014 00:22:19 -0700 (PDT) Received: from cizrna.lan (37-48-40-49.tmcz.cz. [37.48.40.49]) by mx.google.com with ESMTPSA id fs13sm13064427wic.19.2014.09.30.00.22.16 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 30 Sep 2014 00:22:18 -0700 (PDT) From: Tomeu Vizoso To: Peter De Schrijver Cc: Prashant Gaikwad , Mike Turquette , Stephen Warren , Thierry Reding , linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, Tomeu Vizoso Subject: [PATCH] clk: tegra: Fix order of arguments in WARN Date: Tue, 30 Sep 2014 09:22:00 +0200 Message-Id: <1412061720-10402-1-git-send-email-tomeu.vizoso@collabora.com> X-Mailer: git-send-email 1.9.3 Sender: linux-tegra-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org As previously the names of the present clock and its parent were swapped. Signed-off-by: Tomeu Vizoso Acked-by: Thierry Reding --- Hi, I'm not a native English speaker, but the way the current message is made me think that the clock that failed registration was the wrong one. Regards, Tomeu --- drivers/clk/tegra/clk-pll.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/clk/tegra/clk-pll.c b/drivers/clk/tegra/clk-pll.c index c7c6d8f..fd18d2e 100644 --- a/drivers/clk/tegra/clk-pll.c +++ b/drivers/clk/tegra/clk-pll.c @@ -1565,7 +1565,7 @@ struct clk *tegra_clk_register_pllxc(const char *name, const char *parent_name, parent = __clk_lookup(parent_name); if (!parent) { WARN(1, "parent clk %s of %s must be registered first\n", - name, parent_name); + parent_name, name); return ERR_PTR(-EINVAL); } @@ -1665,7 +1665,7 @@ struct clk *tegra_clk_register_pllm(const char *name, const char *parent_name, parent = __clk_lookup(parent_name); if (!parent) { WARN(1, "parent clk %s of %s must be registered first\n", - name, parent_name); + parent_name, name); return ERR_PTR(-EINVAL); } @@ -1706,7 +1706,7 @@ struct clk *tegra_clk_register_pllc(const char *name, const char *parent_name, parent = __clk_lookup(parent_name); if (!parent) { WARN(1, "parent clk %s of %s must be registered first\n", - name, parent_name); + parent_name, name); return ERR_PTR(-EINVAL); } @@ -1830,7 +1830,7 @@ struct clk *tegra_clk_register_pllss(const char *name, const char *parent_name, parent = __clk_lookup(parent_name); if (!parent) { WARN(1, "parent clk %s of %s must be registered first\n", - name, parent_name); + parent_name, name); return ERR_PTR(-EINVAL); }