From patchwork Wed Dec 4 02:00:35 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Ruehl X-Patchwork-Id: 296379 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 884402C009D for ; Wed, 4 Dec 2013 13:08:19 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754748Ab3LDCIS (ORCPT ); Tue, 3 Dec 2013 21:08:18 -0500 Received: from mail.fpasia.hk ([202.130.89.98]:49574 "EHLO fpa01n0.fpasia.hk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753925Ab3LDCIS (ORCPT ); Tue, 3 Dec 2013 21:08:18 -0500 X-Greylist: delayed 450 seconds by postgrey-1.27 at vger.kernel.org; Tue, 03 Dec 2013 21:08:17 EST Received: from localhost (localhost [127.0.0.1]) by fpa01n0.fpasia.hk (Postfix) with ESMTP id 6BC65CFA763; Wed, 4 Dec 2013 10:00:46 +0800 (HKT) X-Virus-Scanned: FPASIA amavisd-new at fpasia.hk Received: from fpa01n0.fpasia.hk ([127.0.0.1]) by localhost (fpa01n0.office.fpa.com.hk [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id eX9weddj2LoB; Wed, 4 Dec 2013 10:00:45 +0800 (HKT) Received: from s01.gtsys.com.hk (gtsnode.office.fpasia.hk [10.10.37.40]) by fpa01n0.fpasia.hk (Postfix) with ESMTP id 8E1AFCFA1FC; Wed, 4 Dec 2013 10:00:45 +0800 (HKT) Received: from wheezyvm.gtsys.com.hk (pcd353062.netvigator.com [203.218.143.62]) by s01.gtsys.com.hk (Postfix) with ESMTPA id 8A20BC00A70; Wed, 4 Dec 2013 10:00:43 +0800 (HKT) Received: by wheezyvm.gtsys.com.hk (Postfix, from userid 1000) id 80846CAE1; Wed, 4 Dec 2013 10:00:37 +0800 (HKT) From: Chris Ruehl To: balbi@ti.com Cc: gregkh@linuxfoundation.org, swarren@wwwdotorg.org, thierry.reding@gmail.com, linux-usb@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, Chris Ruehl Subject: [PATCH 7/7] usb: phy-tegra-usb.c: wrong pointer check for remap UTMI Date: Wed, 4 Dec 2013 10:00:35 +0800 Message-Id: <1386122435-4205-1-git-send-email-chris.ruehl@gtsys.com.hk> X-Mailer: git-send-email 1.7.10.4 Sender: linux-tegra-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org usb: phy-tegra-usb.c: wrong pointer check for remap UTMI A wrong pointer was used to test the result of devm_ioremap() Signed-off-by: Chris Ruehl Acked-by: Venu Byravarasu --- drivers/usb/phy/phy-tegra-usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/phy/phy-tegra-usb.c b/drivers/usb/phy/phy-tegra-usb.c index 82232ac..bbe4f8e 100644 --- a/drivers/usb/phy/phy-tegra-usb.c +++ b/drivers/usb/phy/phy-tegra-usb.c @@ -876,7 +876,7 @@ static int utmi_phy_probe(struct tegra_usb_phy *tegra_phy, tegra_phy->pad_regs = devm_ioremap(&pdev->dev, res->start, resource_size(res)); - if (!tegra_phy->regs) { + if (!tegra_phy->pad_regs) { dev_err(&pdev->dev, "Failed to remap UTMI Pad regs\n"); return -ENOMEM; }