| Message ID | 1386076567-14283-1-git-send-email-ldewangan@nvidia.com |
|---|---|
| State | Superseded, archived |
| Delegated to: | Stephen Warren |
| Headers | show |
On Tue, Dec 03, 2013 at 06:46:06PM +0530, Laxman Dewangan wrote: > This new header file defines pincontrol constants for Tegra to > use from Tegra's DTS file for pincontrol properties option. > > Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com> > --- > Changes from V1: > - Get rid of lots of macro and converge it to TEGRA_PIN_ENABLE/DISABLE. > - Change macro name for PULL UP/DOWN/NONE. > > include/dt-bindings/pinctrl/pinctrl-tegra.h | 40 +++++++++++++++++++++++++++ > 1 files changed, 40 insertions(+), 0 deletions(-) > create mode 100644 include/dt-bindings/pinctrl/pinctrl-tegra.h I like this a lot. One minor nit below. > diff --git a/include/dt-bindings/pinctrl/pinctrl-tegra.h b/include/dt-bindings/pinctrl/pinctrl-tegra.h > new file mode 100644 > index 0000000..e5f02f8 > --- /dev/null > +++ b/include/dt-bindings/pinctrl/pinctrl-tegra.h > @@ -0,0 +1,40 @@ > +/* > + * This header provides constants for TEGRA pinctrl bindings. "TEGRA" -> "Tegra" Other than that: Reviewed-by: Thierry Reding <treding@nvidia.com>
On 12/03/2013 06:16 AM, Laxman Dewangan wrote: > This new header file defines pincontrol constants for Tegra to > use from Tegra's DTS file for pincontrol properties option. > diff --git a/include/dt-bindings/pinctrl/pinctrl-tegra.h b/include/dt-bindings/pinctrl/pinctrl-tegra.h > +#define TEGRA_PIN_DISABLE 0 > +#define TEGRA_PIN_ENABLE 1 That needs a comment re: which properties the defines can be used with, since the properties are no longer related to the defines by name. > +/* Pull up/down/normal */ > +#define TEGRA_PIN_PULL_NONE 0 > +#define TEGRA_PIN_PULL_DOWN 1 > +#define TEGRA_PIN_PULL_UP 2 Whereas that comment seems unnecessary, since it's obvious from the define names. > +/* Low power mode */ > +#define TEGRA_PIN_LP_DRIVE_DIV_8 0 > +#define TEGRA_PIN_LP_DRIVE_DIV_4 1 > +#define TEGRA_PIN_LP_DRIVE_DIV_2 2 > +#define TEGRA_PIN_LP_DRIVE_DIV_1 3 -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/include/dt-bindings/pinctrl/pinctrl-tegra.h b/include/dt-bindings/pinctrl/pinctrl-tegra.h new file mode 100644 index 0000000..e5f02f8 --- /dev/null +++ b/include/dt-bindings/pinctrl/pinctrl-tegra.h @@ -0,0 +1,40 @@ +/* + * This header provides constants for TEGRA pinctrl bindings. + * + * Copyright (c) 2013, NVIDIA CORPORATION. All rights reserved. + * + * Author: Laxman Dewangan <ldewangan@nvidia.com> + * + * This program is free software; you can redistribute it and/or modify it + * under the terms and conditions of the GNU General Public License, + * version 2, as published by the Free Software Foundation. + * + * This program is distributed in the hope it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for + * more details. + */ + +#ifndef _DT_BINDINGS_PINCTRL_TEGRA_H +#define _DT_BINDINGS_PINCTRL_TEGRA_H + +#define TEGRA_PIN_DISABLE 0 +#define TEGRA_PIN_ENABLE 1 + +/* Pull up/down/normal */ +#define TEGRA_PIN_PULL_NONE 0 +#define TEGRA_PIN_PULL_DOWN 1 +#define TEGRA_PIN_PULL_UP 2 + +/* Low power mode */ +#define TEGRA_PIN_LP_DRIVE_DIV_8 0 +#define TEGRA_PIN_LP_DRIVE_DIV_4 1 +#define TEGRA_PIN_LP_DRIVE_DIV_2 2 +#define TEGRA_PIN_LP_DRIVE_DIV_1 3 + +#define TEGRA_PIN_SLEW_RATE_FASTEST 0 +#define TEGRA_PIN_SLEW_RATE_FAST 1 +#define TEGRA_PIN_SLEW_RATE_SLOW 2 +#define TEGRA_PIN_SLEW_RATE_SLOWEST 3 + +#endif
This new header file defines pincontrol constants for Tegra to use from Tegra's DTS file for pincontrol properties option. Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com> --- Changes from V1: - Get rid of lots of macro and converge it to TEGRA_PIN_ENABLE/DISABLE. - Change macro name for PULL UP/DOWN/NONE. include/dt-bindings/pinctrl/pinctrl-tegra.h | 40 +++++++++++++++++++++++++++ 1 files changed, 40 insertions(+), 0 deletions(-) create mode 100644 include/dt-bindings/pinctrl/pinctrl-tegra.h