From patchwork Wed Nov 27 16:26:03 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thierry Reding X-Patchwork-Id: 294616 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 8FEEE2C00A1 for ; Thu, 28 Nov 2013 03:26:51 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753505Ab3K0Q0u (ORCPT ); Wed, 27 Nov 2013 11:26:50 -0500 Received: from mail-bk0-f46.google.com ([209.85.214.46]:56467 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752326Ab3K0Q0t (ORCPT ); Wed, 27 Nov 2013 11:26:49 -0500 Received: by mail-bk0-f46.google.com with SMTP id u15so3312598bkz.19 for ; Wed, 27 Nov 2013 08:26:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=Pj0f8D5s6wT6ACp2Wwuqe/3q2z4yXwHid1WZCdccdZM=; b=d4rBF7Y3nlHkv8ZUR0m7fMMVVs5sNL+0zrVArON2SGSpU0yGt3RrjIOtZ77LvcCMXu xht788llIZ2Wh/kpU1pTue4o2R/J58+YErl7Un2BCwLez8Q+k01lWnEcecu9qh/+hcPv /w43isfLR435AtlbOmCj+lhmM6ZzHRcSVe0CROS80ujOoczo3uH8yiuKbqzgEHNKcmmT B2NnoAVMU5hTY/Y66aFVvIKNdkO9VXWywio+dRzTM0/o1aRzTDCwdKh64KWO0B6RcLrd ivbEyYoxJMBkfeP5M+0NAu1nbLq9aqtmeQOw8f6dPjaD+mGgMMB12z/j+9tkKEAeYM5s LjNg== X-Received: by 10.204.127.135 with SMTP id g7mr2348323bks.42.1385569606996; Wed, 27 Nov 2013 08:26:46 -0800 (PST) Received: from localhost (port-31827.pppoe.wtnet.de. [46.59.175.43]) by mx.google.com with ESMTPSA id j6sm45759272bki.17.2013.11.27.08.26.45 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Nov 2013 08:26:45 -0800 (PST) From: Thierry Reding To: Peter De Schrijver Cc: Mike Turquette , linux-tegra@vger.kernel.org Subject: [PATCH] clk: tegra: Do not print errors for clk_round_rate() Date: Wed, 27 Nov 2013 17:26:03 +0100 Message-Id: <1385569563-25408-1-git-send-email-treding@nvidia.com> X-Mailer: git-send-email 1.8.4.2 Sender: linux-tegra-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org clk_round_rate() can be used by drivers to determine whether or not a frequency is supported by the clock. The current Tegra clock driver outputs an error message and a stacktrace when the requested rate isn't supported. That's fine for clk_set_rate(), but it's confusing when all the driver does is query whether or not a frequency is supported. Signed-off-by: Thierry Reding Acked-by: Mike Turquette --- drivers/clk/tegra/clk-pll.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/clk/tegra/clk-pll.c b/drivers/clk/tegra/clk-pll.c index 7aec773a5ca6..55ece6726108 100644 --- a/drivers/clk/tegra/clk-pll.c +++ b/drivers/clk/tegra/clk-pll.c @@ -435,9 +435,6 @@ static int _calc_rate(struct clk_hw *hw, struct tegra_clk_pll_freq_table *cfg, if (cfg->m > divm_max(pll) || cfg->n > divn_max(pll) || (1 << p_div) > divp_max(pll) || cfg->output_rate > pll->params->vco_max) { - pr_err("%s: Failed to set %s rate %lu\n", - __func__, __clk_get_name(hw->clk), rate); - WARN_ON(1); return -EINVAL; } @@ -584,6 +581,8 @@ static int clk_pll_set_rate(struct clk_hw *hw, unsigned long rate, if (_get_table_rate(hw, &cfg, rate, parent_rate) && _calc_rate(hw, &cfg, rate, parent_rate)) { + pr_err("%s: Failed to set %s rate %lu\n", __func__, + __clk_get_name(hw->clk), rate); WARN_ON(1); return -EINVAL; } @@ -615,10 +614,8 @@ static long clk_pll_round_rate(struct clk_hw *hw, unsigned long rate, return __clk_get_rate(hw->clk); if (_get_table_rate(hw, &cfg, rate, *prate) && - _calc_rate(hw, &cfg, rate, *prate)) { - WARN_ON(1); + _calc_rate(hw, &cfg, rate, *prate)) return -EINVAL; - } return cfg.output_rate; }