| Message ID | 1368390409-14156-1-git-send-email-digetx@gmail.com |
|---|---|
| State | Accepted, archived |
| Headers | show |
On 05/12/2013 02:26 PM, Dmitry Osipenko wrote: > Change tegra_emc_ramcode_devnode() to get ram-code from child node instead of > parent. I've applied this to Tegra's for-3.11/soc branch. > For me it looks like it should be better to place ram-code inside of table > nodes, so num_tables will be incremented if table has valid ram-code and table > with invalid ram-code will be skipped on getting table params loop. This avoids > placing of #address-cells and #size-cells in nodes with ram-code. > If it looks ok, I may send new patch. That would be a change to the DT binding. DT bindings are supposed to be a stable ABI, so we wouldn't want to change the binding unless there was a strong reason. I don't think there is one here. -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
18.05.2013 03:53, Stephen Warren пишет: > On 05/12/2013 02:26 PM, Dmitry Osipenko wrote: >> Change tegra_emc_ramcode_devnode() to get ram-code from child node instead of >> parent. > > I've applied this to Tegra's for-3.11/soc branch. > Thanks. >> For me it looks like it should be better to place ram-code inside of table >> nodes, so num_tables will be incremented if table has valid ram-code and table >> with invalid ram-code will be skipped on getting table params loop. This avoids >> placing of #address-cells and #size-cells in nodes with ram-code. >> If it looks ok, I may send new patch. > > That would be a change to the DT binding. DT bindings are supposed to be > a stable ABI, so we wouldn't want to change the binding unless there was > a strong reason. I don't think there is one here. > Ok. -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/mach-tegra/tegra2_emc.c b/arch/arm/mach-tegra/tegra2_emc.c index 9e8bdfa..25f0189 100644 --- a/arch/arm/mach-tegra/tegra2_emc.c +++ b/arch/arm/mach-tegra/tegra2_emc.c @@ -183,7 +183,7 @@ static struct device_node *tegra_emc_ramcode_devnode(struct device_node *np) u32 reg; for_each_child_of_node(np, iter) { - if (of_property_read_u32(np, "nvidia,ram-code", ®)) + if (of_property_read_u32(iter, "nvidia,ram-code", ®)) continue; if (reg == tegra_bct_strapping) return of_node_get(iter);
Change tegra_emc_ramcode_devnode() to get ram-code from child node instead of parent. Signed-off-by: Dmitry Osipenko <digetx@gmail.com> --- For me it looks like it should be better to place ram-code inside of table nodes, so num_tables will be incremented if table has valid ram-code and table with invalid ram-code will be skipped on getting table params loop. This avoids placing of #address-cells and #size-cells in nodes with ram-code. If it looks ok, I may send new patch. arch/arm/mach-tegra/tegra2_emc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)