diff mbox

[v7,09/20] tegra: fdt: Add additional USB binding

Message ID 1330452478-5039-10-git-send-email-sjg@chromium.org
State Not Applicable, archived
Headers show

Commit Message

Simon Glass Feb. 28, 2012, 6:07 p.m. UTC
This adds a property to indicate a port which can switch between host and device
mode.

Signed-off-by: Simon Glass <sjg@chromium.org>
---
Changes in v5:
- Add dr_mode property to control host/device/otg mode
- Add nvidia,has-legacy-mode property per review comments

Changes in v7:
- Fix space indent nit

 doc/device-tree-bindings/usb/tegra-usb.txt |   12 ++++++++++++
 1 files changed, 12 insertions(+), 0 deletions(-)

Comments

Stephen Warren Feb. 28, 2012, 6:42 p.m. UTC | #1
Simon Glass wrote at Tuesday, February 28, 2012 11:08 AM:
> This adds a property to indicate a port which can switch between host and device
> mode.
> 
> Signed-off-by: Simon Glass <sjg@chromium.org>

Acked-by: Stephen Warren <swarren@nvidia.com>

(I can't recall; did this patch make it into the kernel too?)
Simon Glass Feb. 28, 2012, 6:48 p.m. UTC | #2
Hi,

On Tue, Feb 28, 2012 at 10:42 AM, Stephen Warren <swarren@nvidia.com> wrote:
> Simon Glass wrote at Tuesday, February 28, 2012 11:08 AM:
>> This adds a property to indicate a port which can switch between host and device
>> mode.
>>
>> Signed-off-by: Simon Glass <sjg@chromium.org>
>
> Acked-by: Stephen Warren <swarren@nvidia.com>
>
> (I can't recall; did this patch make it into the kernel too?)

Not that I know of.

Regards,
Simon

>
> --
> nvpublic
>
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Stephen Warren Feb. 28, 2012, 6:49 p.m. UTC | #3
Simon Glass wrote at Tuesday, February 28, 2012 11:49 AM:
> On Tue, Feb 28, 2012 at 10:42 AM, Stephen Warren <swarren@nvidia.com> wrote:
> > Simon Glass wrote at Tuesday, February 28, 2012 11:08 AM:
> >> This adds a property to indicate a port which can switch between host and device
> >> mode.
> >>
> >> Signed-off-by: Simon Glass <sjg@chromium.org>
> >
> > Acked-by: Stephen Warren <swarren@nvidia.com>
> >
> > (I can't recall; did this patch make it into the kernel too?)
> 
> Not that I know of.

OK, it must have been another change that you pushed there.

Please push this one to the kernel too, thanks.
Simon Glass March 7, 2012, 3:19 a.m. UTC | #4
Hi Stephen,

On Tue, Feb 28, 2012 at 10:49 AM, Stephen Warren <swarren@nvidia.com> wrote:
> Simon Glass wrote at Tuesday, February 28, 2012 11:49 AM:
>> On Tue, Feb 28, 2012 at 10:42 AM, Stephen Warren <swarren@nvidia.com> wrote:
>> > Simon Glass wrote at Tuesday, February 28, 2012 11:08 AM:
>> >> This adds a property to indicate a port which can switch between host and device
>> >> mode.
>> >>
>> >> Signed-off-by: Simon Glass <sjg@chromium.org>
>> >
>> > Acked-by: Stephen Warren <swarren@nvidia.com>
>> >
>> > (I can't recall; did this patch make it into the kernel too?)
>>
>> Not that I know of.
>
> OK, it must have been another change that you pushed there.
>
> Please push this one to the kernel too, thanks.

OK, I sent a ping on that thread so let's see if we get a response.

It could be that it has been committed somewhere but no one responded
on the mailing list.

Regards,
Simon

>
> --
> nvpublic
>
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/doc/device-tree-bindings/usb/tegra-usb.txt b/doc/device-tree-bindings/usb/tegra-usb.txt
index 035d63d..5282d44 100644
--- a/doc/device-tree-bindings/usb/tegra-usb.txt
+++ b/doc/device-tree-bindings/usb/tegra-usb.txt
@@ -11,3 +11,15 @@  Required properties :
  - phy_type : Should be one of "ulpi" or "utmi".
  - nvidia,vbus-gpio : If present, specifies a gpio that needs to be
    activated for the bus to be powered.
+
+Optional properties:
+  - dr_mode : dual role mode. Indicates the working mode for
+    nvidia,tegra20-ehci compatible controllers.  Can be "host", "peripheral",
+    or "otg".  Default to "host" if not defined for backward compatibility.
+      host means this is a host controller
+      peripheral means it is device controller
+      otg means it can operate as either ("on the go")
+  - nvidia,has-legacy-mode : boolean indicates whether this controller can
+    operate in legacy mode (as APX 2500 / 2600). In legacy mode some
+    registers are accessed through the APB_MISC base address instead of
+    the USB controller.