| Message ID | 1321911851-10091-1-git-send-email-swarren@nvidia.com |
|---|---|
| State | Awaiting Upstream, archived |
| Headers | show |
Hi Stephen, On Monday 21 November 2011 14:44:07 Stephen Warren wrote: > There are no drivers in the kernel at present which can make use of the > memory reserved by /memreserve/, so there is no point reserving it. Remove > /memreserve/ to allow the user more memory. It's also unclear whether any > future driver would actually require /memreserve/, or allocate memory > through some other mechanism. while this gives 512 MB of usable memory on my AC100, it causes some funny pictures on the screen ;-) I guess our bootloader (fastboot) already setups the frambuffer there (and enables the backlight). I guess it shouldn't be harmful as nothing else writes to this memory area. Otherwise you may add that the bootloader (or the kernel cmdline supplied by the bootloader) is now responsible for the reservation to the description. Marc > Signed-off-by: Stephen Warren <swarren@nvidia.com> > --- > arch/arm/boot/dts/tegra-harmony.dts | 1 - > arch/arm/boot/dts/tegra-paz00.dts | 1 - > arch/arm/boot/dts/tegra-seaboard.dts | 1 - > arch/arm/boot/dts/tegra-trimslice.dts | 1 - > arch/arm/boot/dts/tegra-ventana.dts | 1 - > 5 files changed, 0 insertions(+), 5 deletions(-) > > diff --git a/arch/arm/boot/dts/tegra-harmony.dts > b/arch/arm/boot/dts/tegra-harmony.dts index 0e225b8..a802324 100644 > --- a/arch/arm/boot/dts/tegra-harmony.dts > +++ b/arch/arm/boot/dts/tegra-harmony.dts > @@ -1,6 +1,5 @@ > /dts-v1/; > > -/memreserve/ 0x1c000000 0x04000000; > /include/ "tegra20.dtsi" > > / { > diff --git a/arch/arm/boot/dts/tegra-paz00.dts > b/arch/arm/boot/dts/tegra-paz00.dts index 15a949f..1cd0cfe 100644 > --- a/arch/arm/boot/dts/tegra-paz00.dts > +++ b/arch/arm/boot/dts/tegra-paz00.dts > @@ -1,6 +1,5 @@ > /dts-v1/; > > -/memreserve/ 0x1c000000 0x04000000; > /include/ "tegra20.dtsi" > > / { > diff --git a/arch/arm/boot/dts/tegra-seaboard.dts > b/arch/arm/boot/dts/tegra-seaboard.dts index 88c682a..60724e4 100644 > --- a/arch/arm/boot/dts/tegra-seaboard.dts > +++ b/arch/arm/boot/dts/tegra-seaboard.dts > @@ -1,6 +1,5 @@ > /dts-v1/; > > -/memreserve/ 0x1c000000 0x04000000; > /include/ "tegra20.dtsi" > > / { > diff --git a/arch/arm/boot/dts/tegra-trimslice.dts > b/arch/arm/boot/dts/tegra-trimslice.dts index d3d0d20..95117d3 100644 > --- a/arch/arm/boot/dts/tegra-trimslice.dts > +++ b/arch/arm/boot/dts/tegra-trimslice.dts > @@ -1,6 +1,5 @@ > /dts-v1/; > > -/memreserve/ 0x1c000000 0x04000000; > /include/ "tegra20.dtsi" > > / { > diff --git a/arch/arm/boot/dts/tegra-ventana.dts > b/arch/arm/boot/dts/tegra-ventana.dts index 3f9abd6..2af12fa 100644 > --- a/arch/arm/boot/dts/tegra-ventana.dts > +++ b/arch/arm/boot/dts/tegra-ventana.dts > @@ -1,6 +1,5 @@ > /dts-v1/; > > -/memreserve/ 0x1c000000 0x04000000; > /include/ "tegra20.dtsi" > > / { -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Marc Dietrich wrote at Tuesday, November 22, 2011 3:42 AM: > On Monday 21 November 2011 14:44:07 Stephen Warren wrote: > > There are no drivers in the kernel at present which can make use of the > > memory reserved by /memreserve/, so there is no point reserving it. Remove > > /memreserve/ to allow the user more memory. It's also unclear whether any > > future driver would actually require /memreserve/, or allocate memory > > through some other mechanism. > > while this gives 512 MB of usable memory on my AC100, it causes some funny > pictures on the screen ;-) I guess our bootloader (fastboot) already setups > the frambuffer there (and enables the backlight). I guess it shouldn't be > harmful as nothing else writes to this memory area. Otherwise you may add that > the bootloader (or the kernel cmdline supplied by the bootloader) is now > responsible for the reservation to the description. Ah yes, I guess that would happen. I'm only testing with mainline U-Boot... I'd suggest this is acceptable fallout for now; I don't believe it will cause any active problems, and as you say, you can get the bootloader to set a command-line that excludes the frame-buffer if you want to solve this. Do you agree?
On Tuesday 22 November 2011 08:25:03 Stephen Warren wrote: > Marc Dietrich wrote at Tuesday, November 22, 2011 3:42 AM: > > On Monday 21 November 2011 14:44:07 Stephen Warren wrote: > > > There are no drivers in the kernel at present which can make use of > > > the > > > memory reserved by /memreserve/, so there is no point reserving it. > > > Remove /memreserve/ to allow the user more memory. It's also > > > unclear whether any future driver would actually require > > > /memreserve/, or allocate memory through some other mechanism. > > > > while this gives 512 MB of usable memory on my AC100, it causes some > > funny pictures on the screen ;-) I guess our bootloader (fastboot) > > already setups the frambuffer there (and enables the backlight). I > > guess it shouldn't be harmful as nothing else writes to this memory > > area. Otherwise you may add that the bootloader (or the kernel cmdline > > supplied by the bootloader) is now responsible for the reservation to > > the description. > > Ah yes, I guess that would happen. I'm only testing with mainline U-Boot... > > I'd suggest this is acceptable fallout for now; I don't believe it will > cause any active problems, and as you say, you can get the bootloader to > set a command-line that excludes the frame-buffer if you want to solve > this. Do you agree? Ok. Hopefully we can also use u-Boot soon. Marc -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Nov 21, 2011 at 02:44:07PM -0700, Stephen Warren wrote: > There are no drivers in the kernel at present which can make use of the > memory reserved by /memreserve/, so there is no point reserving it. Remove > /memreserve/ to allow the user more memory. It's also unclear whether any > future driver would actually require /memreserve/, or allocate memory > through some other mechanism. > > Signed-off-by: Stephen Warren <swarren@nvidia.com> Thanks, applied to for-3.3/boards -Olof -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Nov 22, 2011 at 08:25:03AM -0800, Stephen Warren wrote: > Marc Dietrich wrote at Tuesday, November 22, 2011 3:42 AM: > > On Monday 21 November 2011 14:44:07 Stephen Warren wrote: > > > There are no drivers in the kernel at present which can make use of the > > > memory reserved by /memreserve/, so there is no point reserving it. Remove > > > /memreserve/ to allow the user more memory. It's also unclear whether any > > > future driver would actually require /memreserve/, or allocate memory > > > through some other mechanism. > > > > while this gives 512 MB of usable memory on my AC100, it causes some funny > > pictures on the screen ;-) I guess our bootloader (fastboot) already setups > > the frambuffer there (and enables the backlight). I guess it shouldn't be > > harmful as nothing else writes to this memory area. Otherwise you may add that > > the bootloader (or the kernel cmdline supplied by the bootloader) is now > > responsible for the reservation to the description. > > Ah yes, I guess that would happen. I'm only testing with mainline U-Boot... > > I'd suggest this is acceptable fallout for now; I don't believe it will > cause any active problems, and as you say, you can get the bootloader to > set a command-line that excludes the frame-buffer if you want to solve > this. Do you agree? Agreed. It would make more sense to teach u-boot to reserve the memory. -Olof -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/tegra-harmony.dts b/arch/arm/boot/dts/tegra-harmony.dts index 0e225b8..a802324 100644 --- a/arch/arm/boot/dts/tegra-harmony.dts +++ b/arch/arm/boot/dts/tegra-harmony.dts @@ -1,6 +1,5 @@ /dts-v1/; -/memreserve/ 0x1c000000 0x04000000; /include/ "tegra20.dtsi" / { diff --git a/arch/arm/boot/dts/tegra-paz00.dts b/arch/arm/boot/dts/tegra-paz00.dts index 15a949f..1cd0cfe 100644 --- a/arch/arm/boot/dts/tegra-paz00.dts +++ b/arch/arm/boot/dts/tegra-paz00.dts @@ -1,6 +1,5 @@ /dts-v1/; -/memreserve/ 0x1c000000 0x04000000; /include/ "tegra20.dtsi" / { diff --git a/arch/arm/boot/dts/tegra-seaboard.dts b/arch/arm/boot/dts/tegra-seaboard.dts index 88c682a..60724e4 100644 --- a/arch/arm/boot/dts/tegra-seaboard.dts +++ b/arch/arm/boot/dts/tegra-seaboard.dts @@ -1,6 +1,5 @@ /dts-v1/; -/memreserve/ 0x1c000000 0x04000000; /include/ "tegra20.dtsi" / { diff --git a/arch/arm/boot/dts/tegra-trimslice.dts b/arch/arm/boot/dts/tegra-trimslice.dts index d3d0d20..95117d3 100644 --- a/arch/arm/boot/dts/tegra-trimslice.dts +++ b/arch/arm/boot/dts/tegra-trimslice.dts @@ -1,6 +1,5 @@ /dts-v1/; -/memreserve/ 0x1c000000 0x04000000; /include/ "tegra20.dtsi" / { diff --git a/arch/arm/boot/dts/tegra-ventana.dts b/arch/arm/boot/dts/tegra-ventana.dts index 3f9abd6..2af12fa 100644 --- a/arch/arm/boot/dts/tegra-ventana.dts +++ b/arch/arm/boot/dts/tegra-ventana.dts @@ -1,6 +1,5 @@ /dts-v1/; -/memreserve/ 0x1c000000 0x04000000; /include/ "tegra20.dtsi" / {
There are no drivers in the kernel at present which can make use of the memory reserved by /memreserve/, so there is no point reserving it. Remove /memreserve/ to allow the user more memory. It's also unclear whether any future driver would actually require /memreserve/, or allocate memory through some other mechanism. Signed-off-by: Stephen Warren <swarren@nvidia.com> --- arch/arm/boot/dts/tegra-harmony.dts | 1 - arch/arm/boot/dts/tegra-paz00.dts | 1 - arch/arm/boot/dts/tegra-seaboard.dts | 1 - arch/arm/boot/dts/tegra-trimslice.dts | 1 - arch/arm/boot/dts/tegra-ventana.dts | 1 - 5 files changed, 0 insertions(+), 5 deletions(-)