| Message ID | 1320377174-28047-1-git-send-email-olof@lixom.net |
|---|---|
| State | Superseded, archived |
| Headers | show |
Olof Johansson wrote at Thursday, November 03, 2011 9:26 PM: > For now they are a minimal binding. It needs to be amended with > vendor-specific settings for phy setup and link tuning, etc. ... > diff --git a/arch/arm/boot/dts/tegra-seaboard.dts b/arch/arm/boot/dts/tegra-seaboard.dts ... > + usb@c5000000 { > + nvidia,vbus-gpio = <&gpio 24 0>; /* PD0 */ > + }; Given that's a custom property, don't we need bindings documentation in Documentation/devictree/bindings/usb/? Even if the binding is pretty self- explanatory.
On Fri, Nov 4, 2011 at 11:27 AM, Stephen Warren <swarren@nvidia.com> wrote: > Olof Johansson wrote at Thursday, November 03, 2011 9:26 PM: >> For now they are a minimal binding. It needs to be amended with >> vendor-specific settings for phy setup and link tuning, etc. > ... >> diff --git a/arch/arm/boot/dts/tegra-seaboard.dts b/arch/arm/boot/dts/tegra-seaboard.dts > ... >> + usb@c5000000 { >> + nvidia,vbus-gpio = <&gpio 24 0>; /* PD0 */ >> + }; > > Given that's a custom property, don't we need bindings documentation in > Documentation/devictree/bindings/usb/? Even if the binding is pretty self- > explanatory. Yes, you're right. Please add a binding, but you can leave my ack in place when reposted. g. -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/tegra-seaboard.dts b/arch/arm/boot/dts/tegra-seaboard.dts index a72299b..88c682a 100644 --- a/arch/arm/boot/dts/tegra-seaboard.dts +++ b/arch/arm/boot/dts/tegra-seaboard.dts @@ -29,4 +29,8 @@ sdhci@c8000600 { support-8bit; }; + + usb@c5000000 { + nvidia,vbus-gpio = <&gpio 24 0>; /* PD0 */ + }; }; diff --git a/arch/arm/boot/dts/tegra20.dtsi b/arch/arm/boot/dts/tegra20.dtsi index 65d7e6a..2ad1107 100644 --- a/arch/arm/boot/dts/tegra20.dtsi +++ b/arch/arm/boot/dts/tegra20.dtsi @@ -143,5 +143,23 @@ reg = <0xc8000600 0x200>; interrupts = < 63 >; }; + + usb@c5000000 { + compatible = "nvidia,tegra20-ehci", "usb-ehci"; + reg = <0xc5000000 0x4000>; + interrupts = < 52 >; + }; + + usb@c5004000 { + compatible = "nvidia,tegra20-ehci", "usb-ehci"; + reg = <0xc5004000 0x4000>; + interrupts = < 53 >; + }; + + usb@c5008000 { + compatible = "nvidia,tegra20-ehci", "usb-ehci"; + reg = <0xc5008000 0x4000>; + interrupts = < 129 >; + }; };
For now they are a minimal binding. It needs to be amended with vendor-specific settings for phy setup and link tuning, etc. Signed-off-by: Olof Johansson <olof@lixom.net> --- arch/arm/boot/dts/tegra-seaboard.dts | 4 ++++ arch/arm/boot/dts/tegra20.dtsi | 18 ++++++++++++++++++ 2 files changed, 22 insertions(+), 0 deletions(-)