diff mbox

arch: arm: tegra: Enable headphone detection gpio

Message ID 1319819226-19098-1-git-send-email-thutt@chromium.org
State Accepted, archived
Headers show

Commit Message

Taylor Hutt Oct. 28, 2011, 4:27 p.m. UTC 
From: Yufeng Shen <miletus@chromium.org>

Enable the headphone detection gpio on tegra platform.

Signed-off-by: Yufeng Shen <miletus@chromium.org>
---
 arch/arm/mach-tegra/board-seaboard-pinmux.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Comments

Stephen Warren Oct. 28, 2011, 5:11 p.m. UTC | #1 
Taylor Hutt wrote at Friday, October 28, 2011 10:27 AM:
> From: Yufeng Shen <miletus@chromium.org>
> 
> Enable the headphone detection gpio on tegra platform.
> 
> Signed-off-by: Yufeng Shen <miletus@chromium.org>

Aha, that explains why this seemed to have stopped working when I tried
it on Seaboard recently; I guess it never did. Harmony already does this
correctly, and that's where I must have tested the feature initially.

Acked-by: Stephen Warren <swarren@nvidia.com>
Stephen Warren Nov. 2, 2011, 6:36 p.m. UTC | #2 
Stephen Warren wrote at Friday, October 28, 2011 11:12 AM:
> Taylor Hutt wrote at Friday, October 28, 2011 10:27 AM:
> > From: Yufeng Shen <miletus@chromium.org>
> >
> > Enable the headphone detection gpio on tegra platform.
> >
> > Signed-off-by: Yufeng Shen <miletus@chromium.org>
> 
> Aha, that explains why this seemed to have stopped working when I tried
> it on Seaboard recently; I guess it never did. Harmony already does this
> correctly, and that's where I must have tested the feature initially.
> 
> Acked-by: Stephen Warren <swarren@nvidia.com>

I just tried testing this and noticed this patch doesn't apply to mainline;
I think the patch was lifted verbatim from the ChromeOS kernel without
being rebased onto mainline? Please rebase to mainline and repost.

But then I manually applied the patch and tested it, and it does work.
diff mbox

Patch

diff --git a/arch/arm/mach-tegra/board-seaboard-pinmux.c b/arch/arm/mach-tegra/board-seaboard-pinmux.c
index 9d0ba80..14e9d576 100644
--- a/arch/arm/mach-tegra/board-seaboard-pinmux.c
+++ b/arch/arm/mach-tegra/board-seaboard-pinmux.c
@@ -205,6 +205,7 @@  static struct tegra_gpio_table common_gpio_table[] = {
 	{ .gpio = TEGRA_GPIO_NCT1008_THERM2_IRQ,.enable = true },
 	{ .gpio = TEGRA_GPIO_WLAN_POWER,	.enable = true },
 	{ .gpio = TEGRA_GPIO_AC_ONLINE,		.enable = true },
+	{ .gpio = TEGRA_GPIO_HP_DET,		.enable = true },
 	{ .gpio = TEGRA_GPIO_MXT_IRQ,		.enable = true },
 	{ .gpio = TEGRA_GPIO_HDMI_ENB,		.enable = true },
 	{ .gpio = TEGRA_GPIO_MPU3050_IRQ,	.enable = true },