mbox series

[v7,0/5] Add Tegra Security Engine driver

Message ID 20240403100039.33146-1-akhilrajeev@nvidia.com
Headers show
Series Add Tegra Security Engine driver | expand

Message

Akhil R April 3, 2024, 10 a.m. UTC
Add support for Tegra Security Engine which can accelerates various
crypto algorithms. The Engine has two separate instances within for
AES and HASH algorithms respectively.

The driver registers two crypto engines - one for AES and another for
HASH algorithms and these operate independently and both uses the host1x
bus. Additionally, it provides  hardware-assisted key protection for up to
15 symmetric keys which it can use for the cipher operations.

v6->v7:
* Move fallback_tfm and fallback_req to end of struct
* Set reqsize and statesize based on fallback_tfm
* Remove ofb(aes)
v5->v6:
* Move copy/pase of intermediate results in export()/import() to
  'update()' callback for CMAC as well.
* Check for rctx size when using fallback alg.
* Updated blocksizes to align with generic implementation
* Combined GCM and CCM init into aead_cra_init
* Updates to handle invalid cases better
* Reduce log levels for invalid cases to dev_dbg
v4->v5:
* Move copy/paste of intermediate results in export()/import() to
  'update()' callback
v3->v4:
* Remove unused header in bindings doc.
* Update commit message in host1x change.
* Fix test bot warning.
v2->v3:
* Update compatible in driver and device trees.
* Remove extra new lines and symbols in binding doc.
v1->v2:
* Update probe errors with 'dev_err_probe'.
* Clean up function prototypes and redundant prints.
* Remove readl/writel wrappers.
* Fix test bot warnings.


Akhil R (5):
  dt-bindings: crypto: Add Tegra Security Engine
  gpu: host1x: Add Tegra SE to SID table
  crypto: tegra: Add Tegra Security Engine driver
  arm64: defconfig: Enable Tegra Security Engine
  arm64: tegra: Add Tegra Security Engine DT nodes

 .../crypto/nvidia,tegra234-se-aes.yaml        |   52 +
 .../crypto/nvidia,tegra234-se-hash.yaml       |   52 +
 MAINTAINERS                                   |    5 +
 arch/arm64/boot/dts/nvidia/tegra234.dtsi      |   16 +
 arch/arm64/configs/defconfig                  |    1 +
 drivers/crypto/Kconfig                        |    8 +
 drivers/crypto/Makefile                       |    1 +
 drivers/crypto/tegra/Makefile                 |    9 +
 drivers/crypto/tegra/tegra-se-aes.c           | 1933 +++++++++++++++++
 drivers/crypto/tegra/tegra-se-hash.c          | 1060 +++++++++
 drivers/crypto/tegra/tegra-se-key.c           |  156 ++
 drivers/crypto/tegra/tegra-se-main.c          |  439 ++++
 drivers/crypto/tegra/tegra-se.h               |  560 +++++
 drivers/gpu/host1x/dev.c                      |   24 +
 14 files changed, 4316 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/crypto/nvidia,tegra234-se-aes.yaml
 create mode 100644 Documentation/devicetree/bindings/crypto/nvidia,tegra234-se-hash.yaml
 create mode 100644 drivers/crypto/tegra/Makefile
 create mode 100644 drivers/crypto/tegra/tegra-se-aes.c
 create mode 100644 drivers/crypto/tegra/tegra-se-hash.c
 create mode 100644 drivers/crypto/tegra/tegra-se-key.c
 create mode 100644 drivers/crypto/tegra/tegra-se-main.c
 create mode 100644 drivers/crypto/tegra/tegra-se.h

Comments

Herbert Xu April 12, 2024, 7:31 a.m. UTC | #1
On Wed, Apr 03, 2024 at 03:30:34PM +0530, Akhil R wrote:
> Add support for Tegra Security Engine which can accelerates various
> crypto algorithms. The Engine has two separate instances within for
> AES and HASH algorithms respectively.
> 
> The driver registers two crypto engines - one for AES and another for
> HASH algorithms and these operate independently and both uses the host1x
> bus. Additionally, it provides  hardware-assisted key protection for up to
> 15 symmetric keys which it can use for the cipher operations.
> 
> v6->v7:
> * Move fallback_tfm and fallback_req to end of struct
> * Set reqsize and statesize based on fallback_tfm
> * Remove ofb(aes)
> v5->v6:
> * Move copy/pase of intermediate results in export()/import() to
>   'update()' callback for CMAC as well.
> * Check for rctx size when using fallback alg.
> * Updated blocksizes to align with generic implementation
> * Combined GCM and CCM init into aead_cra_init
> * Updates to handle invalid cases better
> * Reduce log levels for invalid cases to dev_dbg
> v4->v5:
> * Move copy/paste of intermediate results in export()/import() to
>   'update()' callback
> v3->v4:
> * Remove unused header in bindings doc.
> * Update commit message in host1x change.
> * Fix test bot warning.
> v2->v3:
> * Update compatible in driver and device trees.
> * Remove extra new lines and symbols in binding doc.
> v1->v2:
> * Update probe errors with 'dev_err_probe'.
> * Clean up function prototypes and redundant prints.
> * Remove readl/writel wrappers.
> * Fix test bot warnings.
> 
> 
> Akhil R (5):
>   dt-bindings: crypto: Add Tegra Security Engine
>   gpu: host1x: Add Tegra SE to SID table
>   crypto: tegra: Add Tegra Security Engine driver
>   arm64: defconfig: Enable Tegra Security Engine
>   arm64: tegra: Add Tegra Security Engine DT nodes
> 
>  .../crypto/nvidia,tegra234-se-aes.yaml        |   52 +
>  .../crypto/nvidia,tegra234-se-hash.yaml       |   52 +
>  MAINTAINERS                                   |    5 +
>  arch/arm64/boot/dts/nvidia/tegra234.dtsi      |   16 +
>  arch/arm64/configs/defconfig                  |    1 +
>  drivers/crypto/Kconfig                        |    8 +
>  drivers/crypto/Makefile                       |    1 +
>  drivers/crypto/tegra/Makefile                 |    9 +
>  drivers/crypto/tegra/tegra-se-aes.c           | 1933 +++++++++++++++++
>  drivers/crypto/tegra/tegra-se-hash.c          | 1060 +++++++++
>  drivers/crypto/tegra/tegra-se-key.c           |  156 ++
>  drivers/crypto/tegra/tegra-se-main.c          |  439 ++++
>  drivers/crypto/tegra/tegra-se.h               |  560 +++++
>  drivers/gpu/host1x/dev.c                      |   24 +
>  14 files changed, 4316 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/crypto/nvidia,tegra234-se-aes.yaml
>  create mode 100644 Documentation/devicetree/bindings/crypto/nvidia,tegra234-se-hash.yaml
>  create mode 100644 drivers/crypto/tegra/Makefile
>  create mode 100644 drivers/crypto/tegra/tegra-se-aes.c
>  create mode 100644 drivers/crypto/tegra/tegra-se-hash.c
>  create mode 100644 drivers/crypto/tegra/tegra-se-key.c
>  create mode 100644 drivers/crypto/tegra/tegra-se-main.c
>  create mode 100644 drivers/crypto/tegra/tegra-se.h
> 
> -- 
> 2.43.2

All applied.  Thanks.
Thierry Reding April 26, 2024, 3:32 p.m. UTC | #2
From: Thierry Reding <treding@nvidia.com>


On Wed, 03 Apr 2024 15:30:34 +0530, Akhil R wrote:
> Add support for Tegra Security Engine which can accelerates various
> crypto algorithms. The Engine has two separate instances within for
> AES and HASH algorithms respectively.
> 
> The driver registers two crypto engines - one for AES and another for
> HASH algorithms and these operate independently and both uses the host1x
> bus. Additionally, it provides  hardware-assisted key protection for up to
> 15 symmetric keys which it can use for the cipher operations.
> 
> [...]

Applied, thanks!

[4/5] arm64: defconfig: Enable Tegra Security Engine
      commit: 4d4d3fe6b3cc2a0b2a334a08bb9c64ba1dcbbea4

Best regards,
Thierry Reding April 26, 2024, 3:35 p.m. UTC | #3
On Fri Apr 26, 2024 at 5:32 PM CEST, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
>
> On Wed, 03 Apr 2024 15:30:34 +0530, Akhil R wrote:
> > Add support for Tegra Security Engine which can accelerates various
> > crypto algorithms. The Engine has two separate instances within for
> > AES and HASH algorithms respectively.
> > 
> > The driver registers two crypto engines - one for AES and another for
> > HASH algorithms and these operate independently and both uses the host1x
> > bus. Additionally, it provides  hardware-assisted key protection for up to
> > 15 symmetric keys which it can use for the cipher operations.
> > 
> > [...]
>
> Applied, thanks!
>
> [4/5] arm64: defconfig: Enable Tegra Security Engine
>       commit: 4d4d3fe6b3cc2a0b2a334a08bb9c64ba1dcbbea4

For the record, I've also applied patch 5/5 but it didn't apply cleanly
and so b4 didn't track it properly.

Thanks,
Thierry