| Message ID | 20230825164249.22860-1-nmalwade@nvidia.com |
|---|---|
| Headers | show |
| Series | hwmon: ina3221: Add selective summation support | expand |
On Sat, Aug 26, 2023 at 12:42:45AM +0800, Ninad Malwade wrote: > The current INA3221 driver always sums the shunt voltage for all enabled > channels regardless of the shunt-resistor used for each channel. Summing > the shunt-voltage for channels is only meaningful if the shunt resistor > is the same for each channel. This series adds device-tree support to > allow which channels are summed in device-tree. > V2, but no change log. I am not going to review this series. Guenter > Jon Hunter (2): > dt-bindings: hwmon: ina3221: Add summation-bypass > arm64: tegra: Populate ina3221 for Tegra234 boards > > Ninad Malwade (1): > hwmon: ina3221: Add selective support for summation channel control > > Thierry Reding (1): > dt-bindings: hwmon: ina3221: Convert to json-schema > > .../devicetree/bindings/hwmon/ina3221.txt | 54 -------- > .../devicetree/bindings/hwmon/ti,ina3221.yaml | 127 ++++++++++++++++++ > .../arm64/boot/dts/nvidia/tegra234-p3701.dtsi | 53 ++++++++ > .../arm64/boot/dts/nvidia/tegra234-p3767.dtsi | 29 ++++ > drivers/hwmon/ina3221.c | 39 +++++- > 5 files changed, 243 insertions(+), 59 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/hwmon/ina3221.txt > create mode 100644 Documentation/devicetree/bindings/hwmon/ti,ina3221.yaml > > -- > 2.17.1 >
On 25/08/2023 18:11, Guenter Roeck wrote: > On Sat, Aug 26, 2023 at 12:42:45AM +0800, Ninad Malwade wrote: >> The current INA3221 driver always sums the shunt voltage for all enabled >> channels regardless of the shunt-resistor used for each channel. Summing >> the shunt-voltage for channels is only meaningful if the shunt resistor >> is the same for each channel. This series adds device-tree support to >> allow which channels are summed in device-tree. >> > > V2, but no change log. I am not going to review this series. Sorry about that the changelog is ... Changes since V1: - Added patch to convert dt-binding to json - Added patch to add new dt property for bypassing/disabling summation support for a channel - Added patch to populate ina3221 devices for Tegra234 boards - Updated summation bypass patch to display summation status via sysfs Jon
On 8/29/23 05:52, Jon Hunter wrote: > > On 25/08/2023 18:11, Guenter Roeck wrote: >> On Sat, Aug 26, 2023 at 12:42:45AM +0800, Ninad Malwade wrote: >>> The current INA3221 driver always sums the shunt voltage for all enabled >>> channels regardless of the shunt-resistor used for each channel. Summing >>> the shunt-voltage for channels is only meaningful if the shunt resistor >>> is the same for each channel. This series adds device-tree support to >>> allow which channels are summed in device-tree. >>> >> >> V2, but no change log. I am not going to review this series. > > Sorry about that the changelog is ... > > Changes since V1: > - Added patch to convert dt-binding to json > - Added patch to add new dt property for bypassing/disabling summation > support for a channel > - Added patch to populate ina3221 devices for Tegra234 boards > - Updated summation bypass patch to display summation status via sysfs > I have not looked at the patches, but this non-standard sysfs attribute is a no-go. Use debugfs if you want such information to be available. Guenter