mbox series

[v1,0/2] Restore voltages before rebooting of NVIDIA Tegra SoCs

Message ID 20210510220526.11113-1-digetx@gmail.com
Headers show
Series Restore voltages before rebooting of NVIDIA Tegra SoCs | expand

Message

Dmitry Osipenko May 10, 2021, 10:05 p.m. UTC 
Hi,

Nikola Milosavljević reported that rebooting wasn't working properly on
Asus Transformer TF101, which is Tegra20-based tablet device.  We found
that TF101 and some other devices have bootloader which doesn't re-initialize
voltages properly on a reboot.  The problem is resolved by ensuring that
SoC voltages are at a levels that are suitable for the rebooting of the
SoC before reboot happens. This series adds reboot handler to the Tegra
regulator couplers, it bumps voltages on the reboot event.

Dmitry Osipenko (2):
  regulator: core: Add regulator_sync_voltage_rdev()
  soc/tegra: regulators: Bump voltages on system reboot

 drivers/regulator/core.c               | 23 ++++++++
 drivers/soc/tegra/regulators-tegra20.c | 77 ++++++++++++++++++++++++-
 drivers/soc/tegra/regulators-tegra30.c | 80 +++++++++++++++++++++++++-
 include/linux/regulator/driver.h       |  1 +
 4 files changed, 177 insertions(+), 4 deletions(-)

Comments

Michał Mirosław May 14, 2021, 9:32 p.m. UTC | #1 
On Tue, May 11, 2021 at 01:05:24AM +0300, Dmitry Osipenko wrote:
> Hi,
> 
> Nikola Milosavljević reported that rebooting wasn't working properly on
> Asus Transformer TF101, which is Tegra20-based tablet device.  We found
> that TF101 and some other devices have bootloader which doesn't re-initialize
> voltages properly on a reboot.  The problem is resolved by ensuring that
> SoC voltages are at a levels that are suitable for the rebooting of the
> SoC before reboot happens. This series adds reboot handler to the Tegra
> regulator couplers, it bumps voltages on the reboot event.

Which tree does this series apply to?

Best Regards
Michał Mirosław
Dmitry Osipenko May 14, 2021, 10:18 p.m. UTC | #2 
15.05.2021 00:32, Michał Mirosław пишет:
> On Tue, May 11, 2021 at 01:05:24AM +0300, Dmitry Osipenko wrote:
>> Hi,
>>
>> Nikola Milosavljević reported that rebooting wasn't working properly on
>> Asus Transformer TF101, which is Tegra20-based tablet device.  We found
>> that TF101 and some other devices have bootloader which doesn't re-initialize
>> voltages properly on a reboot.  The problem is resolved by ensuring that
>> SoC voltages are at a levels that are suitable for the rebooting of the
>> SoC before reboot happens. This series adds reboot handler to the Tegra
>> regulator couplers, it bumps voltages on the reboot event.
> 
> Which tree does this series apply to?

It was made on top of linux-next, but it should apply to 5.13 as well.
What conflict do you get?
Dmitry Osipenko May 16, 2021, 9:32 p.m. UTC | #3 
15.05.2021 01:18, Dmitry Osipenko пишет:
> 15.05.2021 00:32, Michał Mirosław пишет:
>> On Tue, May 11, 2021 at 01:05:24AM +0300, Dmitry Osipenko wrote:
>>> Hi,
>>>
>>> Nikola Milosavljević reported that rebooting wasn't working properly on
>>> Asus Transformer TF101, which is Tegra20-based tablet device.  We found
>>> that TF101 and some other devices have bootloader which doesn't re-initialize
>>> voltages properly on a reboot.  The problem is resolved by ensuring that
>>> SoC voltages are at a levels that are suitable for the rebooting of the
>>> SoC before reboot happens. This series adds reboot handler to the Tegra
>>> regulator couplers, it bumps voltages on the reboot event.
>>
>> Which tree does this series apply to?
> 
> It was made on top of linux-next, but it should apply to 5.13 as well.
> What conflict do you get?
> 

I see where the problem is, there is no
tegra_soc_core_domain_state_synced() in upstream yet. I haven't rebased
patches properly, will be fixed in v2.