mbox series

[0/2] fix tegra-hda on tegra30 devices

Message ID 20201225012025.507803-1-pgwipeout@gmail.com
Headers show
Series fix tegra-hda on tegra30 devices | expand

Message

Peter Geis Dec. 25, 2020, 1:20 a.m. UTC 
The following patches fix tegra-hda on legacy tegra devices.
Two issues were discovered preventing tegra-hda from functioning:
The hda clocks on tegra30 were assigned to clk_m and running at too low of a rate to function.
The tegra-hda encounters an input/output error when opening a stream.

Since the only mainline device that used tegra-hda previously was the t124, it is unknown exactly when this was broken.
Fortunately a recent patch was submitted that fixed the issue only on t194 devices.
We can apply it universally to the tegra-hda device to resolve the issues across the board.
Note that downstream devices used the spdif device instead of hda for hdmi audio.
The spdif device lacks a driver on mainline.

Peter Geis (2):
  clk: tegra30: Add hda clock default rates to clock driver
  ALSA: hda/tegra: fix tegra-hda on tegra30 soc

 drivers/clk/tegra/clk-tegra30.c | 2 ++
 sound/pci/hda/hda_tegra.c       | 3 +--
 2 files changed, 3 insertions(+), 2 deletions(-)

Comments

Takashi Iwai Jan. 4, 2021, 2:25 p.m. UTC | #1 
On Fri, 25 Dec 2020 02:20:24 +0100,
Peter Geis wrote:
> 
> The following patches fix tegra-hda on legacy tegra devices.
> Two issues were discovered preventing tegra-hda from functioning:
> The hda clocks on tegra30 were assigned to clk_m and running at too low of a rate to function.
> The tegra-hda encounters an input/output error when opening a stream.
> 
> Since the only mainline device that used tegra-hda previously was the t124, it is unknown exactly when this was broken.
> Fortunately a recent patch was submitted that fixed the issue only on t194 devices.
> We can apply it universally to the tegra-hda device to resolve the issues across the board.
> Note that downstream devices used the spdif device instead of hda for hdmi audio.
> The spdif device lacks a driver on mainline.
> 
> Peter Geis (2):
>   clk: tegra30: Add hda clock default rates to clock driver
>   ALSA: hda/tegra: fix tegra-hda on tegra30 soc

Can Nvidia people look at those?


thanks,

Takashi

> 
>  drivers/clk/tegra/clk-tegra30.c | 2 ++
>  sound/pci/hda/hda_tegra.c       | 3 +--
>  2 files changed, 3 insertions(+), 2 deletions(-)
> 
> -- 
> 2.25.1
>