diff mbox series

[v2,1/2] dt-bindings: pwm: renesas,tpu-pwm: Improve json-schema

Message ID d36e3690ce8c5a1e53d054552e4fd8b90d6a5478.1620648868.git.geert+renesas@glider.be
State New
Headers show
Series dt-bindings: renesas,tpu: Improve and json-schema conversion | expand

Commit Message

Geert Uytterhoeven May 10, 2021, 12:18 p.m. UTC
- Include the general PWM controller schema,
  - Make clocks, power-domains, and resets properties required.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v2:
  - Keep additionalProperties, as pwm.yaml doesn't add any other
    properties.
---
 .../bindings/pwm/renesas,tpu-pwm.yaml           | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

Comments

Yoshinori Sato May 12, 2021, 10 a.m. UTC | #1
On Mon, 10 May 2021 21:18:34 +0900,
Geert Uytterhoeven wrote:
> 
>   - Include the general PWM controller schema,
>   - Make clocks, power-domains, and resets properties required.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> v2:
>   - Keep additionalProperties, as pwm.yaml doesn't add any other
>     properties.
> ---
>  .../bindings/pwm/renesas,tpu-pwm.yaml           | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/pwm/renesas,tpu-pwm.yaml b/Documentation/devicetree/bindings/pwm/renesas,tpu-pwm.yaml
> index aa9a4570c9068226..7c99e42ad780c2cd 100644
> --- a/Documentation/devicetree/bindings/pwm/renesas,tpu-pwm.yaml
> +++ b/Documentation/devicetree/bindings/pwm/renesas,tpu-pwm.yaml
> @@ -58,6 +58,23 @@ required:
>    - compatible
>    - reg
>    - '#pwm-cells'
> +  - clocks
> +  - power-domains
> +
> +allOf:
> +  - $ref: pwm.yaml#
> +
> +  - if:
> +      not:
> +        properties:
> +          compatible:
> +            contains:
> +              enum:
> +                - renesas,tpu-r8a73a4
> +                - renesas,tpu-r8a7740
> +    then:
> +      required:
> +        - resets
>  
>  additionalProperties: false
>  
> -- 
> 2.25.1
> 

Acked-by: Yoshinori Sato <ysato@users.sourceforge.jp>
Rob Herring May 13, 2021, 2:33 a.m. UTC | #2
On Mon, 10 May 2021 14:18:34 +0200, Geert Uytterhoeven wrote:
>   - Include the general PWM controller schema,
>   - Make clocks, power-domains, and resets properties required.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> v2:
>   - Keep additionalProperties, as pwm.yaml doesn't add any other
>     properties.
> ---
>  .../bindings/pwm/renesas,tpu-pwm.yaml           | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 

Applied, thanks!
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/pwm/renesas,tpu-pwm.yaml b/Documentation/devicetree/bindings/pwm/renesas,tpu-pwm.yaml
index aa9a4570c9068226..7c99e42ad780c2cd 100644
--- a/Documentation/devicetree/bindings/pwm/renesas,tpu-pwm.yaml
+++ b/Documentation/devicetree/bindings/pwm/renesas,tpu-pwm.yaml
@@ -58,6 +58,23 @@  required:
   - compatible
   - reg
   - '#pwm-cells'
+  - clocks
+  - power-domains
+
+allOf:
+  - $ref: pwm.yaml#
+
+  - if:
+      not:
+        properties:
+          compatible:
+            contains:
+              enum:
+                - renesas,tpu-r8a73a4
+                - renesas,tpu-r8a7740
+    then:
+      required:
+        - resets
 
 additionalProperties: false