| Message ID | Y6r7jSs3dFw0KZOP@nixie71 |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v2] pwm: iqs620a: Replace one remaining instance of regmap_update_bits() | expand |
On Tue, Dec 27, 2022 at 08:05:01AM -0600, Jeff LaBundy wrote: > The call to regmap_update_bits() which was responsible for clearing > the PWM output enable register bit was recently dropped in favor of > a call to regmap_clear_bits(), thereby simplifying the code. > > Similarly, the call to regmap_update_bits() which sets the same bit > can be simplified with a call to regmap_set_bits(). > > Signed-off-by: Jeff LaBundy <jeff@labundy.com> Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Best regards Uwe
diff --git a/drivers/pwm/pwm-iqs620a.c b/drivers/pwm/pwm-iqs620a.c index 4987ca940b64..8362b4870c66 100644 --- a/drivers/pwm/pwm-iqs620a.c +++ b/drivers/pwm/pwm-iqs620a.c @@ -55,8 +55,8 @@ static int iqs620_pwm_init(struct iqs620_pwm_private *iqs620_pwm, if (ret) return ret; - return regmap_update_bits(iqs62x->regmap, IQS620_PWR_SETTINGS, - IQS620_PWR_SETTINGS_PWM_OUT, 0xff); + return regmap_set_bits(iqs62x->regmap, IQS620_PWR_SETTINGS, + IQS620_PWR_SETTINGS_PWM_OUT); } static int iqs620_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm,
The call to regmap_update_bits() which was responsible for clearing the PWM output enable register bit was recently dropped in favor of a call to regmap_clear_bits(), thereby simplifying the code. Similarly, the call to regmap_update_bits() which sets the same bit can be simplified with a call to regmap_set_bits(). Signed-off-by: Jeff LaBundy <jeff@labundy.com> --- Changes in v2: - Dropped Fixes tag drivers/pwm/pwm-iqs620a.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)