| Message ID | 53C27247.2010300@gmail.com |
|---|---|
| State | Rejected |
| Headers | show |
On Sun, Jul 13, 2014 at 07:49:27PM +0800, Chen Gang wrote: > PWM_CLPS711X needs HAS_IOMEM, so let it depend on HAS_IOMEM. > > The related error (with allmodconfig under score): > > MODPOST 1365 modules > ERROR: "devm_ioremap_resource" [drivers/pwm/pwm-clps711x.ko] undefined! > > > Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com> > --- > drivers/pwm/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) NAK given the discussion in the other thread. Thierry
在 2014年7月14日，下午4:18，Thierry Reding <thierry.reding@gmail.com> 写道： > On Sun, Jul 13, 2014 at 07:49:27PM +0800, Chen Gang wrote: >> PWM_CLPS711X needs HAS_IOMEM, so let it depend on HAS_IOMEM. >> >> The related error (with allmodconfig under score): >> >> MODPOST 1365 modules >> ERROR: "devm_ioremap_resource" [drivers/pwm/pwm-clps711x.ko] undefined! >> >> >> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com> >> --- >> drivers/pwm/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > NAK given the discussion in the other thread. > > Thierry OK, thanks, and I shall continue focusing the other thread, and send related patch after get conclusion (hope I can finish within this week). Thanks — Chen Gang Open share, and attitude like air water, and life which God blessed.-- To unsubscribe from this list: send the line "unsubscribe linux-pwm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Jul 14, 2014 at 05:14:05PM +0800, Chen Gang wrote: > > 在 2014年7月14日，下午4:18，Thierry Reding <thierry.reding@gmail.com> 写道： > > > On Sun, Jul 13, 2014 at 07:49:27PM +0800, Chen Gang wrote: > >> PWM_CLPS711X needs HAS_IOMEM, so let it depend on HAS_IOMEM. > >> > >> The related error (with allmodconfig under score): > >> > >> MODPOST 1365 modules > >> ERROR: "devm_ioremap_resource" [drivers/pwm/pwm-clps711x.ko] undefined! > >> > >> > >> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com> > >> --- > >> drivers/pwm/Kconfig | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > > > > NAK given the discussion in the other thread. > > > > Thierry > > OK, thanks, and I shall continue focusing the other thread, and send related patch after > get conclusion (hope I can finish within this week). Great, thanks for taking care of this. Thierry
在 2014年7月14日，下午5:33，Thierry Reding <thierry.reding@gmail.com> 写道： > On Mon, Jul 14, 2014 at 05:14:05PM +0800, Chen Gang wrote: >> >> 在 2014年7月14日，下午4:18，Thierry Reding <thierry.reding@gmail.com> 写道： >> >>> On Sun, Jul 13, 2014 at 07:49:27PM +0800, Chen Gang wrote: >>>> PWM_CLPS711X needs HAS_IOMEM, so let it depend on HAS_IOMEM. >>>> >>>> The related error (with allmodconfig under score): >>>> >>>> MODPOST 1365 modules >>>> ERROR: "devm_ioremap_resource" [drivers/pwm/pwm-clps711x.ko] undefined! >>>> >>>> >>>> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com> >>>> --- >>>> drivers/pwm/Kconfig | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> NAK given the discussion in the other thread. >>> >>> Thierry >> >> OK, thanks, and I shall continue focusing the other thread, and send related patch after >> get conclusion (hope I can finish within this week). > > Great, thanks for taking care of this. > That what I should/will do. I start the related thread, so I have duty to try to finish it in time. :-) Thanks. — Chen Gang Open, share, and attitude like air, water, and life which God blessed.-- To unsubscribe from this list: send the line "unsubscribe linux-pwm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Oh, sorry, after a long discussion, we have to keep current status no touch -- let individual modules depends on HAS_IOMEM if they need it. So, this patch is still alive, please help check it, when you have time. Thanks. On 07/14/2014 06:00 PM, Chen Gang wrote: > > 在 2014年7月14日，下午5:33，Thierry Reding <thierry.reding@gmail.com> 写道： > >> On Mon, Jul 14, 2014 at 05:14:05PM +0800, Chen Gang wrote: >>> >>> 在 2014年7月14日，下午4:18，Thierry Reding <thierry.reding@gmail.com> 写道： >>> >>>> On Sun, Jul 13, 2014 at 07:49:27PM +0800, Chen Gang wrote: >>>>> PWM_CLPS711X needs HAS_IOMEM, so let it depend on HAS_IOMEM. >>>>> >>>>> The related error (with allmodconfig under score): >>>>> >>>>> MODPOST 1365 modules >>>>> ERROR: "devm_ioremap_resource" [drivers/pwm/pwm-clps711x.ko] undefined! >>>>> >>>>> >>>>> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com> >>>>> --- >>>>> drivers/pwm/Kconfig | 2 +- >>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> NAK given the discussion in the other thread. >>>> >>>> Thierry >>> >>> OK, thanks, and I shall continue focusing the other thread, and send related patch after >>> get conclusion (hope I can finish within this week). >> >> Great, thanks for taking care of this. >> > > That what I should/will do. I start the related thread, so I have duty to try > to finish it in time. :-) > > Thanks. > — > Chen Gang > Open, share, and attitude like air, water, and life which God blessed. >
diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig index 4ad7b89..2faf5ce 100644 --- a/drivers/pwm/Kconfig +++ b/drivers/pwm/Kconfig @@ -82,7 +82,7 @@ config PWM_BFIN config PWM_CLPS711X tristate "CLPS711X PWM support" - depends on ARCH_CLPS711X || COMPILE_TEST + depends on (ARCH_CLPS711X || COMPILE_TEST) && HAS_IOMEM help Generic PWM framework driver for Cirrus Logic CLPS711X.
PWM_CLPS711X needs HAS_IOMEM, so let it depend on HAS_IOMEM. The related error (with allmodconfig under score): MODPOST 1365 modules ERROR: "devm_ioremap_resource" [drivers/pwm/pwm-clps711x.ko] undefined! Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com> --- drivers/pwm/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)