diff mbox series

[libpwm] pwmround/pwmset: Fix check for invalid duty_offset

Message ID 20250710160417.2089742-2-u.kleine-koenig@baylibre.com
State Accepted
Headers show
Series [libpwm] pwmround/pwmset: Fix check for invalid duty_offset | expand

Commit Message

Uwe Kleine-König July 10, 2025, 4:04 p.m. UTC 
.period_length_ns == .duty_offset_ns == 0 is a valid waveform that
shouldn't trigger a warning.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
---
 pwmround.c | 2 +-
 pwmset.c   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)


base-commit: 3a9a9d36d95e8aa5ed563590d53c1715285a5ffb

Comments

Uwe Kleine-König July 21, 2025, 11:11 a.m. UTC | #1 
Hello,

On Thu, Jul 10, 2025 at 06:04:18PM +0200, Uwe Kleine-König wrote:
> .period_length_ns == .duty_offset_ns == 0 is a valid waveform that
> shouldn't trigger a warning.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>

Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/ukleinek/libpwm.git main
.

Best regards
Uwe
diff mbox series

Patch

diff --git a/pwmround.c b/pwmround.c
index 860446668d3a..da3c018c4494 100644
--- a/pwmround.c
+++ b/pwmround.c
@@ -61,7 +61,7 @@  int main(int argc, char *const argv[])
 		fprintf(stderr, "Warning: invalid waveform: duty_length = %llu > period_length = %llu\n",
 			(unsigned long long)wf.duty_length_ns, (unsigned long long)wf.period_length_ns);
 
-	if (wf.duty_offset_ns >= wf.period_length_ns)
+	if (wf.period_length_ns && wf.duty_offset_ns >= wf.period_length_ns)
 		fprintf(stderr, "Warning: invalid waveform: duty_offset = %llu >= period_length = %llu\n",
 			(unsigned long long)wf.duty_offset_ns, (unsigned long long)wf.period_length_ns);
 
diff --git a/pwmset.c b/pwmset.c
index 0fdc1a34cc2f..4c3d50109f6a 100644
--- a/pwmset.c
+++ b/pwmset.c
@@ -69,7 +69,7 @@  int main(int argc, char *const argv[])
 		fprintf(stderr, "Warning: invalid waveform: duty_length = %llu > period_length = %llu\n",
 			(unsigned long long)wf.duty_length_ns, (unsigned long long)wf.period_length_ns);
 
-	if (wf.duty_offset_ns >= wf.period_length_ns)
+	if (wf.period_length_ns && wf.duty_offset_ns >= wf.period_length_ns)
 		fprintf(stderr, "Warning: invalid waveform: duty_offset = %llu >= period_length = %llu\n",
 			(unsigned long long)wf.duty_offset_ns, (unsigned long long)wf.period_length_ns);