| Message ID | 20240520195942.11582-2-laurent.pinchart@ideasonboard.com |
|---|---|
| State | Handled Elsewhere |
| Headers | show |
| Series | ADP5585 GPIO expander, PWM and keypad controller support | expand |
On 20/05/2024 21:59, Laurent Pinchart wrote: > The Analog Devices ADP5585 is a multi-function device that requires > non-trivial DT bindings. To prepare for proper support of the device, > drop the related compatible strings from trivial-devices.yaml. They were > added by mistake, without any user in the mainline kernel, neither in > device tree sources nor in drivers. > > Fixes: e5dddbedfe09 ("dt-bindings: add ADP5585/ADP5589 entries to trivial-devices") I don't see a bug there. Just because there are no users, it is not yet a bug. This should be squashed with next patch so you keep compatibles documented. Best regards, Krzysztof
On Tue, May 21, 2024 at 09:02:19PM +0200, Krzysztof Kozlowski wrote: > On 20/05/2024 21:59, Laurent Pinchart wrote: > > The Analog Devices ADP5585 is a multi-function device that requires > > non-trivial DT bindings. To prepare for proper support of the device, > > drop the related compatible strings from trivial-devices.yaml. They were > > added by mistake, without any user in the mainline kernel, neither in > > device tree sources nor in drivers. > > > > Fixes: e5dddbedfe09 ("dt-bindings: add ADP5585/ADP5589 entries to trivial-devices") > > I don't see a bug there. Just because there are no users, it is not yet > a bug. The bug (as I see it) is that compatible strings were added to the list of trivial devices when then patch series that did so did not intend those compatible strings to be used by anything. > This should be squashed with next patch so you keep compatibles documented. I'm fine with that.
diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml index e07be7bf8395..59102d46b98e 100644 --- a/Documentation/devicetree/bindings/trivial-devices.yaml +++ b/Documentation/devicetree/bindings/trivial-devices.yaml @@ -39,10 +39,6 @@ properties: # AD5110 - Nonvolatile Digital Potentiometer - adi,ad5110 # Analog Devices ADP5585 Keypad Decoder and I/O Expansion - - adi,adp5585 - # Analog Devices ADP5585 Keypad Decoder and I/O Expansion with support for Row5 - - adi,adp5585-02 - # Analog Devices ADP5589 Keypad Decoder and I/O Expansion - adi,adp5589 # Analog Devices LT7182S Dual Channel 6A, 20V PolyPhase Step-Down Silent Switcher - adi,lt7182s
The Analog Devices ADP5585 is a multi-function device that requires non-trivial DT bindings. To prepare for proper support of the device, drop the related compatible strings from trivial-devices.yaml. They were added by mistake, without any user in the mainline kernel, neither in device tree sources nor in drivers. Fixes: e5dddbedfe09 ("dt-bindings: add ADP5585/ADP5589 entries to trivial-devices") Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- Documentation/devicetree/bindings/trivial-devices.yaml | 4 ---- 1 file changed, 4 deletions(-)