diff mbox series

[1/2,v4] dt-bindings: pwm: Add AXI PWM generator

Message ID 20240301173343.1086332-2-tgamblin@baylibre.com
State Superseded
Headers show
Series pwm: add axi-pwm-gen driver | expand

Commit Message

Trevor Gamblin March 1, 2024, 5:33 p.m. UTC 
From: Drew Fustini <dfustini@baylibre.com>

Add Analog Devices AXI PWM generator.

Link: https://wiki.analog.com/resources/fpga/docs/axi_pwm_gen
Signed-off-by: Drew Fustini <dfustini@baylibre.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Co-developed-by: Trevor Gamblin <tgamblin@baylibre.com>
Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com>
---
v4 changes: None (rebased, added maintainer's previous Reviewed-by)
v3 changes: None (rebased, added maintainer's previous Reviewed-by)

v2 changes:
* Address feedback for driver and device tree in v1:
  * Relocate "unevaluatedProperties" in device tree binding
  * Remove redundant "bindings for" in description

---
 .../bindings/pwm/adi,axi-pwmgen.yaml          | 48 +++++++++++++++++++
 MAINTAINERS                                   |  8 ++++
 2 files changed, 56 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml

Comments

Uwe Kleine-König April 11, 2024, 10:32 a.m. UTC | #1 
Hello,

On Fri, Mar 01, 2024 at 12:33:41PM -0500, Trevor Gamblin wrote:
> From: Drew Fustini <dfustini@baylibre.com>
> 
> Add Analog Devices AXI PWM generator.
> 
> Link: https://wiki.analog.com/resources/fpga/docs/axi_pwm_gen
> Signed-off-by: Drew Fustini <dfustini@baylibre.com>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Co-developed-by: Trevor Gamblin <tgamblin@baylibre.com>
> Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com>
> ---
> v4 changes: None (rebased, added maintainer's previous Reviewed-by)
> v3 changes: None (rebased, added maintainer's previous Reviewed-by)
> 
> v2 changes:
> * Address feedback for driver and device tree in v1:
>   * Relocate "unevaluatedProperties" in device tree binding
>   * Remove redundant "bindings for" in description
> 
> ---
>  .../bindings/pwm/adi,axi-pwmgen.yaml          | 48 +++++++++++++++++++
>  MAINTAINERS                                   |  8 ++++
>  2 files changed, 56 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml
> 
> diff --git a/Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml b/Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml
> new file mode 100644
> index 000000000000..63461920a362
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml
> @@ -0,0 +1,48 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/pwm/adi,axi-pwmgen.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Analog Devices AXI PWM generator
> +
> +maintainers:
> +  - Michael Hennerich <Michael.Hennerich@analog.com>
> +  - Nuno Sá <nuno.sa@analog.com>

Would be great to get an ack from these two.

Otherwise looks fine to me.

Best regards
Uwe
Hennerich, Michael April 11, 2024, 10:38 a.m. UTC | #2 
> -----Original Message-----
> From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Sent: Thursday, April 11, 2024 12:33 PM
> To: Trevor Gamblin <tgamblin@baylibre.com>
> Cc: linux-pwm@vger.kernel.org; linux-kernel@vger.kernel.org; Hennerich,
> Michael <Michael.Hennerich@analog.com>; Sa, Nuno
> <Nuno.Sa@analog.com>; devicetree@vger.kernel.org; robh+dt@kernel.org;
> krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; David Lechner
> <dlechner@baylibre.com>; Drew Fustini <dfustini@baylibre.com>; Krzysztof
> Kozlowski <krzysztof.kozlowski@linaro.org>
> Subject: Re: [PATCH 1/2 v4] dt-bindings: pwm: Add AXI PWM generator
> 
> 
> Hello,
> 
> On Fri, Mar 01, 2024 at 12:33:41PM -0500, Trevor Gamblin wrote:
> > From: Drew Fustini <dfustini@baylibre.com>
> >
> > Add Analog Devices AXI PWM generator.
> >
> > Link: https://wiki.analog.com/resources/fpga/docs/axi_pwm_gen
> > Signed-off-by: Drew Fustini <dfustini@baylibre.com>
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > Co-developed-by: Trevor Gamblin <tgamblin@baylibre.com>
> > Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com>
> > ---
> > v4 changes: None (rebased, added maintainer's previous Reviewed-by)
> > v3 changes: None (rebased, added maintainer's previous Reviewed-by)
> >
> > v2 changes:
> > * Address feedback for driver and device tree in v1:
> >   * Relocate "unevaluatedProperties" in device tree binding
> >   * Remove redundant "bindings for" in description
> >
> > ---
> >  .../bindings/pwm/adi,axi-pwmgen.yaml          | 48 +++++++++++++++++++
> >  MAINTAINERS                                   |  8 ++++
> >  2 files changed, 56 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml
> > b/Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml
> > new file mode 100644
> > index 000000000000..63461920a362
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml
> > @@ -0,0 +1,48 @@
> > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause %YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/pwm/adi,axi-pwmgen.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Analog Devices AXI PWM generator
> > +
> > +maintainers:
> > +  - Michael Hennerich <Michael.Hennerich@analog.com>
> > +  - Nuno Sá <nuno.sa@analog.com>
> 
> Would be great to get an ack from these two.

Looks good to me.

Acked-by: Michael Hennerich <michael.hennerich@analog.com>

> Otherwise looks fine to me.
> 
> Best regards
> Uwe
> 
> --
> Pengutronix e.K.                           | Uwe Kleine-König            |
> Industrial Linux Solutions                 | https://www.pengutronix.de/ |
Nuno Sá April 11, 2024, 10:42 a.m. UTC | #3 
On Fri, 2024-03-01 at 12:33 -0500, Trevor Gamblin wrote:
> From: Drew Fustini <dfustini@baylibre.com>
> 
> Add Analog Devices AXI PWM generator.
> 
> Link: https://wiki.analog.com/resources/fpga/docs/axi_pwm_gen
> Signed-off-by: Drew Fustini <dfustini@baylibre.com>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Co-developed-by: Trevor Gamblin <tgamblin@baylibre.com>
> Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com>
> ---

Acked-by: Nuno Sa <nuno.sa@analog.com>

> v4 changes: None (rebased, added maintainer's previous Reviewed-by)
> v3 changes: None (rebased, added maintainer's previous Reviewed-by)
> 
> v2 changes:
> * Address feedback for driver and device tree in v1:
>   * Relocate "unevaluatedProperties" in device tree binding
>   * Remove redundant "bindings for" in description
> 
> ---
>  .../bindings/pwm/adi,axi-pwmgen.yaml          | 48 +++++++++++++++++++
>  MAINTAINERS                                   |  8 ++++
>  2 files changed, 56 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml
> 
> diff --git a/Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml
> b/Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml
> new file mode 100644
> index 000000000000..63461920a362
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml
> @@ -0,0 +1,48 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/pwm/adi,axi-pwmgen.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Analog Devices AXI PWM generator
> +
> +maintainers:
> +  - Michael Hennerich <Michael.Hennerich@analog.com>
> +  - Nuno Sá <nuno.sa@analog.com>
> +
> +description:
> +  The Analog Devices AXI PWM generator can generate PWM signals
> +  with variable pulse width and period.
> +
> +  https://wiki.analog.com/resources/fpga/docs/axi_pwm_gen
> +
> +allOf:
> +  - $ref: pwm.yaml#
> +
> +properties:
> +  compatible:
> +    const: adi,axi-pwmgen-1.00.a
> +
> +  reg:
> +    maxItems: 1
> +
> +  "#pwm-cells":
> +    const: 2
> +
> +  clocks:
> +    maxItems: 1
> +
> +required:
> +  - reg
> +  - clocks
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    pwm@44b00000 {
> +       compatible = "adi,axi-pwmgen-1.00.a";
> +       reg = <0x44b00000 0x1000>;
> +       clocks = <&spi_clk>;
> +       #pwm-cells = <2>;
> +    };
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 8d1052fa6a69..8a4ed5545680 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -3431,6 +3431,14 @@ W:	https://ez.analog.com/linux-software-drivers
>  F:	Documentation/devicetree/bindings/spi/adi,axi-spi-engine.yaml
>  F:	drivers/spi/spi-axi-spi-engine.c
>  
> +AXI PWM GENERATOR
> +M:	Michael Hennerich <michael.hennerich@analog.com>
> +M:	Nuno Sá <nuno.sa@analog.com>
> +L:	linux-pwm@vger.kernel.org
> +S:	Supported
> +W:	https://ez.analog.com/linux-software-drivers
> +F:	Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml
> +
>  AXXIA I2C CONTROLLER
>  M:	Krzysztof Adamski <krzysztof.adamski@nokia.com>
>  L:	linux-i2c@vger.kernel.org
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml b/Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml
new file mode 100644
index 000000000000..63461920a362
--- /dev/null
+++ b/Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml
@@ -0,0 +1,48 @@ 
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/pwm/adi,axi-pwmgen.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Analog Devices AXI PWM generator
+
+maintainers:
+  - Michael Hennerich <Michael.Hennerich@analog.com>
+  - Nuno Sá <nuno.sa@analog.com>
+
+description:
+  The Analog Devices AXI PWM generator can generate PWM signals
+  with variable pulse width and period.
+
+  https://wiki.analog.com/resources/fpga/docs/axi_pwm_gen
+
+allOf:
+  - $ref: pwm.yaml#
+
+properties:
+  compatible:
+    const: adi,axi-pwmgen-1.00.a
+
+  reg:
+    maxItems: 1
+
+  "#pwm-cells":
+    const: 2
+
+  clocks:
+    maxItems: 1
+
+required:
+  - reg
+  - clocks
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    pwm@44b00000 {
+       compatible = "adi,axi-pwmgen-1.00.a";
+       reg = <0x44b00000 0x1000>;
+       clocks = <&spi_clk>;
+       #pwm-cells = <2>;
+    };
diff --git a/MAINTAINERS b/MAINTAINERS
index 8d1052fa6a69..8a4ed5545680 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3431,6 +3431,14 @@  W:	https://ez.analog.com/linux-software-drivers
 F:	Documentation/devicetree/bindings/spi/adi,axi-spi-engine.yaml
 F:	drivers/spi/spi-axi-spi-engine.c
 
+AXI PWM GENERATOR
+M:	Michael Hennerich <michael.hennerich@analog.com>
+M:	Nuno Sá <nuno.sa@analog.com>
+L:	linux-pwm@vger.kernel.org
+S:	Supported
+W:	https://ez.analog.com/linux-software-drivers
+F:	Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml
+
 AXXIA I2C CONTROLLER
 M:	Krzysztof Adamski <krzysztof.adamski@nokia.com>
 L:	linux-i2c@vger.kernel.org