| Message ID | 20240224112902.55539-2-Leif.Middelschulte@gmail.com |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [v4,1/2] pwm: imx27: fix race condition .apply,.get_state | expand |
Hello Leif, On Sat, Feb 24, 2024 at 12:29:01PM +0100, Leif Middelschulte wrote: > diff --git a/drivers/pwm/pwm-imx27.c b/drivers/pwm/pwm-imx27.c > index cb564460b79c..d00d79a5edb1 100644 > --- a/drivers/pwm/pwm-imx27.c > +++ b/drivers/pwm/pwm-imx27.c > @@ -255,7 +255,7 @@ static void pwm_imx27_wait_fifo_slot(struct pwm_chip *chip, > sr = readl(imx->mmio_base + MX3_PWMSR); > fifoav = FIELD_GET(MX3_PWMSR_FIFOAV, sr); > if (fifoav == MX3_PWMSR_FIFOAV_4WORDS) { > - period_ms = DIV_ROUND_UP_ULL(pwm_get_period(pwm), > + period_ms = DIV_ROUND_UP_ULL(pwm->state.period, > NSEC_PER_MSEC); > msleep(period_ms); This doesn't apply anymore on top of pwm/for-next. See commit 1706175c682fdb3fbe0b70d50b137aaa270959db which includes this change (and more). Best regards Uwe
diff --git a/drivers/pwm/pwm-imx27.c b/drivers/pwm/pwm-imx27.c index cb564460b79c..d00d79a5edb1 100644 --- a/drivers/pwm/pwm-imx27.c +++ b/drivers/pwm/pwm-imx27.c @@ -255,7 +255,7 @@ static void pwm_imx27_wait_fifo_slot(struct pwm_chip *chip, sr = readl(imx->mmio_base + MX3_PWMSR); fifoav = FIELD_GET(MX3_PWMSR_FIFOAV, sr); if (fifoav == MX3_PWMSR_FIFOAV_4WORDS) { - period_ms = DIV_ROUND_UP_ULL(pwm_get_period(pwm), + period_ms = DIV_ROUND_UP_ULL(pwm->state.period, NSEC_PER_MSEC); msleep(period_ms);
Access struct members directly. Signed-off-by: Leif Middelschulte <Leif.Middelschulte@gmail.com> --- drivers/pwm/pwm-imx27.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)