| Message ID | 20240129081029.2355612-2-u.kleine-koenig@pengutronix.de |
|---|---|
| State | Accepted |
| Headers | show |
| Series | pwm: bcm2835: Drop write-only member of driver private data | expand |
Hello, On Mon, Jan 29, 2024 at 09:10:30AM +0100, Uwe Kleine-König wrote: > Since commit fcc760729359 ("pwm: bcm2835: Allow PWM driver to be used in > atomic context") struct bcm2835_pwm::dev is only assigned a value, but > it's never used. So the dev member can just be dropped. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> applied to https://git.kernel.org/pub/scm/linux/kernel/git/ukleinek/linux.git pwm/for-next Best regards Uwe
diff --git a/drivers/pwm/pwm-bcm2835.c b/drivers/pwm/pwm-bcm2835.c index 283cf27f25ba..711c174bbe23 100644 --- a/drivers/pwm/pwm-bcm2835.c +++ b/drivers/pwm/pwm-bcm2835.c @@ -25,7 +25,6 @@ struct bcm2835_pwm { struct pwm_chip chip; - struct device *dev; void __iomem *base; struct clk *clk; unsigned long rate; @@ -142,8 +141,6 @@ static int bcm2835_pwm_probe(struct platform_device *pdev) if (!pc) return -ENOMEM; - pc->dev = &pdev->dev; - pc->base = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(pc->base)) return PTR_ERR(pc->base);
Since commit fcc760729359 ("pwm: bcm2835: Allow PWM driver to be used in atomic context") struct bcm2835_pwm::dev is only assigned a value, but it's never used. So the dev member can just be dropped. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- drivers/pwm/pwm-bcm2835.c | 3 --- 1 file changed, 3 deletions(-) base-commit: 979c6fe7e799d2cab0a99c4b8c41cc48f10aca0c