| Message ID | 20240125-pxa-pwm-yaml-v3-1-10b0b0dc02bd@skole.hr |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [RESEND,v3] dt-bindings: pxa-pwm: Convert to YAML | expand |
Hello Duje, On Thu, Jan 25, 2024 at 06:36:33PM +0100, Duje Mihanović wrote: > Convert the PXA PWM binding file from TXT to YAML. > > The original binding does not mention any clocks, but the PWM controller > will not probe without a clock. > > Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > Signed-off-by: Duje Mihanović <duje.mihanovic@skole.hr> I still have your v3 on my radar, I just didn't come around yet to look in more detail and (probably) apply. It might not apply to all maintainers, but for me such a resend is just adding to my todo list. (I searched for the original v3, compared the submissions, didn't find a relevant difference and no further explanation for the resend and now explain this.) As long as your patch appears on https://patchwork.ozlabs.org/project/linux-pwm/list/ as actionable, I will eventually come around to address it. Thanks Uwe
On 25/01/2024 18:36, Duje Mihanović wrote: > Convert the PXA PWM binding file from TXT to YAML. > > The original binding does not mention any clocks, but the PWM controller > will not probe without a clock. > > Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > Signed-off-by: Duje Mihanović <duje.mihanovic@skole.hr> > --- Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/pwm/marvell,pxa-pwm.yaml b/Documentation/devicetree/bindings/pwm/marvell,pxa-pwm.yaml new file mode 100644 index 000000000000..ba6325575ea0 --- /dev/null +++ b/Documentation/devicetree/bindings/pwm/marvell,pxa-pwm.yaml @@ -0,0 +1,51 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/pwm/marvell,pxa-pwm.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Marvell PXA PWM + +maintainers: + - Duje Mihanović <duje.mihanovic@skole.hr> + +allOf: + - $ref: pwm.yaml# + +properties: + compatible: + enum: + - marvell,pxa250-pwm + - marvell,pxa270-pwm + - marvell,pxa168-pwm + - marvell,pxa910-pwm + + reg: + # Length should be 0x10 + maxItems: 1 + + "#pwm-cells": + # Used for specifying the period length in nanoseconds + const: 1 + + clocks: + maxItems: 1 + +required: + - compatible + - reg + - "#pwm-cells" + - clocks + +additionalProperties: false + +examples: + - | + #include <dt-bindings/clock/pxa-clock.h> + + pwm0: pwm@40b00000 { + compatible = "marvell,pxa250-pwm"; + reg = <0x40b00000 0x10>; + #pwm-cells = <1>; + clocks = <&clks CLK_PWM0>; + }; diff --git a/Documentation/devicetree/bindings/pwm/pxa-pwm.txt b/Documentation/devicetree/bindings/pwm/pxa-pwm.txt deleted file mode 100644 index 5ae9f1e3c338..000000000000 --- a/Documentation/devicetree/bindings/pwm/pxa-pwm.txt +++ /dev/null @@ -1,30 +0,0 @@ -Marvell PWM controller - -Required properties: -- compatible: should be one or more of: - - "marvell,pxa250-pwm" - - "marvell,pxa270-pwm" - - "marvell,pxa168-pwm" - - "marvell,pxa910-pwm" -- reg: Physical base address and length of the registers used by the PWM channel - Note that one device instance must be created for each PWM that is used, so the - length covers only the register window for one PWM output, not that of the - entire PWM controller. Currently length is 0x10 for all supported devices. -- #pwm-cells: Should be 1. This cell is used to specify the period in - nanoseconds. - -Example PWM device node: - -pwm0: pwm@40b00000 { - compatible = "marvell,pxa250-pwm"; - reg = <0x40b00000 0x10>; - #pwm-cells = <1>; -}; - -Example PWM client node: - -backlight { - compatible = "pwm-backlight"; - pwms = <&pwm0 5000000>; - ... -}