| Message ID | 20231023174616.2282067-22-u.kleine-koenig@pengutronix.de |
|---|---|
| State | Accepted |
| Delegated to: | Uwe Kleine-König |
| Headers | show |
| Series | pwm: Use DEFINE_SIMPLE_DEV_PM_OPS for PM functions | expand |
On 10/23/23 19:46, Uwe Kleine-König wrote: > This macro has the advantage over SIMPLE_DEV_PM_OPS that we don't have to > care about when the functions are actually used, so the corresponding > __maybe_unused can be dropped. > > Also make use of pm_ptr() to discard all PM related stuff if CONFIG_PM > isn't enabled. > > Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > --- > drivers/pwm/pwm-stm32.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) Hi Uwe, Reviewed-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com> Thanks for the cleanups. Fabrice > > diff --git a/drivers/pwm/pwm-stm32.c b/drivers/pwm/pwm-stm32.c > index 3303a754ea02..8be037757b8b 100644 > --- a/drivers/pwm/pwm-stm32.c > +++ b/drivers/pwm/pwm-stm32.c > @@ -645,7 +645,7 @@ static int stm32_pwm_probe(struct platform_device *pdev) > return 0; > } > > -static int __maybe_unused stm32_pwm_suspend(struct device *dev) > +static int stm32_pwm_suspend(struct device *dev) > { > struct stm32_pwm *priv = dev_get_drvdata(dev); > unsigned int i; > @@ -666,7 +666,7 @@ static int __maybe_unused stm32_pwm_suspend(struct device *dev) > return pinctrl_pm_select_sleep_state(dev); > } > > -static int __maybe_unused stm32_pwm_resume(struct device *dev) > +static int stm32_pwm_resume(struct device *dev) > { > struct stm32_pwm *priv = dev_get_drvdata(dev); > int ret; > @@ -679,7 +679,7 @@ static int __maybe_unused stm32_pwm_resume(struct device *dev) > return stm32_pwm_apply_breakinputs(priv); > } > > -static SIMPLE_DEV_PM_OPS(stm32_pwm_pm_ops, stm32_pwm_suspend, stm32_pwm_resume); > +static DEFINE_SIMPLE_DEV_PM_OPS(stm32_pwm_pm_ops, stm32_pwm_suspend, stm32_pwm_resume); > > static const struct of_device_id stm32_pwm_of_match[] = { > { .compatible = "st,stm32-pwm", }, > @@ -692,7 +692,7 @@ static struct platform_driver stm32_pwm_driver = { > .driver = { > .name = "stm32-pwm", > .of_match_table = stm32_pwm_of_match, > - .pm = &stm32_pwm_pm_ops, > + .pm = pm_ptr(&stm32_pwm_pm_ops), > }, > }; > module_platform_driver(stm32_pwm_driver);
diff --git a/drivers/pwm/pwm-stm32.c b/drivers/pwm/pwm-stm32.c index 3303a754ea02..8be037757b8b 100644 --- a/drivers/pwm/pwm-stm32.c +++ b/drivers/pwm/pwm-stm32.c @@ -645,7 +645,7 @@ static int stm32_pwm_probe(struct platform_device *pdev) return 0; } -static int __maybe_unused stm32_pwm_suspend(struct device *dev) +static int stm32_pwm_suspend(struct device *dev) { struct stm32_pwm *priv = dev_get_drvdata(dev); unsigned int i; @@ -666,7 +666,7 @@ static int __maybe_unused stm32_pwm_suspend(struct device *dev) return pinctrl_pm_select_sleep_state(dev); } -static int __maybe_unused stm32_pwm_resume(struct device *dev) +static int stm32_pwm_resume(struct device *dev) { struct stm32_pwm *priv = dev_get_drvdata(dev); int ret; @@ -679,7 +679,7 @@ static int __maybe_unused stm32_pwm_resume(struct device *dev) return stm32_pwm_apply_breakinputs(priv); } -static SIMPLE_DEV_PM_OPS(stm32_pwm_pm_ops, stm32_pwm_suspend, stm32_pwm_resume); +static DEFINE_SIMPLE_DEV_PM_OPS(stm32_pwm_pm_ops, stm32_pwm_suspend, stm32_pwm_resume); static const struct of_device_id stm32_pwm_of_match[] = { { .compatible = "st,stm32-pwm", }, @@ -692,7 +692,7 @@ static struct platform_driver stm32_pwm_driver = { .driver = { .name = "stm32-pwm", .of_match_table = stm32_pwm_of_match, - .pm = &stm32_pwm_pm_ops, + .pm = pm_ptr(&stm32_pwm_pm_ops), }, }; module_platform_driver(stm32_pwm_driver);