| Message ID | 20230303185445.2112695-26-u.kleine-koenig@pengutronix.de |
|---|---|
| State | Accepted |
| Headers | show |
| Series | pwm: Convert to platform remove callback returning void | expand |
Dne petek, 03. marec 2023 ob 19:54:40 CET je Uwe Kleine-König napisal(a): > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is (mostly) ignored > and this typically results in resource leaks. To improve here there is a > quest to make the remove callback return void. In the first step of this > quest all drivers are converted to .remove_new() which already returns > void. > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > --- Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com> Best regards, Jernej > drivers/pwm/pwm-sun4i.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/pwm/pwm-sun4i.c b/drivers/pwm/pwm-sun4i.c > index b973da73e9ab..a8790a8fc53e 100644 > --- a/drivers/pwm/pwm-sun4i.c > +++ b/drivers/pwm/pwm-sun4i.c > @@ -477,7 +477,7 @@ static int sun4i_pwm_probe(struct platform_device *pdev) > return ret; > } > > -static int sun4i_pwm_remove(struct platform_device *pdev) > +static void sun4i_pwm_remove(struct platform_device *pdev) > { > struct sun4i_pwm_chip *sun4ichip = platform_get_drvdata(pdev); > > @@ -485,8 +485,6 @@ static int sun4i_pwm_remove(struct platform_device > *pdev) > > clk_disable_unprepare(sun4ichip->bus_clk); > reset_control_assert(sun4ichip->rst); > - > - return 0; > } > > static struct platform_driver sun4i_pwm_driver = { > @@ -495,7 +493,7 @@ static struct platform_driver sun4i_pwm_driver = { > .of_match_table = sun4i_pwm_dt_ids, > }, > .probe = sun4i_pwm_probe, > - .remove = sun4i_pwm_remove, > + .remove_new = sun4i_pwm_remove, > }; > module_platform_driver(sun4i_pwm_driver);
diff --git a/drivers/pwm/pwm-sun4i.c b/drivers/pwm/pwm-sun4i.c index b973da73e9ab..a8790a8fc53e 100644 --- a/drivers/pwm/pwm-sun4i.c +++ b/drivers/pwm/pwm-sun4i.c @@ -477,7 +477,7 @@ static int sun4i_pwm_probe(struct platform_device *pdev) return ret; } -static int sun4i_pwm_remove(struct platform_device *pdev) +static void sun4i_pwm_remove(struct platform_device *pdev) { struct sun4i_pwm_chip *sun4ichip = platform_get_drvdata(pdev); @@ -485,8 +485,6 @@ static int sun4i_pwm_remove(struct platform_device *pdev) clk_disable_unprepare(sun4ichip->bus_clk); reset_control_assert(sun4ichip->rst); - - return 0; } static struct platform_driver sun4i_pwm_driver = { @@ -495,7 +493,7 @@ static struct platform_driver sun4i_pwm_driver = { .of_match_table = sun4i_pwm_dt_ids, }, .probe = sun4i_pwm_probe, - .remove = sun4i_pwm_remove, + .remove_new = sun4i_pwm_remove, }; module_platform_driver(sun4i_pwm_driver);
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- drivers/pwm/pwm-sun4i.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)