| Message ID | 20220420141556.681212-4-fabiobaltieri@chromium.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add channel type support to pwm-cros-ec | expand |
On Wed, Apr 20, 2022 at 02:15:55PM +0000, Fabio Baltieri wrote: > Update google,cros-ec-pwm node documentation to mention the > google,cros-ec-pwm-type compatible. It would be good if the subject provided some clue what the update is. Every change is an update. And all bindings are 'documentation' so that can be dropped. > > Signed-off-by: Fabio Baltieri <fabiobaltieri@chromium.org> > --- > .../devicetree/bindings/pwm/google,cros-ec-pwm.yaml | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) In any case, Reviewed-by: Rob Herring <robh@kernel.org>
On Mon, Apr 25, 2022 at 04:58:55PM -0500, Rob Herring wrote: > On Wed, Apr 20, 2022 at 02:15:55PM +0000, Fabio Baltieri wrote: > > Update google,cros-ec-pwm node documentation to mention the > > google,cros-ec-pwm-type compatible. > > It would be good if the subject provided some clue what the update is. > Every change is an update. And all bindings are 'documentation' so > that can be dropped. Fair enough, I'll reword the subject and send a v6. > > > > > Signed-off-by: Fabio Baltieri <fabiobaltieri@chromium.org> > > --- > > .../devicetree/bindings/pwm/google,cros-ec-pwm.yaml | 9 ++++++++- > > 1 file changed, 8 insertions(+), 1 deletion(-) > > In any case, > > Reviewed-by: Rob Herring <robh@kernel.org> > Thanks!
diff --git a/Documentation/devicetree/bindings/pwm/google,cros-ec-pwm.yaml b/Documentation/devicetree/bindings/pwm/google,cros-ec-pwm.yaml index 7ab6912a845f..c8577bdf6c94 100644 --- a/Documentation/devicetree/bindings/pwm/google,cros-ec-pwm.yaml +++ b/Documentation/devicetree/bindings/pwm/google,cros-ec-pwm.yaml @@ -21,7 +21,14 @@ allOf: properties: compatible: - const: google,cros-ec-pwm + oneOf: + - description: PWM controlled using EC_PWM_TYPE_GENERIC channels. + items: + - const: google,cros-ec-pwm + - description: PWM controlled using CROS_EC_PWM_DT_<...> types. + items: + - const: google,cros-ec-pwm-type + "#pwm-cells": description: The cell specifies the PWM index. const: 1
Update google,cros-ec-pwm node documentation to mention the google,cros-ec-pwm-type compatible. Signed-off-by: Fabio Baltieri <fabiobaltieri@chromium.org> --- .../devicetree/bindings/pwm/google,cros-ec-pwm.yaml | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)