diff mbox series

[V2] pwm: rcar: Use div64_ul instead of do_div

Message ID 20211117130144.161788-1-deng.changcheng@zte.com.cn
State Superseded
Headers show
Series [V2] pwm: rcar: Use div64_ul instead of do_div | expand

Commit Message

CGEL Nov. 17, 2021, 1:01 p.m. UTC 
From: Changcheng Deng <deng.changcheng@zte.com.cn>

do_div() does a 64-by-32 division. If the divisor is unsigned long, using
div64_ul can avoid truncation to 32-bit.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Changcheng Deng <deng.changcheng@zte.com.cn>
---
 drivers/pwm/pwm-rcar.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/drivers/pwm/pwm-rcar.c b/drivers/pwm/pwm-rcar.c
index b437192380e2..fb475c188e1e 100644
--- a/drivers/pwm/pwm-rcar.c
+++ b/drivers/pwm/pwm-rcar.c
@@ -111,7 +111,7 @@  static int rcar_pwm_set_counter(struct rcar_pwm_chip *rp, int div, int duty_ns,
 	u32 cyc, ph;
 
 	one_cycle = (unsigned long long)NSEC_PER_SEC * 100ULL * (1 << div);
-	do_div(one_cycle, clk_rate);
+	one_cycle = div64_ul(one_cycle, clk_rate);
 
 	tmp = period_ns * 100ULL;
 	do_div(tmp, one_cycle);