From patchwork Wed Sep 15 06:55:40 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 1528223 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; secure) header.d=sang-engineering.com header.i=@sang-engineering.com header.a=rsa-sha256 header.s=k1 header.b=Rj5AqS/N; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-pwm-owner@vger.kernel.org; receiver=) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4H8WFm4Jbpz9t0k for ; Wed, 15 Sep 2021 16:55:56 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236490AbhIOG5K (ORCPT ); Wed, 15 Sep 2021 02:57:10 -0400 Received: from www.zeus03.de ([194.117.254.33]:34020 "EHLO mail.zeus03.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236505AbhIOG5J (ORCPT ); Wed, 15 Sep 2021 02:57:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple; d=sang-engineering.com; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=k1; bh=MKuNVIxx3nvizD rJ1e94aXzRhsuvHTdZPjvuEZqvKiY=; b=Rj5AqS/NMNcTFRamgJJNPXvBOXE91i jPLIsgq6RyvaOOz0sl7gD/4amqzsi5hZhk9EDPBagIRrIOODArhVyTGIMrw3rY/1 DAAWHerx9QxWlM4Ef0+0mUzkPKTrMXvC+qrxaVOJE+5thT+JTNpXQjqVYZfuke7o ANJwuZsH7g8qc= Received: (qmail 696330 invoked from network); 15 Sep 2021 08:55:47 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 15 Sep 2021 08:55:47 +0200 X-UD-Smtp-Session: l3s3148p1@xZQXMAPMnIsgAwDPXwzFAFG7/ghv85hq From: Wolfram Sang To: linux-pwm@vger.kernel.org Cc: linux-renesas-soc@vger.kernel.org, Duc Nguyen , Wolfram Sang , Thierry Reding , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Lee Jones , linux-kernel@vger.kernel.org Subject: [PATCH 1/2] pwm: renesas-tpu: better errno for impossible rates Date: Wed, 15 Sep 2021 08:55:40 +0200 Message-Id: <20210915065542.1897-2-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210915065542.1897-1-wsa+renesas@sang-engineering.com> References: <20210915065542.1897-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-pwm@vger.kernel.org From: Duc Nguyen ENOTSUP has confused users. EINVAL has been considered clearer. Change the errno, we were the only ones using ENOTSUP in this subsystem anyhow. Signed-off-by: Duc Nguyen [wsa: split and reworded commit message] Signed-off-by: Wolfram Sang --- drivers/pwm/pwm-renesas-tpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pwm/pwm-renesas-tpu.c b/drivers/pwm/pwm-renesas-tpu.c index 4381df90a527..754440194650 100644 --- a/drivers/pwm/pwm-renesas-tpu.c +++ b/drivers/pwm/pwm-renesas-tpu.c @@ -269,7 +269,7 @@ static int tpu_pwm_config(struct pwm_chip *chip, struct pwm_device *_pwm, if (prescaler == ARRAY_SIZE(prescalers) || period == 0) { dev_err(&tpu->pdev->dev, "clock rate mismatch\n"); - return -ENOTSUPP; + return -EINVAL; } if (duty_ns) {