diff mbox series

pwm: atmel: drop unused header

Message ID 20210909080903.307314-1-u.kleine-koenig@pengutronix.de
State Accepted
Headers show
Series pwm: atmel: drop unused header | expand

Commit Message

Uwe Kleine-König Sept. 9, 2021, 8:09 a.m. UTC
Since commit 52eaba4cedbd ("pwm: atmel: Rework tracking updates pending
in hardware") the driver doesn't make use of mutexes any more, so the
header defining these doesn't need to be included.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 drivers/pwm/pwm-atmel.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Alexandre Belloni Sept. 9, 2021, 8:51 a.m. UTC | #1
On 09/09/2021 10:09:03+0200, Uwe Kleine-König wrote:
> Since commit 52eaba4cedbd ("pwm: atmel: Rework tracking updates pending
> in hardware") the driver doesn't make use of mutexes any more, so the
> header defining these doesn't need to be included.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

> ---
>  drivers/pwm/pwm-atmel.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/pwm/pwm-atmel.c b/drivers/pwm/pwm-atmel.c
> index e748604403cc..98b34ea9f38e 100644
> --- a/drivers/pwm/pwm-atmel.c
> +++ b/drivers/pwm/pwm-atmel.c
> @@ -24,7 +24,6 @@
>  #include <linux/err.h>
>  #include <linux/io.h>
>  #include <linux/module.h>
> -#include <linux/mutex.h>
>  #include <linux/of.h>
>  #include <linux/of_device.h>
>  #include <linux/platform_device.h>
> -- 
> 2.30.2
>
Claudiu Beznea Sept. 10, 2021, 6:14 a.m. UTC | #2
On 09.09.2021 11:09, Uwe Kleine-König wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> Since commit 52eaba4cedbd ("pwm: atmel: Rework tracking updates pending
> in hardware") the driver doesn't make use of mutexes any more, so the
> header defining these doesn't need to be included.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Acked-by: Claudiu Beznea <claudiu.beznea@microchip.com>

> ---
>  drivers/pwm/pwm-atmel.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/pwm/pwm-atmel.c b/drivers/pwm/pwm-atmel.c
> index e748604403cc..98b34ea9f38e 100644
> --- a/drivers/pwm/pwm-atmel.c
> +++ b/drivers/pwm/pwm-atmel.c
> @@ -24,7 +24,6 @@
>  #include <linux/err.h>
>  #include <linux/io.h>
>  #include <linux/module.h>
> -#include <linux/mutex.h>
>  #include <linux/of.h>
>  #include <linux/of_device.h>
>  #include <linux/platform_device.h>
> --
> 2.30.2
>
Nicolas Ferre Jan. 30, 2023, 5:29 p.m. UTC | #3
Thierry,

On 09/09/2021 at 10:09, Uwe Kleine-König wrote:
> Since commit 52eaba4cedbd ("pwm: atmel: Rework tracking updates pending
> in hardware") the driver doesn't make use of mutexes any more, so the
> header defining these doesn't need to be included.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

It looks like this (trivial) patch was forgotten for some time even if 
Acked by several of us: aka ping.

> ---
>   drivers/pwm/pwm-atmel.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/pwm/pwm-atmel.c b/drivers/pwm/pwm-atmel.c
> index e748604403cc..98b34ea9f38e 100644
> --- a/drivers/pwm/pwm-atmel.c
> +++ b/drivers/pwm/pwm-atmel.c
> @@ -24,7 +24,6 @@
>   #include <linux/err.h>
>   #include <linux/io.h>
>   #include <linux/module.h>
> -#include <linux/mutex.h>
>   #include <linux/of.h>
>   #include <linux/of_device.h>
>   #include <linux/platform_device.h>
> --
> 2.30.2
>
Uwe Kleine-König Jan. 30, 2023, 5:34 p.m. UTC | #4
Hello Nicolas,

On Mon, Jan 30, 2023 at 06:29:34PM +0100, Nicolas Ferre wrote:
> On 09/09/2021 at 10:09, Uwe Kleine-König wrote:
> > Since commit 52eaba4cedbd ("pwm: atmel: Rework tracking updates pending
> > in hardware") the driver doesn't make use of mutexes any more, so the
> > header defining these doesn't need to be included.
> > 
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> 
> It looks like this (trivial) patch was forgotten for some time even if Acked
> by several of us: aka ping.

Hmm, it's in the mainline since 5.16-rc1 as commit 6f897a108508.

Best regards
Uwe
diff mbox series

Patch

diff --git a/drivers/pwm/pwm-atmel.c b/drivers/pwm/pwm-atmel.c
index e748604403cc..98b34ea9f38e 100644
--- a/drivers/pwm/pwm-atmel.c
+++ b/drivers/pwm/pwm-atmel.c
@@ -24,7 +24,6 @@ 
 #include <linux/err.h>
 #include <linux/io.h>
 #include <linux/module.h>
-#include <linux/mutex.h>
 #include <linux/of.h>
 #include <linux/of_device.h>
 #include <linux/platform_device.h>