diff mbox series

[05/47] pwm: stm32-lp: Don't modify HW state in .remove() callback

Message ID 20210707162835.1772882-6-u.kleine-koenig@pengutronix.de
State Accepted
Headers show
Series pwm: Make pwmchip_remove return void | expand

Commit Message

Uwe Kleine-König July 7, 2021, 4:27 p.m. UTC
A consumer is expected to disable a PWM before calling pwm_put(). And if
they didn't there is hopefully a good reason (or the consumer needs
fixing). Also if disabling an enabled PWM was the right thing to do,
this should better be done in the framework instead of in each low level

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
 drivers/pwm/pwm-stm32-lp.c | 2 --
 1 file changed, 2 deletions(-)
diff mbox series


diff --git a/drivers/pwm/pwm-stm32-lp.c b/drivers/pwm/pwm-stm32-lp.c
index 93dd03618465..e4a10aac354d 100644
--- a/drivers/pwm/pwm-stm32-lp.c
+++ b/drivers/pwm/pwm-stm32-lp.c
@@ -222,8 +222,6 @@  static int stm32_pwm_lp_remove(struct platform_device *pdev)
 	struct stm32_pwm_lp *priv = platform_get_drvdata(pdev);
-	pwm_disable(&priv->chip.pwms[0]);
 	return pwmchip_remove(&priv->chip);