diff mbox series

[1/2] pwm: imx1: Don't disable clocks at device remove time

Message ID 20210525063528.947017-1-u.kleine-koenig@pengutronix.de
State New
Headers show
Series [1/2] pwm: imx1: Don't disable clocks at device remove time | expand

Commit Message

Uwe Kleine-König May 25, 2021, 6:35 a.m. UTC
The .remove() callback disables clocks that were not enabled in
.probe(). So just probing and then unbinding the driver results in a clk
enable imbalance.

So just drop the call to disable the clocks. (Which BTW was also in the
wrong order because the call makes the PWM unfunctional and so should
have come only after pwmchip_remove()).

Fixes: 9f4c8f9607c3 ("pwm: imx: Add ipg clock operation")
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
 drivers/pwm/pwm-imx1.c | 2 --
 1 file changed, 2 deletions(-)

base-commit: 6efb943b8616ec53a5e444193dccf1af9ad627b5
prerequisite-patch-id: fa39cd0c852d109ed957dc44dca5bdcf5dff0685
diff mbox series


diff --git a/drivers/pwm/pwm-imx1.c b/drivers/pwm/pwm-imx1.c
index c957b365448e..e73858a8e464 100644
--- a/drivers/pwm/pwm-imx1.c
+++ b/drivers/pwm/pwm-imx1.c
@@ -168,8 +168,6 @@  static int pwm_imx1_remove(struct platform_device *pdev)
 	struct pwm_imx1_chip *imx = platform_get_drvdata(pdev);
-	pwm_imx1_clk_disable_unprepare(&imx->chip);
 	return pwmchip_remove(&imx->chip);