diff mbox series

[v2] pwm: meson: Simplify using devm_pwmchip_add

Message ID 20210510190924.990912-1-u.kleine-koenig@pengutronix.de
State New
Headers show
Series [v2] pwm: meson: Simplify using devm_pwmchip_add | expand

Commit Message

Uwe Kleine-König May 10, 2021, 7:09 p.m. UTC
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---

Hi Romain,

On Mon, May 10, 2021 at 08:42:07PM +0200, Romain Perier wrote:
> The "struct device *" as first argument is missing, nop ?

Damn, you're right. Here comes v2 after enabling the meson driver in my
test .config :-\

Best regards
Uwe


 drivers/pwm/pwm-meson.c | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)


base-commit: 6efb943b8616ec53a5e444193dccf1af9ad627b5
prerequisite-patch-id: fa39cd0c852d109ed957dc44dca5bdcf5dff0685

Comments

Martin Blumenstingl May 16, 2021, 5 p.m. UTC | #1
Hi Uwe,

On Mon, May 10, 2021 at 9:09 PM Uwe Kleine-König
<u.kleine-koenig@pengutronix.de> wrote:
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>

[...]
>  drivers/pwm/pwm-meson.c | 12 +-----------
>  1 file changed, 1 insertion(+), 11 deletions(-)
I'd say your patch achieves it's goal by re-using more code instead of
duplicating it across drivers
Thanks for working on this!


Best regards,
Martin
diff mbox series

Patch

diff --git a/drivers/pwm/pwm-meson.c b/drivers/pwm/pwm-meson.c
index 9eb060613cb4..fc5a0acb7eb9 100644
--- a/drivers/pwm/pwm-meson.c
+++ b/drivers/pwm/pwm-meson.c
@@ -560,31 +560,21 @@  static int meson_pwm_probe(struct platform_device *pdev)
 	if (err < 0)
 		return err;
 
-	err = pwmchip_add(&meson->chip);
+	err = devm_pwmchip_add(&pdev->dev, &meson->chip);
 	if (err < 0) {
 		dev_err(&pdev->dev, "failed to register PWM chip: %d\n", err);
 		return err;
 	}
 
-	platform_set_drvdata(pdev, meson);
-
 	return 0;
 }
 
-static int meson_pwm_remove(struct platform_device *pdev)
-{
-	struct meson_pwm *meson = platform_get_drvdata(pdev);
-
-	return pwmchip_remove(&meson->chip);
-}
-
 static struct platform_driver meson_pwm_driver = {
 	.driver = {
 		.name = "meson-pwm",
 		.of_match_table = meson_pwm_matches,
 	},
 	.probe = meson_pwm_probe,
-	.remove = meson_pwm_remove,
 };
 module_platform_driver(meson_pwm_driver);