| Message ID | 20210409090819.24805-1-nsaenz@kernel.org |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | pwm: raspberrypi-poe: Fix mailbox message initialization | expand |
On Fri, Apr 09, 2021 at 11:08:19AM +0200, Nicolas Saenz Julienne wrote: > For testing purposes this driver might be built on big-endian > architectures. So make sure we take that into account when populating > structures that are to be passed to RPi4's mailbox. > > Reported-by: kernel test robot <lkp@intel.com> > Fixes: 79caa362eab6 ("pwm: Add Raspberry Pi Firmware based PWM bus") > Signed-off-by: Nicolas Saenz Julienne <nsaenz@kernel.org> > --- > > @arndb: This was just meged into the arm-soc tree some days ago. Should I > prepare a second PR once it's been reviewed? > > drivers/pwm/pwm-raspberrypi-poe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Thierry Reding <thierry.reding@gmail.com>
On Fri, Apr 9, 2021 at 11:08 AM Nicolas Saenz Julienne <nsaenz@kernel.org> wrote: > > For testing purposes this driver might be built on big-endian > architectures. So make sure we take that into account when populating > structures that are to be passed to RPi4's mailbox. > > Reported-by: kernel test robot <lkp@intel.com> > Fixes: 79caa362eab6 ("pwm: Add Raspberry Pi Firmware based PWM bus") > Signed-off-by: Nicolas Saenz Julienne <nsaenz@kernel.org> > --- > > @arndb: This was just meged into the arm-soc tree some days ago. Should I > prepare a second PR once it's been reviewed? Yes, that would be good. If you have no other driver patches that I should pick up, just forward the patch (with the Ack) to soc@kernel.org and I can just apply it. Arnd
diff --git a/drivers/pwm/pwm-raspberrypi-poe.c b/drivers/pwm/pwm-raspberrypi-poe.c index 043fc32e8be8..78423e66f4fc 100644 --- a/drivers/pwm/pwm-raspberrypi-poe.c +++ b/drivers/pwm/pwm-raspberrypi-poe.c @@ -66,7 +66,7 @@ static int raspberrypi_pwm_get_property(struct rpi_firmware *firmware, u32 reg, u32 *val) { struct raspberrypi_pwm_prop msg = { - .reg = reg + .reg = cpu_to_le32(reg), }; int ret;
For testing purposes this driver might be built on big-endian architectures. So make sure we take that into account when populating structures that are to be passed to RPi4's mailbox. Reported-by: kernel test robot <lkp@intel.com> Fixes: 79caa362eab6 ("pwm: Add Raspberry Pi Firmware based PWM bus") Signed-off-by: Nicolas Saenz Julienne <nsaenz@kernel.org> --- @arndb: This was just meged into the arm-soc tree some days ago. Should I prepare a second PR once it's been reviewed? drivers/pwm/pwm-raspberrypi-poe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)