| Message ID | 20210312085916.386422-1-u.kleine-koenig@pengutronix.de |
|---|---|
| State | Accepted |
| Headers | show |
| Series | pwm: sprd: Refuse requests with unsupported polarity | expand |
On Fri, 12 Mar 2021 at 16:59, Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote: > > The driver only supports normal polarity and so should refuse requests > for inversed polarity. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > --- > drivers/pwm/pwm-sprd.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/pwm/pwm-sprd.c b/drivers/pwm/pwm-sprd.c > index 5123d948efd6..bd6087cfb0b2 100644 > --- a/drivers/pwm/pwm-sprd.c > +++ b/drivers/pwm/pwm-sprd.c > @@ -164,6 +164,9 @@ static int sprd_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm, > struct pwm_state *cstate = &pwm->state; > int ret; > > + if (state->polarity != PWM_POLARITY_NORMAL) > + return -EINVAL; Should we use EOPNOTSUPP instead? > + > if (state->enabled) { > if (!cstate->enabled) { > /* > > base-commit: a38fd8748464831584a19438cbb3082b5a2dab15 > -- > 2.30.1 >
On Fri, Mar 12, 2021 at 06:40:52PM +0800, Chunyan Zhang wrote: > On Fri, 12 Mar 2021 at 16:59, Uwe Kleine-König > <u.kleine-koenig@pengutronix.de> wrote: > > > > The driver only supports normal polarity and so should refuse requests > > for inversed polarity. > > > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > > --- > > drivers/pwm/pwm-sprd.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/drivers/pwm/pwm-sprd.c b/drivers/pwm/pwm-sprd.c > > index 5123d948efd6..bd6087cfb0b2 100644 > > --- a/drivers/pwm/pwm-sprd.c > > +++ b/drivers/pwm/pwm-sprd.c > > @@ -164,6 +164,9 @@ static int sprd_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm, > > struct pwm_state *cstate = &pwm->state; > > int ret; > > > > + if (state->polarity != PWM_POLARITY_NORMAL) > > + return -EINVAL; > > Should we use EOPNOTSUPP instead? No, see 2b1c1a5d5148 ("pwm: Use -EINVAL for unsupported polarity"). Best regards Uwe
On Fri, 12 Mar 2021 at 21:28, Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote: > > On Fri, Mar 12, 2021 at 06:40:52PM +0800, Chunyan Zhang wrote: > > On Fri, 12 Mar 2021 at 16:59, Uwe Kleine-König > > <u.kleine-koenig@pengutronix.de> wrote: > > > > > > The driver only supports normal polarity and so should refuse requests > > > for inversed polarity. > > > > > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > > > --- > > > drivers/pwm/pwm-sprd.c | 3 +++ > > > 1 file changed, 3 insertions(+) > > > > > > diff --git a/drivers/pwm/pwm-sprd.c b/drivers/pwm/pwm-sprd.c > > > index 5123d948efd6..bd6087cfb0b2 100644 > > > --- a/drivers/pwm/pwm-sprd.c > > > +++ b/drivers/pwm/pwm-sprd.c > > > @@ -164,6 +164,9 @@ static int sprd_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm, > > > struct pwm_state *cstate = &pwm->state; > > > int ret; > > > > > > + if (state->polarity != PWM_POLARITY_NORMAL) > > > + return -EINVAL; > > > > Should we use EOPNOTSUPP instead? > > No, see 2b1c1a5d5148 ("pwm: Use -EINVAL for unsupported polarity"). Ok, and thanks for fixing this. Acked-by: Chunyan Zhang <zhang.lyra@gmail.com> > > Best regards > Uwe > > -- > Pengutronix e.K. | Uwe Kleine-König | > Industrial Linux Solutions | https://www.pengutronix.de/ |
On Fri, Mar 12, 2021 at 09:59:16AM +0100, Uwe Kleine-König wrote: > The driver only supports normal polarity and so should refuse requests > for inversed polarity. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > --- > drivers/pwm/pwm-sprd.c | 3 +++ > 1 file changed, 3 insertions(+) Applied, thanks. Thierry
diff --git a/drivers/pwm/pwm-sprd.c b/drivers/pwm/pwm-sprd.c index 5123d948efd6..bd6087cfb0b2 100644 --- a/drivers/pwm/pwm-sprd.c +++ b/drivers/pwm/pwm-sprd.c @@ -164,6 +164,9 @@ static int sprd_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm, struct pwm_state *cstate = &pwm->state; int ret; + if (state->polarity != PWM_POLARITY_NORMAL) + return -EINVAL; + if (state->enabled) { if (!cstate->enabled) { /*
The driver only supports normal polarity and so should refuse requests for inversed polarity. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- drivers/pwm/pwm-sprd.c | 3 +++ 1 file changed, 3 insertions(+) base-commit: a38fd8748464831584a19438cbb3082b5a2dab15