From patchwork Wed Nov 18 14:51:12 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Soham Biswas X-Patchwork-Id: 1402284 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-pwm-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=R7abOssR; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4Cbm405gH6z9sRR for ; Thu, 19 Nov 2020 01:52:00 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727060AbgKROvk (ORCPT ); Wed, 18 Nov 2020 09:51:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42412 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726293AbgKROvj (ORCPT ); Wed, 18 Nov 2020 09:51:39 -0500 Received: from mail-pj1-x1044.google.com (mail-pj1-x1044.google.com [IPv6:2607:f8b0:4864:20::1044]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B7B78C0613D4; Wed, 18 Nov 2020 06:51:39 -0800 (PST) Received: by mail-pj1-x1044.google.com with SMTP id r6so1166525pjd.1; Wed, 18 Nov 2020 06:51:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=t5uedKWjYZhLmHBmo17IOneaP07yxkMVZsdlyTCdn0E=; b=R7abOssRqpTjRzQyxi7nfkaDhzRBoYCcxS+OwUNBEAMwiDHrX0OuR+e7tELtLqpUlp yNqahH6acfS/dXNcQHZfmA7bXThSQ173ZQFDHKwVzbH4RHQUPCmenzsgKe0cH4rPq0TK vK6FUPCgAejh7nka2fPDXQgWlVbJNyA6wWpCmbfR0kNZnAGw2Y8iPlpurHdNhFhv3uvH DVPpY8ChAC+T920e5825Vufnn5QFYjsDL8L5YnxQ/hx63oO5/przV7AvXJJMUHqpZLEO xImUKRDBku6mtfQLlj9P/BMjtBtS6mU6uQBjieNN1nlqqYCwqZgb+kTh9YTurBIAM1Zu rLkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=t5uedKWjYZhLmHBmo17IOneaP07yxkMVZsdlyTCdn0E=; b=RSn4NqoVh/ZPL7LHAW1H5VbIBV/Ka/gBZ/sMXLIuWeQWkoZOr6LNWSjrJajgEs47d7 10OzbSibnsyZm5ERNR6branvgvbFQpoi2/3UqJsF/CVfNyUCd1+DajJjruPnNy3LHIiE P7a/6TUOEWJR2Kb+sVfz3IYekReSZmoAdHSN+dMEFHyD4OCEQR72hog20vFm7N9vLAuB 2AA2+xfPoXQi6rDR3BpTw1HXI2nD+EnfgABG5GRXrtlSkUBGAOQSycpoX25M4QLdK+n+ sAssh1tUxSPZGS9z+kHOztBfY9oa1y9RgGTexPAg+8v7Ee+u6SKdctswg2uTV3LWHoAp FrBg== X-Gm-Message-State: AOAM530XfmNqBJNzZwNAAbf0wqZF5qZxkf9a1VoRjlwMn+OtYRut/xOT ni7gW035/IVS581Sy5VvlDA= X-Google-Smtp-Source: ABdhPJw5AyAwbbGTMJggrxcgt8VwHoS3e3plTaNJUt40AlGbeUhTXhp+mxYlguDNNpForIoO4SKrTg== X-Received: by 2002:a17:902:9307:b029:d9:d097:fd6c with SMTP id bc7-20020a1709029307b02900d9d097fd6cmr1132363plb.10.1605711099128; Wed, 18 Nov 2020 06:51:39 -0800 (PST) Received: from manjaro.domain.name ([202.142.93.91]) by smtp.gmail.com with ESMTPSA id t10sm7954297pfq.110.2020.11.18.06.51.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Nov 2020 06:51:38 -0800 (PST) From: Soham Biswas To: thierry.reding@gmail.com Cc: lee.jones@linaro.org, u.kleine-koenig@pengutronix.de, linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org, Soham Biswas Subject: [PATCH v3] pwm: core: Use octal permission Date: Wed, 18 Nov 2020 20:21:12 +0530 Message-Id: <20201118145112.21250-1-sohambiswas41@gmail.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201117175452.26914-1-sohambiswas41@gmail.com> References: <20201117175452.26914-1-sohambiswas41@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-pwm@vger.kernel.org Permission bits are easier readable in octal than with using the symbolic names. Fixes the following warning generated by checkpatch: drivers/pwm/core.c:1341: WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. +debugfs_create_file("pwm", S_IFREG | S_IRUGO, NULL, NULL, &pwm_debugfs_fops); Signed-off-by: Soham Biswas Acked-by: Uwe Kleine-König --- drivers/pwm/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c index 1f16f5365d3c..a8eff4b3ee36 100644 --- a/drivers/pwm/core.c +++ b/drivers/pwm/core.c @@ -1338,7 +1338,7 @@ DEFINE_SEQ_ATTRIBUTE(pwm_debugfs); static int __init pwm_debugfs_init(void) { - debugfs_create_file("pwm", S_IFREG | S_IRUGO, NULL, NULL, + debugfs_create_file("pwm", S_IFREG | 0444, NULL, NULL, &pwm_debugfs_fops); return 0;