| Message ID | 20200602123241.3363904-1-thierry.reding@gmail.com |
|---|---|
| State | Accepted |
| Commit | d741cb045cb5552d9e636e7e447f237d3b1667ad |
| Headers | show |
| Series | MAINTAINERS: Add Lee Jones as reviewer for the PWM subsystem | expand |
On Tue, 02 Jun 2020, Thierry Reding wrote: > Lee has kindly offered his help in sharing the patch review workload for > the PWM subsystem. If this works out well between Lee, Uwe and myself it > may be a good idea to maintain the subsystem as a group. > > Signed-off-by: Thierry Reding <thierry.reding@gmail.com> > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) Works for me. Acked-by: Lee Jones <lee.jones@linaro.org>
On Tue, Jun 02, 2020 at 02:32:41PM +0200, Thierry Reding wrote: > Lee has kindly offered his help in sharing the patch review workload for > the PWM subsystem. If this works out well between Lee, Uwe and myself it > may be a good idea to maintain the subsystem as a group. > > Signed-off-by: Thierry Reding <thierry.reding@gmail.com> > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index e64e5db31497..b8889bed5d1e 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -13736,6 +13736,7 @@ F: drivers/media/rc/pwm-ir-tx.c > PWM SUBSYSTEM > M: Thierry Reding <thierry.reding@gmail.com> > R: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > +M: Lee Jones <lee.jones@linaro.org> I'm bit surprised that Lee got M: which I have a R:. The commit log talks about reviewer not maintainer. While I'm not sure that there is a practical difference it makes me a bit sad. Best regards Uwe
On Wed, Jun 03, 2020 at 02:37:18PM +0200, Uwe Kleine-König wrote: > On Tue, Jun 02, 2020 at 02:32:41PM +0200, Thierry Reding wrote: > > Lee has kindly offered his help in sharing the patch review workload for > > the PWM subsystem. If this works out well between Lee, Uwe and myself it > > may be a good idea to maintain the subsystem as a group. > > > > Signed-off-by: Thierry Reding <thierry.reding@gmail.com> > > --- > > MAINTAINERS | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index e64e5db31497..b8889bed5d1e 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -13736,6 +13736,7 @@ F: drivers/media/rc/pwm-ir-tx.c > > PWM SUBSYSTEM > > M: Thierry Reding <thierry.reding@gmail.com> > > R: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > > +M: Lee Jones <lee.jones@linaro.org> > > I'm bit surprised that Lee got M: which I have a R:. The commit log > talks about reviewer not maintainer. > > While I'm not sure that there is a practical difference it makes me a > bit sad. That was not the intention. According to the notes at the top of the MAINTAINERS file, recipients on M: lines will be added in the To: header, while R: lines will be added in the Cc: header. That's really the only difference. In practical terms this may be helpful for filtering where email where you are on the To: line can be prioritized over those where you are on the Cc: line. Thierry
On Wed, 03 Jun 2020, Thierry Reding wrote: > On Wed, Jun 03, 2020 at 02:37:18PM +0200, Uwe Kleine-König wrote: > > On Tue, Jun 02, 2020 at 02:32:41PM +0200, Thierry Reding wrote: > > > Lee has kindly offered his help in sharing the patch review workload for > > > the PWM subsystem. If this works out well between Lee, Uwe and myself it > > > may be a good idea to maintain the subsystem as a group. > > > > > > Signed-off-by: Thierry Reding <thierry.reding@gmail.com> > > > --- > > > MAINTAINERS | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > > index e64e5db31497..b8889bed5d1e 100644 > > > --- a/MAINTAINERS > > > +++ b/MAINTAINERS > > > @@ -13736,6 +13736,7 @@ F: drivers/media/rc/pwm-ir-tx.c > > > PWM SUBSYSTEM > > > M: Thierry Reding <thierry.reding@gmail.com> > > > R: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > > > +M: Lee Jones <lee.jones@linaro.org> > > > > I'm bit surprised that Lee got M: which I have a R:. The commit log > > talks about reviewer not maintainer. > > > > While I'm not sure that there is a practical difference it makes me a > > bit sad. > > That was not the intention. According to the notes at the top of the > MAINTAINERS file, recipients on M: lines will be added in the To: > header, while R: lines will be added in the Cc: header. That's really > the only difference. > > In practical terms this may be helpful for filtering where email where > you are on the To: line can be prioritized over those where you are on > the Cc: line. Exactly right. It's a common misconception that M: means 'Maintainer'. It doesn't. M: simply means "Mail-to". It has nothing to do with maintainership levels/hierarchy and everything to do with mail filtering. Nothing to be sad about.
On Wed, 03 Jun 2020, Lee Jones wrote: > On Wed, 03 Jun 2020, Thierry Reding wrote: > > > On Wed, Jun 03, 2020 at 02:37:18PM +0200, Uwe Kleine-König wrote: > > > On Tue, Jun 02, 2020 at 02:32:41PM +0200, Thierry Reding wrote: > > > > Lee has kindly offered his help in sharing the patch review workload for > > > > the PWM subsystem. If this works out well between Lee, Uwe and myself it > > > > may be a good idea to maintain the subsystem as a group. > > > > > > > > Signed-off-by: Thierry Reding <thierry.reding@gmail.com> > > > > --- > > > > MAINTAINERS | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > > > index e64e5db31497..b8889bed5d1e 100644 > > > > --- a/MAINTAINERS > > > > +++ b/MAINTAINERS > > > > @@ -13736,6 +13736,7 @@ F: drivers/media/rc/pwm-ir-tx.c > > > > PWM SUBSYSTEM > > > > M: Thierry Reding <thierry.reding@gmail.com> > > > > R: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > > > > +M: Lee Jones <lee.jones@linaro.org> > > > > > > I'm bit surprised that Lee got M: which I have a R:. The commit log > > > talks about reviewer not maintainer. > > > > > > While I'm not sure that there is a practical difference it makes me a > > > bit sad. > > > > That was not the intention. According to the notes at the top of the > > MAINTAINERS file, recipients on M: lines will be added in the To: > > header, while R: lines will be added in the Cc: header. That's really > > the only difference. > > > > In practical terms this may be helpful for filtering where email where > > you are on the To: line can be prioritized over those where you are on > > the Cc: line. > > Exactly right. > > It's a common misconception that M: means 'Maintainer'. It doesn't. > M: simply means "Mail-to". It has nothing to do with maintainership > levels/hierarchy and everything to do with mail filtering. Although maybe someone should tell scripts/get_maintainer.pl that!
diff --git a/MAINTAINERS b/MAINTAINERS index e64e5db31497..b8889bed5d1e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -13736,6 +13736,7 @@ F: drivers/media/rc/pwm-ir-tx.c PWM SUBSYSTEM M: Thierry Reding <thierry.reding@gmail.com> R: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> +M: Lee Jones <lee.jones@linaro.org> L: linux-pwm@vger.kernel.org S: Maintained Q: https://patchwork.ozlabs.org/project/linux-pwm/list/
Lee has kindly offered his help in sharing the patch review workload for the PWM subsystem. If this works out well between Lee, Uwe and myself it may be a good idea to maintain the subsystem as a group. Signed-off-by: Thierry Reding <thierry.reding@gmail.com> --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+)