| Message ID | 1624959329-71785-1-git-send-email-zou_wei@huawei.com |
|---|---|
| State | Rejected |
| Headers | show |
| Series | [-next,v2] pwm: img: Call pm_runtime_put_autosuspend() in pm_runtime_get_sync() failed case | expand |
diff --git a/drivers/pwm/pwm-img.c b/drivers/pwm/pwm-img.c index cc37054..d58ee47 100644 --- a/drivers/pwm/pwm-img.c +++ b/drivers/pwm/pwm-img.c @@ -157,8 +157,10 @@ static int img_pwm_enable(struct pwm_chip *chip, struct pwm_device *pwm) int ret; ret = pm_runtime_get_sync(chip->dev); - if (ret < 0) + if (ret < 0) { + pm_runtime_put_autosuspend(chip->dev); return ret; + } val = img_pwm_readl(pwm_chip, PWM_CTRL_CFG); val |= BIT(pwm->hwpwm);
pm_runtime_get_sync will increment pm usage counter even it failed. Forgetting to putting operation will result in reference leak here. Fix it by call pm_runtime_put_autosuspend() in pm_runtime_get_sync() to keep usage counter balanced. v1-->v2: call pm_runtime_put_autosuspend() to keep consistency Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Zou Wei <zou_wei@huawei.com> --- drivers/pwm/pwm-img.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)