From patchwork Tue Aug 19 22:07:50 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Ga=C3=ABl_PORTAY?= X-Patchwork-Id: 381505 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id A0C46140097 for ; Wed, 20 Aug 2014 08:08:43 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751923AbaHSWIT (ORCPT ); Tue, 19 Aug 2014 18:08:19 -0400 Received: from mail-wg0-f49.google.com ([74.125.82.49]:51596 "EHLO mail-wg0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751208AbaHSWIP (ORCPT ); Tue, 19 Aug 2014 18:08:15 -0400 Received: by mail-wg0-f49.google.com with SMTP id k14so7143270wgh.32 for ; Tue, 19 Aug 2014 15:08:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=biuYRmlDgHe3YmPwWVWv+CW838YSQ4sw6EiF0NMBgcs=; b=VY5mDjlud9/yyzeb7xi4qTWKhmv6JLBt3QqNvX3v3BVThp5gdKj3uBQeQKApqOTZit smkCRUEo3zysBP4UxFh7K+WyijoTztTXnk0jjUq0oBUjOg2YuhECuFXMrqFPEFhpyQQ3 zica+hmpwyvae0Z3ADfyoJHmC6AZwStktr1Iqg6X+HCfFthTX7e76+jE9a8qVdN4Psm/ KoOjGWMCfEQWzXoJdlBObwxI2kT0SYWApUEKnGFdCxGJbEKZHgOOyxG17Iq7SMg1tgOv tMxiplHlhnU4SuBXFblAj/WiwAzCS+IbAUKZp7pHXVIZn+uM4ODVlJFIfCzcGDOsZKCm 60ZQ== X-Received: by 10.180.107.100 with SMTP id hb4mr1010233wib.59.1408486094239; Tue, 19 Aug 2014 15:08:14 -0700 (PDT) Received: from localhost.localdomain (19-157-190-109.dsl.ovh.fr. [109.190.157.19]) by mx.google.com with ESMTPSA id kw1sm53518009wjb.19.2014.08.19.15.08.12 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Aug 2014 15:08:13 -0700 (PDT) From: =?UTF-8?q?Ga=C3=ABl=20PORTAY?= To: Arnd Bergmann , Daniel Lezcano , Greg Kroah-Hartman , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org, Nicolas Ferre , Thierry Reding , Thomas Gleixner Cc: Boris Brezillon , Alexandre Belloni , Jean-Christophe PLAGNIOL-VILLARD , =?utf-8?q?Ga=C3=ABl=20PORTAY?= Subject: [PATCH 1/3] ARM: at91/tclib: prefer using of devm_* functions Date: Wed, 20 Aug 2014 00:07:50 +0200 Message-Id: <1408486072-19268-2-git-send-email-gael.portay@gmail.com> X-Mailer: git-send-email 1.9.3 In-Reply-To: <1408486072-19268-1-git-send-email-gael.portay@gmail.com> References: <1408486072-19268-1-git-send-email-gael.portay@gmail.com> MIME-Version: 1.0 Sender: linux-pwm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pwm@vger.kernel.org Signed-off-by: Gaël PORTAY Acked-by: Boris Brezillon --- drivers/misc/atmel_tclib.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/misc/atmel_tclib.c b/drivers/misc/atmel_tclib.c index c8d8e38..b514a2d 100644 --- a/drivers/misc/atmel_tclib.c +++ b/drivers/misc/atmel_tclib.c @@ -150,17 +150,15 @@ static int __init tc_probe(struct platform_device *pdev) if (irq < 0) return -EINVAL; - tc = kzalloc(sizeof(struct atmel_tc), GFP_KERNEL); + tc = devm_kzalloc(&pdev->dev, sizeof(struct atmel_tc), GFP_KERNEL); if (!tc) return -ENOMEM; tc->pdev = pdev; - clk = clk_get(&pdev->dev, "t0_clk"); - if (IS_ERR(clk)) { - kfree(tc); - return -EINVAL; - } + clk = devm_clk_get(&pdev->dev, "t0_clk"); + if (IS_ERR(clk)) + return PTR_ERR(clk); /* Now take SoC information if available */ if (pdev->dev.of_node) { @@ -171,10 +169,10 @@ static int __init tc_probe(struct platform_device *pdev) } tc->clk[0] = clk; - tc->clk[1] = clk_get(&pdev->dev, "t1_clk"); + tc->clk[1] = devm_clk_get(&pdev->dev, "t1_clk"); if (IS_ERR(tc->clk[1])) tc->clk[1] = clk; - tc->clk[2] = clk_get(&pdev->dev, "t2_clk"); + tc->clk[2] = devm_clk_get(&pdev->dev, "t2_clk"); if (IS_ERR(tc->clk[2])) tc->clk[2] = clk;