| Message ID | 1400717120.23867.1.camel@phoenix |
|---|---|
| State | Accepted |
| Headers | show |
> Subject: [PATCH] pwm: fsl-ftm: set pwm_chip can_sleep flag > > The implementation of .config(), .enable() and .disable() operations in this > driver may sleep, thus set pwm_chip can_sleep flag. > > Signed-off-by: Axel Lin <axel.lin@ingics.com> > --- Acked-by: Xiubo Li <Li.Xiubo@freescale.com> @Thierry, There are still 4 patches before this one, and I'd like to know the status of them: [PATCHv2 0/4] FTM PWM adds regmap and endianness support. Thanks, BRs Xiubo > drivers/pwm/pwm-fsl-ftm.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pwm/pwm-fsl-ftm.c b/drivers/pwm/pwm-fsl-ftm.c > index 420169e..a18bc8f 100644 > --- a/drivers/pwm/pwm-fsl-ftm.c > +++ b/drivers/pwm/pwm-fsl-ftm.c > @@ -454,6 +454,7 @@ static int fsl_pwm_probe(struct platform_device *pdev) > fpc->chip.of_pwm_n_cells = 3; > fpc->chip.base = -1; > fpc->chip.npwm = 8; > + fpc->chip.can_sleep = true; > > ret = pwmchip_add(&fpc->chip); > if (ret < 0) { > -- > 1.8.3.2 > >
On Thu, May 22, 2014 at 08:05:20AM +0800, Axel Lin wrote: > The implementation of .config(), .enable() and .disable() operations in this > driver may sleep, thus set pwm_chip can_sleep flag. > > Signed-off-by: Axel Lin <axel.lin@ingics.com> > --- > drivers/pwm/pwm-fsl-ftm.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pwm/pwm-fsl-ftm.c b/drivers/pwm/pwm-fsl-ftm.c > index 420169e..a18bc8f 100644 > --- a/drivers/pwm/pwm-fsl-ftm.c > +++ b/drivers/pwm/pwm-fsl-ftm.c > @@ -454,6 +454,7 @@ static int fsl_pwm_probe(struct platform_device *pdev) > fpc->chip.of_pwm_n_cells = 3; > fpc->chip.base = -1; > fpc->chip.npwm = 8; > + fpc->chip.can_sleep = true; > > ret = pwmchip_add(&fpc->chip); > if (ret < 0) { Applied, thanks. Thierry
On Fri, May 23, 2014 at 01:02:21AM +0000, Li.Xiubo@freescale.com wrote: > > Subject: [PATCH] pwm: fsl-ftm: set pwm_chip can_sleep flag > > > > The implementation of .config(), .enable() and .disable() operations in this > > driver may sleep, thus set pwm_chip can_sleep flag. > > > > Signed-off-by: Axel Lin <axel.lin@ingics.com> > > --- > > Acked-by: Xiubo Li <Li.Xiubo@freescale.com> > > @Thierry, > > There are still 4 patches before this one, and I'd like to know the status of > them: > [PATCHv2 0/4] FTM PWM adds regmap and endianness support. I was holding off on those because I thought I had seen some discussion about how to represent endianness support in DT and I'm not aware that there were any conclusions yet. Thierry
> Subject: Re: [PATCH] pwm: fsl-ftm: set pwm_chip can_sleep flag > > On Fri, May 23, 2014 at 01:02:21AM +0000, Li.Xiubo@freescale.com wrote: > > > Subject: [PATCH] pwm: fsl-ftm: set pwm_chip can_sleep flag > > > > > > The implementation of .config(), .enable() and .disable() operations in > this > > > driver may sleep, thus set pwm_chip can_sleep flag. > > > > > > Signed-off-by: Axel Lin <axel.lin@ingics.com> > > > --- > > > > Acked-by: Xiubo Li <Li.Xiubo@freescale.com> > > > > @Thierry, > > > > There are still 4 patches before this one, and I'd like to know the status > of > > them: > > [PATCHv2 0/4] FTM PWM adds regmap and endianness support. > > I was holding off on those because I thought I had seen some discussion > about how to represent endianness support in DT and I'm not aware that > there were any conclusions yet. > pwm: ftm-pwm: Clean up the code. pwm: ftm-pwm: Convert to direct regmap API usage. Well, how about the above two patches? And that discussion is mostly about The following ones: Documentation: Add 'big-endian' property for FTM PWM. pwm: ftm-pwm: Add big-endian support Thanks, BRs Xiubo > Thierry -- To unsubscribe from this list: send the line "unsubscribe linux-pwm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/pwm/pwm-fsl-ftm.c b/drivers/pwm/pwm-fsl-ftm.c index 420169e..a18bc8f 100644 --- a/drivers/pwm/pwm-fsl-ftm.c +++ b/drivers/pwm/pwm-fsl-ftm.c @@ -454,6 +454,7 @@ static int fsl_pwm_probe(struct platform_device *pdev) fpc->chip.of_pwm_n_cells = 3; fpc->chip.base = -1; fpc->chip.npwm = 8; + fpc->chip.can_sleep = true; ret = pwmchip_add(&fpc->chip); if (ret < 0) {
The implementation of .config(), .enable() and .disable() operations in this driver may sleep, thus set pwm_chip can_sleep flag. Signed-off-by: Axel Lin <axel.lin@ingics.com> --- drivers/pwm/pwm-fsl-ftm.c | 1 + 1 file changed, 1 insertion(+)