From patchwork Mon May 12 14:56:21 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajay Kumar X-Patchwork-Id: 348059 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 8EC49140081 for ; Tue, 13 May 2014 00:57:57 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758637AbaELO54 (ORCPT ); Mon, 12 May 2014 10:57:56 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:45362 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758634AbaELO5z (ORCPT ); Mon, 12 May 2014 10:57:55 -0400 Received: from epcpsbgr4.samsung.com (u144.gpu120.samsung.co.kr [203.254.230.144]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N5G003QLUWHPH70@mailout2.samsung.com>; Mon, 12 May 2014 23:57:53 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [172.20.52.125]) by epcpsbgr4.samsung.com (EPCPMTA) with SMTP id 82.4F.09952.171E0735; Mon, 12 May 2014 23:57:53 +0900 (KST) X-AuditID: cbfee690-b7fcd6d0000026e0-91-5370e171b86a Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id B7.FD.25708.171E0735; Mon, 12 May 2014 23:57:53 +0900 (KST) Received: from chromebld-server.sisodomain.com ([107.108.73.106]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0N5G008J6UVJUD00@mmp2.samsung.com>; Mon, 12 May 2014 23:57:53 +0900 (KST) From: Ajay Kumar To: linux-pwm@vger.kernel.org Cc: linux-samsung-soc@vger.kernel.org, ajaynumb@gmail.com, thierry.reding@gmail.com, tomasz.figa@gmail.com, abrestic@chromium.org, jg1.han@samsung.com, sachin.kamat@linaro.org, joshi@samsung.com, prashanth.g@samsung.com, Ajay Kumar Subject: [PATCH] pwm: samsung: do not set manual update bit in pwm_samsung_config Date: Mon, 12 May 2014 20:26:21 +0530 Message-id: <1399906581-29298-1-git-send-email-ajaykumar.rs@samsung.com> X-Mailer: git-send-email 1.7.9.5 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrALMWRmVeSWpSXmKPExsWyRsSkVrfwYUGwwdbLRhYr3/9ltDjw/iCL xYY3C5ktLi+8xGrxfdcXdou7d1cxWsw4v4/JYtXhDewWJ//0Mlr83DWPxWLVrj+MDtwesxsu snjsnHWX3ePOtT1sHn1bVjF6fN4kF8AaxWWTkpqTWZZapG+XwJUx/dA99oImzoqdX7qZGhhP s3cxcnJICJhIdEyfygxhi0lcuLeeDcQWEljKKPHyZjlMzcYv/SxdjFxA8emMEqdfr2GFcCYw SXQ/PgnWzSagLbFt+k2gKg4OEQFZiUmtfCA1zAIdTBIT35wBqxEWCJa41nYIrIZFQFViX4Mp SJhXwEPi59xeRpCwhICCxJxJNiCtEgKL2CU+v2oHO5RFQEDi22SIVgmg8ZsOQN0sKXFwxQ2W CYyCCxgZVjGKphYkFxQnpReZ6BUn5haX5qXrJefnbmIEhvbpf88m7GC8d8D6EGMy0LiJzFKi yfnA2MgriTc0NjOyMDUxNTYytzQjTVhJnFftUVKQkEB6YklqdmpqQWpRfFFpTmrxIUYmDk6p BkY24+07e36mZzg7PNC74mA1/4VFzxuRg8KyS42LrG96GWcoP3SZIhLRtVnzgcbvGZHb9EJL KySk7khyBuVxLlM9k71/c7DIJ5kbauuPH1OWrV5vM/vkJhOHyVkq367yiSbpf+BusOO5tMFp 7XX3iauMPv0t3LSoL0pR4a78L7aX5VKZ0xepr1diKc5INNRiLipOBABnrgi5gwIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrHIsWRmVeSWpSXmKPExsVy+t9jQd3ChwXBBvfPalmsfP+X0eLA+4Ms FhveLGS2uLzwEqvF911f2C3u3l3FaDHj/D4mi1WHN7BbnPzTy2jxc9c8FotVu/4wOnB7zG64 yOKxc9Zddo871/awefRtWcXo8XmTXABrVAOjTUZqYkpqkUJqXnJ+SmZeuq2Sd3C8c7ypmYGh rqGlhbmSQl5ibqqtkotPgK5bZg7QbUoKZYk5pUChgMTiYiV9O0wTQkPcdC1gGiN0fUOC4HqM DNBAwhrGjOmH7rEXNHFW7PzSzdTAeJq9i5GTQ0LARGLjl34WCFtM4sK99WxdjFwcQgLTGSVO v17DCuFMYJLofnySGaSKTUBbYtv0m0AdHBwiArISk1r5QGqYBTqYJCa+OQNWIywQLHGt7RBY DYuAqsS+BlOQMK+Ah8TPub2MIGEJAQWJOZNsJjByL2BkWMUomlqQXFCclJ5rpFecmFtcmpeu l5yfu4kRHDvPpHcwrmqwOMQowMGoxMP7gaEgWIg1say4MvcQowQHs5IIr9JtoBBvSmJlVWpR fnxRaU5q8SHGZKDdE5mlRJPzgXGdVxJvaGxibmpsamliYWJmSZqwkjjvwVbrQCGB9MSS1OzU 1ILUIpgtTBycUg2M8z/XfXzqrvbSqLL5gfaRh4u6XxW97fNd113Dyqi/NTF85rJA7racDINf jsm+yWU8JwRvP72rfUl4bni/y73CJYxJjWs9itMF6s8abt2wwG7huXnh+3Stvpw+0vBNUC+o xybvlcv2hpKHWysFO2bM2HhX5Tvzjru8WXtjb9gHqXqVafJtNEhQYinOSDTUYi4qTgQAAWpo 8+ECAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-pwm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pwm@vger.kernel.org pwm_samsung_config sets manual update bit via call to pwm_samsung_enable even when the channel is already running. This causes noticable flickers on display if we try to change the backlight value from 0 to MAX, continiously. So, we remove the call to pwm_samsung_enable from pwm_samsung_config to avoid the flicker and this change doesn't harm normal working since the pwm_bl core already takes care of calling pwm_samsung_enable whenever needed. Signed-off-by: Ajay Kumar Reviewed-by: Tomasz Figa --- drivers/pwm/pwm-samsung.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/pwm/pwm-samsung.c b/drivers/pwm/pwm-samsung.c index d66529a..ba6b650 100644 --- a/drivers/pwm/pwm-samsung.c +++ b/drivers/pwm/pwm-samsung.c @@ -335,9 +335,6 @@ static int pwm_samsung_config(struct pwm_chip *chip, struct pwm_device *pwm, writel(tcnt, our_chip->base + REG_TCNTB(pwm->hwpwm)); writel(tcmp, our_chip->base + REG_TCMPB(pwm->hwpwm)); - if (test_bit(PWMF_ENABLED, &pwm->flags)) - pwm_samsung_enable(chip, pwm); - chan->period_ns = period_ns; chan->tin_ns = tin_ns; chan->duty_ns = duty_ns;