From patchwork Tue Feb 4 12:57:14 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 316585 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 7AFBF2C0097 for ; Tue, 4 Feb 2014 23:57:28 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753733AbaBDM51 (ORCPT ); Tue, 4 Feb 2014 07:57:27 -0500 Received: from mail-we0-f176.google.com ([74.125.82.176]:57029 "EHLO mail-we0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753568AbaBDM50 (ORCPT ); Tue, 4 Feb 2014 07:57:26 -0500 Received: by mail-we0-f176.google.com with SMTP id q58so3987523wes.21 for ; Tue, 04 Feb 2014 04:57:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=9xw8Rs3J+eBX87L7eCxeA4oEf4W+1zNogUOCMzIKv2o=; b=ID/va3dipf4sboV/N24oG15KqZPRmRoTRy6OnkPxPhT0Y6TNNmQuEns/Y2KN+RV9b5 fBbG5JRBYvaE30vV862siS4KyJ/y63LzxStaztZZop5HjTG65M6UBso1lZQGJR+KFbw5 QkbXiHtXssVQactIOAnFpHh8D68HO50+uD/axjpb9te9b4q4I9sgPqBp5OP+tFqo7jiw hcLFVWuJ9yq1uznYmXWsGWBaaVm79XMnlJB1jqnNr35VqEgk/Ps86s0mTh+Sp0qNnwkG p9jV+uhMTISpLXayTrGSRNdlaw4yePDemts2I2SEawXrOLQKFNxEg4qygZ8Wr7RC2Ty+ ErTg== X-Gm-Message-State: ALoCoQl6r3Y9GVzh1UxqqJQoY4GBkzpao4Yg5gjl+LadHe8RNd1I9wPM/1jhqg6x8rMa3KcR7W3r X-Received: by 10.194.240.7 with SMTP id vw7mr190588wjc.75.1391518645454; Tue, 04 Feb 2014 04:57:25 -0800 (PST) Received: from localhost.localdomain ([85.235.11.236]) by mx.google.com with ESMTPSA id e5sm52441007wja.15.2014.02.04.04.57.23 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Feb 2014 04:57:24 -0800 (PST) From: Linus Walleij To: Jingoo Han , linux-kernel@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, Thierry Reding , linux-pwm@vger.kernel.org, Linus Walleij Subject: [PATCH] backlight: add PWM dependencies Date: Tue, 4 Feb 2014 13:57:14 +0100 Message-Id: <1391518634-6472-1-git-send-email-linus.walleij@linaro.org> X-Mailer: git-send-email 1.8.5.3 Sender: linux-pwm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pwm@vger.kernel.org In some compilations the LM3630A and LP855X backlight drivers fail like this: drivers/built-in.o: In function `lm3630a_pwm_ctrl': drivers/video/backlight/lm3630a_bl.c:168: undefined reference to `pwm_config' drivers/video/backlight/lm3630a_bl.c:172: undefined reference to `pwm_disable' drivers/video/backlight/lm3630a_bl.c:170: undefined reference to `pwm_enable' drivers/built-in.o: In function `lp855x_pwm_ctrl': drivers/video/backlight/lp855x_bl.c:249: undefined reference to `pwm_config' drivers/video/backlight/lp855x_bl.c:253: undefined reference to `pwm_disable' drivers/video/backlight/lp855x_bl.c:251: undefined reference to `pwm_enable' This is because both drivers depend on the PWM framework, so add this dependency to their Kconfig entries. Signed-off-by: Linus Walleij --- drivers/video/backlight/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig index 5a3eb2ecb525..0604c3348761 100644 --- a/drivers/video/backlight/Kconfig +++ b/drivers/video/backlight/Kconfig @@ -371,6 +371,7 @@ config BACKLIGHT_AAT2870 config BACKLIGHT_LM3630A tristate "Backlight Driver for LM3630A" depends on BACKLIGHT_CLASS_DEVICE && I2C + depends on PWM select REGMAP_I2C help This supports TI LM3630A Backlight Driver @@ -387,6 +388,7 @@ config BACKLIGHT_LM3639 config BACKLIGHT_LP855X tristate "Backlight driver for TI LP855X" depends on BACKLIGHT_CLASS_DEVICE && I2C + depends on PWM help This supports TI LP8550, LP8551, LP8552, LP8553, LP8555, LP8556 and LP8557 backlight driver.