mbox series

[v2,0/4] pwm: Simplify drivers with of_pwm_n_cells = 3

Message ID 20210424210718.2787498-1-u.kleine-koenig@pengutronix.de
Headers show
Series pwm: Simplify drivers with of_pwm_n_cells = 3 | expand

Message

Uwe Kleine-König April 24, 2021, 9:07 p.m. UTC
Hello,

this is v2 of the series sent earlier starting with Message-Id:
20210315111124.2475274-1-u.kleine-koenig@pengutronix.de. (See
https://lore.kernel.org/r/20210315111124.2475274-1-u.kleine-koenig@pengutronix.de).

The only change is using

	if (pc->of_pwm_n_cells >= 3) {
		if (args->args_count > 2 && args->args[2] & PWM_POLARITY_INVERTED)
			pwm->args.polarity = PWM_POLARITY_INVERSED;
	}

instead of

	if (pc->of_pwm_n_cells >= 3 && args->args_count > 2 &&
	    args->args[2] & PWM_POLARITY_INVERTED)
		pwm->args.polarity = PWM_POLARITY_INVERSED;

in the first patch which is semantically equivalent but Thierry likes it
better. This targets to go into next early after v5.13-rc1 so that it
gets proper testing before entering mainline.

Best regards
Uwe

Uwe Kleine-König (4):
  pwm: Make of_pwm_xlate_with_flags() work with #pwm-cells = <2>
  pwm: Drop of_pwm_simple_xlate() in favour of of_pwm_xlate_with_flags()
  pwm: Autodetect default value for of_pwm_n_cells from device tree
  pwm: Simplify all drivers with explicit of_pwm_n_cells = 3

 drivers/pwm/core.c             | 44 ++++++++++------------------------
 drivers/pwm/pwm-atmel-hlcdc.c  |  2 --
 drivers/pwm/pwm-atmel-tcb.c    |  2 --
 drivers/pwm/pwm-atmel.c        |  2 --
 drivers/pwm/pwm-bcm-iproc.c    |  2 --
 drivers/pwm/pwm-bcm-kona.c     |  2 --
 drivers/pwm/pwm-bcm2835.c      |  2 --
 drivers/pwm/pwm-berlin.c       |  2 --
 drivers/pwm/pwm-fsl-ftm.c      |  2 --
 drivers/pwm/pwm-hibvt.c        |  2 --
 drivers/pwm/pwm-imx-tpm.c      |  2 --
 drivers/pwm/pwm-imx27.c        |  3 ---
 drivers/pwm/pwm-jz4740.c       |  2 --
 drivers/pwm/pwm-lpc18xx-sct.c  |  2 --
 drivers/pwm/pwm-meson.c        |  2 --
 drivers/pwm/pwm-mxs.c          |  2 --
 drivers/pwm/pwm-omap-dmtimer.c |  2 --
 drivers/pwm/pwm-renesas-tpu.c  |  2 --
 drivers/pwm/pwm-rockchip.c     |  5 ----
 drivers/pwm/pwm-samsung.c      |  3 ---
 drivers/pwm/pwm-sifive.c       |  2 --
 drivers/pwm/pwm-stm32-lp.c     |  2 --
 drivers/pwm/pwm-stm32.c        |  2 --
 drivers/pwm/pwm-sun4i.c        |  2 --
 drivers/pwm/pwm-tiecap.c       |  2 --
 drivers/pwm/pwm-tiehrpwm.c     |  2 --
 drivers/pwm/pwm-vt8500.c       |  2 --
 27 files changed, 13 insertions(+), 88 deletions(-)


base-commit: 30d0031bd7cab931589e023149afc77739a4b175

Comments

Thierry Reding May 25, 2021, 4:24 p.m. UTC | #1
On Sat, Apr 24, 2021 at 11:07:14PM +0200, Uwe Kleine-König wrote:
> Hello,
> 
> this is v2 of the series sent earlier starting with Message-Id:
> 20210315111124.2475274-1-u.kleine-koenig@pengutronix.de. (See
> https://lore.kernel.org/r/20210315111124.2475274-1-u.kleine-koenig@pengutronix.de).
> 
> The only change is using
> 
> 	if (pc->of_pwm_n_cells >= 3) {
> 		if (args->args_count > 2 && args->args[2] & PWM_POLARITY_INVERTED)
> 			pwm->args.polarity = PWM_POLARITY_INVERSED;
> 	}
> 
> instead of
> 
> 	if (pc->of_pwm_n_cells >= 3 && args->args_count > 2 &&
> 	    args->args[2] & PWM_POLARITY_INVERTED)
> 		pwm->args.polarity = PWM_POLARITY_INVERSED;
> 
> in the first patch which is semantically equivalent but Thierry likes it
> better. This targets to go into next early after v5.13-rc1 so that it
> gets proper testing before entering mainline.
> 
> Best regards
> Uwe
> 
> Uwe Kleine-König (4):
>   pwm: Make of_pwm_xlate_with_flags() work with #pwm-cells = <2>
>   pwm: Drop of_pwm_simple_xlate() in favour of of_pwm_xlate_with_flags()
>   pwm: Autodetect default value for of_pwm_n_cells from device tree
>   pwm: Simplify all drivers with explicit of_pwm_n_cells = 3
> 
>  drivers/pwm/core.c             | 44 ++++++++++------------------------
>  drivers/pwm/pwm-atmel-hlcdc.c  |  2 --
>  drivers/pwm/pwm-atmel-tcb.c    |  2 --
>  drivers/pwm/pwm-atmel.c        |  2 --
>  drivers/pwm/pwm-bcm-iproc.c    |  2 --
>  drivers/pwm/pwm-bcm-kona.c     |  2 --
>  drivers/pwm/pwm-bcm2835.c      |  2 --
>  drivers/pwm/pwm-berlin.c       |  2 --
>  drivers/pwm/pwm-fsl-ftm.c      |  2 --
>  drivers/pwm/pwm-hibvt.c        |  2 --
>  drivers/pwm/pwm-imx-tpm.c      |  2 --
>  drivers/pwm/pwm-imx27.c        |  3 ---
>  drivers/pwm/pwm-jz4740.c       |  2 --
>  drivers/pwm/pwm-lpc18xx-sct.c  |  2 --
>  drivers/pwm/pwm-meson.c        |  2 --
>  drivers/pwm/pwm-mxs.c          |  2 --
>  drivers/pwm/pwm-omap-dmtimer.c |  2 --
>  drivers/pwm/pwm-renesas-tpu.c  |  2 --
>  drivers/pwm/pwm-rockchip.c     |  5 ----
>  drivers/pwm/pwm-samsung.c      |  3 ---
>  drivers/pwm/pwm-sifive.c       |  2 --
>  drivers/pwm/pwm-stm32-lp.c     |  2 --
>  drivers/pwm/pwm-stm32.c        |  2 --
>  drivers/pwm/pwm-sun4i.c        |  2 --
>  drivers/pwm/pwm-tiecap.c       |  2 --
>  drivers/pwm/pwm-tiehrpwm.c     |  2 --
>  drivers/pwm/pwm-vt8500.c       |  2 --
>  27 files changed, 13 insertions(+), 88 deletions(-)

Applied, thanks.

Thierry