diff mbox

[v3,12/13] pmcraid: Get rid of a redundant assignment

Message ID 8058dca6525ca29845019ea9922c37f3416c0c7a.1408335523.git.agordeev@redhat.com
State Not Applicable
Headers show

Commit Message

Alexander Gordeev Aug. 18, 2014, 6:01 a.m. UTC
Signed-off-by: Alexander Gordeev <agordeev@redhat.com>
Cc: Anil Ravindranath <anil_ravindranath@pmc-sierra.com>
Cc: linux-scsi@vger.kernel.org
Cc: linux-pci@vger.kernel.org
---
 drivers/scsi/pmcraid.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Tomas Henzl Aug. 21, 2014, 11:33 a.m. UTC | #1
On 08/18/2014 08:01 AM, Alexander Gordeev wrote:
> Signed-off-by: Alexander Gordeev <agordeev@redhat.com>
> Cc: Anil Ravindranath <anil_ravindranath@pmc-sierra.com>
> Cc: linux-scsi@vger.kernel.org
> Cc: linux-pci@vger.kernel.org
> ---
>  drivers/scsi/pmcraid.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/scsi/pmcraid.c b/drivers/scsi/pmcraid.c
> index 6f3275d..6e575ed 100644
> --- a/drivers/scsi/pmcraid.c
> +++ b/drivers/scsi/pmcraid.c
> @@ -4746,7 +4746,6 @@ pmcraid_isr_legacy:
>  	pinstance->hrrq_vector[0].drv_inst = pinstance;
>  	pinstance->hrrq_vector[0].vector = pdev->irq;
>  	pinstance->num_hrrq = 1;
> -	rc = 0;
>  
>  	rc = request_irq(pdev->irq, pmcraid_isr, IRQF_SHARED,
>  			 PMCRAID_DRIVER_NAME, &pinstance->hrrq_vector[0]);

Patch looks good to me.

Reviewed-by: Tomas Henzl <thenzl@redhat.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/scsi/pmcraid.c b/drivers/scsi/pmcraid.c
index 6f3275d..6e575ed 100644
--- a/drivers/scsi/pmcraid.c
+++ b/drivers/scsi/pmcraid.c
@@ -4746,7 +4746,6 @@  pmcraid_isr_legacy:
 	pinstance->hrrq_vector[0].drv_inst = pinstance;
 	pinstance->hrrq_vector[0].vector = pdev->irq;
 	pinstance->num_hrrq = 1;
-	rc = 0;
 
 	rc = request_irq(pdev->irq, pmcraid_isr, IRQF_SHARED,
 			 PMCRAID_DRIVER_NAME, &pinstance->hrrq_vector[0]);