From patchwork Thu Oct 10 23:09:33 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Rafael J. Wysocki" X-Patchwork-Id: 282493 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id A14182C00E7 for ; Fri, 11 Oct 2013 09:58:08 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756064Ab3JJW5v (ORCPT ); Thu, 10 Oct 2013 18:57:51 -0400 Received: from v094114.home.net.pl ([79.96.170.134]:60240 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1755050Ab3JJW5u (ORCPT ); Thu, 10 Oct 2013 18:57:50 -0400 Received: from cmk237.neoplus.adsl.tpnet.pl [83.31.138.237] (HELO vostro.rjw.lan) by serwer1319399.home.pl [79.96.170.134] with SMTP (IdeaSmtpServer v0.80) id 63bd5dde35642b1c; Fri, 11 Oct 2013 00:57:48 +0200 From: "Rafael J. Wysocki" To: Linus Torvalds , Steven Rostedt Cc: LKML , "Rafael J. Wysocki" , Mika Westerberg , Bjorn Helgaas , Andrew Morton , Linux PCI , ACPI Devel Maling List Subject: Re: [BUG] WARN_ON(!context) in drivers/pci/hotplug/acpiphp_glue.c Date: Fri, 11 Oct 2013 01:09:33 +0200 Message-ID: <2679976.SxBsymIdoJ@vostro.rjw.lan> User-Agent: KMail/4.10.5 (Linux/3.11.0+; KDE/4.10.5; x86_64; ; ) In-Reply-To: References: <20131010165905.7815defa@gandalf.local.home> <81272921.7ZJW2CaxNE@vostro.rjw.lan> MIME-Version: 1.0 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Thursday, October 10, 2013 02:37:15 PM Linus Torvalds wrote: > On Thu, Oct 10, 2013 at 2:35 PM, Rafael J. Wysocki wrote: > > > > Well, I must have overlooked the original report. Is it available anywhere > > I can find it? > > I think Steven has some buggered email system, he has other emails > being eaten by lkml too, and apparently other mail gateways (because > you were direct-cc'd on the original). Mailer issues aside, I've just seen the original (Bjorn forwarded it to me, thanks!) and I'm wondering if the message added by the debug patch below is triggered along with the WARN_ON(). If it is, I think it's better to drop the WARN_ON(), at least for now (until we sort out the acpiphp/pciehp coexistence). Rafael --- drivers/pci/hotplug/acpiphp_glue.c | 5 +++++ 1 file changed, 5 insertions(+) -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Index: linux-pm/drivers/pci/hotplug/acpiphp_glue.c =================================================================== --- linux-pm.orig/drivers/pci/hotplug/acpiphp_glue.c +++ linux-pm/drivers/pci/hotplug/acpiphp_glue.c @@ -991,6 +991,11 @@ void acpiphp_enumerate_slots(struct pci_ if (!pci_is_root_bus(bridge->pci_bus)) { struct acpiphp_context *context; + struct pci_dev *parent = bridge->pci_bus->parent->self; + + if (parent && device_is_managed_by_native_pciehp(parent)) + dev_warn(&bridge->pci_dev->dev, + "Parent is managed by pciehp!\n"); /* * This bridge should have been registered as a hotplug function