| Message ID | 20240220161924.3871774-8-Frank.Li@nxp.com |
|---|---|
| State | New |
| Headers | show |
| Series | PCI: imx6: Clean up and add imx95 pci support | expand |
Irrationality ? I think you mean "duplicate" or "redundant" ? Lorenzo On Tue, Feb 20, 2024 at 11:19:17AM -0500, Frank Li wrote: > The bindings referencing this file already define these constraints for > each of the variants, so the if not: then: is redundant. > > Acked-by: Rob Herring <robh@kernel.org> > Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > Signed-off-by: Frank Li <Frank.Li@nxp.com> > --- > > Notes: > Change from v7 to v8 > - add Manivannan Sadhasiva's Ack tag > Change from v6 to v7 > - rewrite git commit message by using simple words > Change from v5 to v6 > - rewrite git commit message and explain why remove it safely. > - Add Rob's Ack > Change from v1 to v4 > - new patch at v4 > > .../bindings/pci/fsl,imx6q-pcie-common.yaml | 16 ---------------- > 1 file changed, 16 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-common.yaml b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-common.yaml > index d91b639ae7ae7..0c50487a3866d 100644 > --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-common.yaml > +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-common.yaml > @@ -150,22 +150,6 @@ allOf: > - {} > - const: pcie_phy > - const: pcie_aux > - - if: > - properties: > - compatible: > - not: > - contains: > - enum: > - - fsl,imx6sx-pcie > - - fsl,imx8mq-pcie > - - fsl,imx6sx-pcie-ep > - - fsl,imx8mq-pcie-ep > - then: > - properties: > - clocks: > - maxItems: 3 > - clock-names: > - maxItems: 3 > > - if: > properties: > -- > 2.34.1 >
On Wed, Feb 21, 2024 at 11:49:27AM +0100, Lorenzo Pieralisi wrote: > Irrationality ? I think you mean "duplicate" or "redundant" ? I initially emphasized the negation logic code (*not*) below. I may have used the wrong term. I am okay simple said "Clean up redundant clocks check" Frank > > Lorenzo > > On Tue, Feb 20, 2024 at 11:19:17AM -0500, Frank Li wrote: > > The bindings referencing this file already define these constraints for > > each of the variants, so the if not: then: is redundant. > > > > Acked-by: Rob Herring <robh@kernel.org> > > Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > > --- > > > > Notes: > > Change from v7 to v8 > > - add Manivannan Sadhasiva's Ack tag > > Change from v6 to v7 > > - rewrite git commit message by using simple words > > Change from v5 to v6 > > - rewrite git commit message and explain why remove it safely. > > - Add Rob's Ack > > Change from v1 to v4 > > - new patch at v4 > > > > .../bindings/pci/fsl,imx6q-pcie-common.yaml | 16 ---------------- > > 1 file changed, 16 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-common.yaml b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-common.yaml > > index d91b639ae7ae7..0c50487a3866d 100644 > > --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-common.yaml > > +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-common.yaml > > @@ -150,22 +150,6 @@ allOf: > > - {} > > - const: pcie_phy > > - const: pcie_aux > > - - if: > > - properties: > > - compatible: > > - not: > > - contains: > > - enum: > > - - fsl,imx6sx-pcie > > - - fsl,imx8mq-pcie > > - - fsl,imx6sx-pcie-ep > > - - fsl,imx8mq-pcie-ep > > - then: > > - properties: > > - clocks: > > - maxItems: 3 > > - clock-names: > > - maxItems: 3 > > > > - if: > > properties: > > -- > > 2.34.1 > >
diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-common.yaml b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-common.yaml index d91b639ae7ae7..0c50487a3866d 100644 --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-common.yaml +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-common.yaml @@ -150,22 +150,6 @@ allOf: - {} - const: pcie_phy - const: pcie_aux - - if: - properties: - compatible: - not: - contains: - enum: - - fsl,imx6sx-pcie - - fsl,imx8mq-pcie - - fsl,imx6sx-pcie-ep - - fsl,imx8mq-pcie-ep - then: - properties: - clocks: - maxItems: 3 - clock-names: - maxItems: 3 - if: properties: