| Message ID | 20240204-bus_cleanup-pci-v1-1-300267a1e99e@marliere.net |
|---|---|
| State | New |
| Headers | show |
| Series | pci: endpoint: make pci_epf_bus_type const | expand |
On Sun, Feb 04, 2024 at 05:28:58PM -0300, Ricardo B. Marliere wrote: > Now that the driver core can properly handle constant struct bus_type, > move the pci_epf_bus_type variable to be a constant structure as well, > placing it into read-only memory which can not be modified at runtime. > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
On Sun, Feb 04, 2024 at 05:28:58PM -0300, Ricardo B. Marliere wrote: > Now that the driver core can properly handle constant struct bus_type, > move the pci_epf_bus_type variable to be a constant structure as well, > placing it into read-only memory which can not be modified at runtime. > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> - Mani > --- > drivers/pci/endpoint/pci-epf-core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/pci/endpoint/pci-epf-core.c b/drivers/pci/endpoint/pci-epf-core.c > index 2c32de667937..bf655383e5ed 100644 > --- a/drivers/pci/endpoint/pci-epf-core.c > +++ b/drivers/pci/endpoint/pci-epf-core.c > @@ -17,7 +17,7 @@ > > static DEFINE_MUTEX(pci_epf_mutex); > > -static struct bus_type pci_epf_bus_type; > +static const struct bus_type pci_epf_bus_type; > static const struct device_type pci_epf_type; > > /** > @@ -507,7 +507,7 @@ static void pci_epf_device_remove(struct device *dev) > epf->driver = NULL; > } > > -static struct bus_type pci_epf_bus_type = { > +static const struct bus_type pci_epf_bus_type = { > .name = "pci-epf", > .match = pci_epf_device_match, > .probe = pci_epf_device_probe, > > --- > base-commit: 1281aa073d3701b03cc6e716dc128df5ba47509d > change-id: 20240204-bus_cleanup-pci-f70b6d5a5bcf > > Best regards, > -- > Ricardo B. Marliere <ricardo@marliere.net> >
On Sun, Feb 04, 2024 at 05:28:58PM -0300, Ricardo B. Marliere wrote: > Now that the driver core can properly handle constant struct bus_type, > move the pci_epf_bus_type variable to be a constant structure as well, > placing it into read-only memory which can not be modified at runtime. > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net> Applied to pci/endpoint! - Mani > --- > drivers/pci/endpoint/pci-epf-core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/pci/endpoint/pci-epf-core.c b/drivers/pci/endpoint/pci-epf-core.c > index 2c32de667937..bf655383e5ed 100644 > --- a/drivers/pci/endpoint/pci-epf-core.c > +++ b/drivers/pci/endpoint/pci-epf-core.c > @@ -17,7 +17,7 @@ > > static DEFINE_MUTEX(pci_epf_mutex); > > -static struct bus_type pci_epf_bus_type; > +static const struct bus_type pci_epf_bus_type; > static const struct device_type pci_epf_type; > > /** > @@ -507,7 +507,7 @@ static void pci_epf_device_remove(struct device *dev) > epf->driver = NULL; > } > > -static struct bus_type pci_epf_bus_type = { > +static const struct bus_type pci_epf_bus_type = { > .name = "pci-epf", > .match = pci_epf_device_match, > .probe = pci_epf_device_probe, > > --- > base-commit: 1281aa073d3701b03cc6e716dc128df5ba47509d > change-id: 20240204-bus_cleanup-pci-f70b6d5a5bcf > > Best regards, > -- > Ricardo B. Marliere <ricardo@marliere.net> >
diff --git a/drivers/pci/endpoint/pci-epf-core.c b/drivers/pci/endpoint/pci-epf-core.c index 2c32de667937..bf655383e5ed 100644 --- a/drivers/pci/endpoint/pci-epf-core.c +++ b/drivers/pci/endpoint/pci-epf-core.c @@ -17,7 +17,7 @@ static DEFINE_MUTEX(pci_epf_mutex); -static struct bus_type pci_epf_bus_type; +static const struct bus_type pci_epf_bus_type; static const struct device_type pci_epf_type; /** @@ -507,7 +507,7 @@ static void pci_epf_device_remove(struct device *dev) epf->driver = NULL; } -static struct bus_type pci_epf_bus_type = { +static const struct bus_type pci_epf_bus_type = { .name = "pci-epf", .match = pci_epf_device_match, .probe = pci_epf_device_probe,
Now that the driver core can properly handle constant struct bus_type, move the pci_epf_bus_type variable to be a constant structure as well, placing it into read-only memory which can not be modified at runtime. Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net> --- drivers/pci/endpoint/pci-epf-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- base-commit: 1281aa073d3701b03cc6e716dc128df5ba47509d change-id: 20240204-bus_cleanup-pci-f70b6d5a5bcf Best regards,