From patchwork Fri Feb 2 15:11:25 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 1894617 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.a=rsa-sha256 header.s=selector2 header.b=KWEit8cL; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=139.178.88.99; helo=sv.mirrors.kernel.org; envelope-from=linux-pci+bounces-3027-incoming=patchwork.ozlabs.org@vger.kernel.org; receiver=patchwork.ozlabs.org) Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org [139.178.88.99]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4TRK5J1zXlz23g7 for ; Sat, 3 Feb 2024 02:12:36 +1100 (AEDT) Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 0CD5B28839D for ; Fri, 2 Feb 2024 15:12:35 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C0AE7146913; Fri, 2 Feb 2024 15:12:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b="KWEit8cL" X-Original-To: linux-pci@vger.kernel.org Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on2078.outbound.protection.outlook.com [40.107.8.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B83D314690C; Fri, 2 Feb 2024 15:11:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.8.78 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706886720; cv=fail; b=EIbDTMWN+bajMzhWduaWWZMK75L5QF6LDGnfV42WnturbrNwRIejA9IBG0tpT6O/4V/MD/oTJoQSBjCkJPZE6Af+R1ulZ3AjHyel926rd5VtTcCfM2g+DG5KSwWBcdoFWWq4mwSXjY80ya+f98tbxTkwDM2C6zMCg5KBQJkX17M= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706886720; c=relaxed/simple; bh=iaMVhIlaxnDKrjo/B86UwmBA4lUHgRwjSU/hHDluay0=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=MAw8MoLgksdxhwdczJOu50lB2eRMqDiCk1yA2hT8O9bGf2PaqBNV0a2eFA2gcp3tK/hFZLw7WeythoBaKHLPad99noq0Zo564EHFlz2ne8cRYamAq4sjyTYys0wrhbuKiB3APYZ9zqZnaQwCB+4OoWShHLegOaNE1jBjone8i/A= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b=KWEit8cL; arc=fail smtp.client-ip=40.107.8.78 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NW2S8FjE3v5rMH2mFcB4bwCfWxviiTLkIaUAMTfM4tHIFxyAtH1q6MdRbH42Dk3FGFYN89mzgHme1HkPOwBOLv/x11W6gc7X+WFAeM05ISOD63AMraYsrG0IBERsIhMCMfN/C50VITsMvag/SYPU6vc9D4DsYUh9YscuRM989QTRp+xFQjbSg29vMn3QTkK2WCeyHyJhsoXDVXFXndHHDX2G1Bmq035on9VQ5VNF9dIkuMVwZ/cHKwnS5uEnSE7wwDgKIzoFKQjQWKYuWHLCFkXnEXIV+2qYAunfduuYyFvuXu/Yl7oRp0eXypaak7jdLjR3UeY9z9Py/0oVpsVS4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wqraZNkbMXJ8bdVBUWBtPeGCWP+ilAu0pVj9SSD+e7E=; b=H2Na/P4TSko2s9CIZxcuAaiMjq1dNiyepk2Q5WOl9h5Cut8I6FwiXL2W/pU7LLNENAy/Vg1JLcBH4hErzWAbF3uyC1aBbuOxkfeJENIxEEtGfsxr7sZX36hvQuaa7UWDrzr3EwI9l7/aK6Ej0KqmzK/PoPqoCicjOSc3uycv5fjl70gJoRrVF+CkE/X+B2nmHk8Dajgq6zJUTBMTk/+33W847LoxTH8LvfaYNeDI78Ac7fiw/7Sd3v3jhRpHgr1tQ0ZPbS0YC8whv+fhhhyI+G3TqTjJTVWsJcbtfzUrKb/zp0NJJ2o4Z/lWEe5vqkbt0bJJleUmvZPjkYjhxGDU1g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wqraZNkbMXJ8bdVBUWBtPeGCWP+ilAu0pVj9SSD+e7E=; b=KWEit8cLjK6WiueMuo/WG8qwH6/JwQEBtLnCR/SfA8JV/c6/XFEMkZoEX/OpBCa0R0Lu4g9N3EEduDs+/rjlyC0A/dZtWZeevPO6gw+Su+h3OeCs/WDBP6jWhwKEcTZcmiSEs74jem5UYKry7+fiZWqVYucMc6ZW0FgWPUBXh+A= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by PAXPR04MB8425.eurprd04.prod.outlook.com (2603:10a6:102:1c7::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.30; Fri, 2 Feb 2024 15:11:52 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::c8b4:5648:8948:e85c]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::c8b4:5648:8948:e85c%3]) with mapi id 15.20.7249.027; Fri, 2 Feb 2024 15:11:52 +0000 From: Frank Li Date: Fri, 02 Feb 2024 10:11:25 -0500 Subject: [PATCH v3 3/6] PCI: dwc: Add outbound MSG TLPs support Message-Id: <20240202-pme_msg-v3-3-ff2af57a02ad@nxp.com> References: <20240202-pme_msg-v3-0-ff2af57a02ad@nxp.com> In-Reply-To: <20240202-pme_msg-v3-0-ff2af57a02ad@nxp.com> To: Bjorn Helgaas , Jingoo Han , Gustavo Pimentel , Manivannan Sadhasivam , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy?= =?utf-8?q?=C5=84ski?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , imx@lists.linux.dev Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Frank Li , Yoshihiro Shimoda , Serge Semin X-Mailer: b4 0.13-dev-c87ef X-Developer-Signature: v=1; a=ed25519-sha256; t=1706886696; l=2940; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=Vx141tscxeq3VO/J2v1vu73YFB2QjcNfIuChtPapKMY=; b=NA5IbWk8w8i/7XBwGa5boTLkm2rU/Yu6N0cLgfUosCrAZ5a9JXk1Wqg83FprrDPI1mBm6ROMp dRLQBqndzwlADK436tmf4kjh/+dYjxZTmgLh3wUoi/GdLcWmkE6vc6G X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: SJ0PR03CA0138.namprd03.prod.outlook.com (2603:10b6:a03:33c::23) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|PAXPR04MB8425:EE_ X-MS-Office365-Filtering-Correlation-Id: 7d2a9e28-091d-423d-ec52-08dc24014917 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2r7PWPD195gn9hPQAWJ2YkVgGqLkx13ttOiW93oW8/rv4qLnUisTCrp6jaUs9saVmKI4EpIKMi9yDM8N5wSD0R5Ebb2gSiJ9pV8rlRU1uQKQMa/eWBxhn5Wa9S7xnKojZIMJUPoFtdCf5SAWldRISS8ocB57Maq5uI7w3Om4igZjJbIUO+fwWz1PE/jyqy3xl5FC1psmzCRDzigtYwxFH+Qz5D2Z0UdUkzewbWyKamQkYLbAuq3Bq5KFdlCWLre+YebdLXI4akp014tYkaRc6uVQV6u6uN7gRknmqUxJEIQR19/V0yKpPBNkhgqGJHvJYNw6Yr9126UvMRFMDNYRIUJY54BawQVz7Mi8AXxCQEQzz2J9TYherbIEEvlAYyAkf+DapEBqupRxq3UxMNFn/WGowKlOvGofK7Tql1qtC/t/sLI9NbV7V5RxAhI+Fc0rZFbjbA6eqvXSPHnGAZCklRdf/Arbw+z1x8FSxdfHU+diQvnLUZOU+YTHY76VFdVJrSj75aq2Pf2MXQ68X9JojrJenBSCrSKLL8cjxwhlaEn4GGllwZY+L8lEneTRiBpNhJPYPR/0LUSrLGkLA9OlnVHuDZoF8eyrcLtxGnVkmWLrxClFVvS5iP/zHPZq0hj25pV0wQe7ZSd8KoKy7wCWDA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(39860400002)(376002)(136003)(346002)(366004)(396003)(230922051799003)(1800799012)(451199024)(64100799003)(186009)(2906002)(478600001)(7416002)(5660300002)(83380400001)(921011)(38350700005)(4326008)(36756003)(66946007)(8936002)(8676002)(54906003)(316002)(66476007)(86362001)(6506007)(6486002)(52116002)(6512007)(6666004)(41300700001)(26005)(2616005)(66556008)(38100700002)(110136005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?OPrJrdgg+K/ZjD4/Nnlejne5jAEK?= =?utf-8?q?8yAA12gcH1uk5aGe3CodNU+bXVc5aY4OrO92/Mt6aCyWVdtP7SBX1XkB01m1WweM8?= =?utf-8?q?P7Zsbhe1VIaquTHa8maB4tTIEIjwRqwRuG9n0gigJJt+S6EIOwX9u4CyI4/1QC0It?= =?utf-8?q?PqeKj+Ykg1h1mAZlVUqpvp/sIg7bIoPay1s3Ng37B2+v3RGv+MP9/zvfgaNQ7qQaq?= =?utf-8?q?mbCPl8EGgZ1K7ctEmEYOwfLfTpBFgE9ril+n5fgIHM5F8pcjd/h+vuSe5prTVU5xO?= =?utf-8?q?mRzpO9vNiwBjZQuBvOA+DI4z1G51/b6fZiPOtBhdCvoXltgHFqT3f8ayjLclbYFIS?= =?utf-8?q?kUc0KIKrvNrVKsPeil6nwMnkDGO3G8+9y7AKe9TI5Rr77VdNK+f327gNWmYaWDOO3?= =?utf-8?q?rc+lyTEzo0WintA64lDYaZqIlzsaQXXleQh8zyqlFbwjM6DyZRQNJ5SuR7x+fJlJE?= =?utf-8?q?mWvUD7ipP8/WOKUEdNA4dfLbBiAOOlBeeE0dwVC0dQ5Wy6rkKU0thBJMN7GR5Ylqy?= =?utf-8?q?kKXYXtqUDjYXO9TLmYXZQhXi681L9OKoZmMt+yoxiYaZlPb+2dwi84SEm/mUnTPP5?= =?utf-8?q?a46JP1L2ZNRsWu6vxR6TM3X66q7klce63Ik+NAACzeHcE+6TsNTgWN8j7t2xTaMqy?= =?utf-8?q?wQmc8D04xXh6mmtE+SZw6bidnXYkE5dRn+913d4YXkmRdXYkc8/RWhJxRO5PWy0y9?= =?utf-8?q?0V0tCXhVlFzvMNLC1OkNZ5nFj9Hn9dU4+fTwmNZfljbiEbJH7joIJe1NppebeNwVT?= =?utf-8?q?HONSOdCEsN9Djsr4y69KcYOkRvh752pau9QZo2R/m9Qs1D29kfs7CDB6pkEY0XiWf?= =?utf-8?q?jCR0CgtdAmO4YDKIx42Gzq3fbRzeJe/0A/85dTTynI+QAXbHMPT24D3tvwPei4VZU?= =?utf-8?q?9Xj7TDC/yw4OVnOVIKsYwqh1kDSgGGpYeGhWZ2i+nazB9lrE0/LA/25f16gxOxAGx?= =?utf-8?q?TRYh8agqo1wdb4+fLDxVq3z6c0sKDGsgWEC2/OUrsSREB21qyquOb/QQ/wrv5Cz4r?= =?utf-8?q?6ZDfF/l8Y3CtT9/TQp7jZ06Sfk42pWBK5PV1IpnhcK0M5brUUqGygQHin/Jjg3Y9i?= =?utf-8?q?erkzHcrDVg1ggk5LEKqTBfqFb4dqJnYG+fd/zywMUfMyeVU5By75+Yw1ONmWpAyJ4?= =?utf-8?q?i39gZOQ2f4k/VWGVrLQabu+yF9WsnLYbaggSHZpaAB05mpRYn7vo9Zk15CZsTePU0?= =?utf-8?q?l/MYtyQnnbBd21o4BmQKI1a16R1Ub0XsSxWb8fVcBJo517NWS/TQcjSG+kUmgtAys?= =?utf-8?q?rhxFMc7Hd+zv8+P2zblHwAC9Y+uDDKNND70uh1yD9sP7c1IjkZhFVmnflN8zl7pPW?= =?utf-8?q?12pUndYBMtgfrdnclQMuCW+EBkmk7TkXOwnvMKzH4rKEtIm6cMR3Y/pN5dTQxbkK/?= =?utf-8?q?GnZc9zUuCMfoS7W/kOPenOeyJ1eFWfqJbNbLkKPAfDcph2oSBtPU05fAvCdNcQY6a?= =?utf-8?q?m3sG4ySSfyUUFf13eiGWhei+9sQZtIJc7Byj45CdL6/OVHrnahiAKAONvc65CVhZR?= =?utf-8?q?neG5I3q6s8qD?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7d2a9e28-091d-423d-ec52-08dc24014917 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2024 15:11:52.0459 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: sHscLF5276+jfbi0HjqrDTLSw8kpD1NDKQjMNdVuDMjczoNDPVSyh+rclyUoNh2lAJwB2pPRijRVAXO3s1iXsA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8425 From: Yoshihiro Shimoda Add "code" and "routing" into struct dw_pcie_ob_atu_cfg for triggering INTx IRQs by iATU in the PCIe endpoint mode in near the future. PCIE_ATU_INHIBIT_PAYLOAD is set to issue TLP type of Msg instead of MsgD. So, this implementation supports the data-less messages only for now. Signed-off-by: Yoshihiro Shimoda Reviewed-by: Serge Semin Reviewed-by: Manivannan Sadhasivam Signed-off-by: Frank Li --- drivers/pci/controller/dwc/pcie-designware.c | 9 +++++++-- drivers/pci/controller/dwc/pcie-designware.h | 4 ++++ 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/controller/dwc/pcie-designware.c index df2575ec5f44c..ba909fade9db1 100644 --- a/drivers/pci/controller/dwc/pcie-designware.c +++ b/drivers/pci/controller/dwc/pcie-designware.c @@ -499,7 +499,7 @@ int dw_pcie_prog_outbound_atu(struct dw_pcie *pci, dw_pcie_writel_atu_ob(pci, atu->index, PCIE_ATU_UPPER_TARGET, upper_32_bits(atu->pci_addr)); - val = atu->type | PCIE_ATU_FUNC_NUM(atu->func_no); + val = atu->type | atu->routing | PCIE_ATU_FUNC_NUM(atu->func_no); if (upper_32_bits(limit_addr) > upper_32_bits(cpu_addr) && dw_pcie_ver_is_ge(pci, 460A)) val |= PCIE_ATU_INCREASE_REGION_SIZE; @@ -507,7 +507,12 @@ int dw_pcie_prog_outbound_atu(struct dw_pcie *pci, val = dw_pcie_enable_ecrc(val); dw_pcie_writel_atu_ob(pci, atu->index, PCIE_ATU_REGION_CTRL1, val); - dw_pcie_writel_atu_ob(pci, atu->index, PCIE_ATU_REGION_CTRL2, PCIE_ATU_ENABLE); + val = PCIE_ATU_ENABLE; + if (atu->type == PCIE_ATU_TYPE_MSG) { + /* The data-less messages only for now */ + val |= PCIE_ATU_INHIBIT_PAYLOAD | atu->code; + } + dw_pcie_writel_atu_ob(pci, atu->index, PCIE_ATU_REGION_CTRL2, val); /* * Make sure ATU enable takes effect before any subsequent config diff --git a/drivers/pci/controller/dwc/pcie-designware.h b/drivers/pci/controller/dwc/pcie-designware.h index d21db82e586d5..703b50bc5e0f1 100644 --- a/drivers/pci/controller/dwc/pcie-designware.h +++ b/drivers/pci/controller/dwc/pcie-designware.h @@ -148,11 +148,13 @@ #define PCIE_ATU_TYPE_IO 0x2 #define PCIE_ATU_TYPE_CFG0 0x4 #define PCIE_ATU_TYPE_CFG1 0x5 +#define PCIE_ATU_TYPE_MSG 0x10 #define PCIE_ATU_TD BIT(8) #define PCIE_ATU_FUNC_NUM(pf) ((pf) << 20) #define PCIE_ATU_REGION_CTRL2 0x004 #define PCIE_ATU_ENABLE BIT(31) #define PCIE_ATU_BAR_MODE_ENABLE BIT(30) +#define PCIE_ATU_INHIBIT_PAYLOAD BIT(22) #define PCIE_ATU_FUNC_NUM_MATCH_EN BIT(19) #define PCIE_ATU_LOWER_BASE 0x008 #define PCIE_ATU_UPPER_BASE 0x00C @@ -303,6 +305,8 @@ struct dw_pcie_ob_atu_cfg { int index; int type; u8 func_no; + u8 code; + u8 routing; u64 cpu_addr; u64 pci_addr; u64 size;