From patchwork Wed Jan 31 00:45:28 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 1893177 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.a=rsa-sha256 header.s=selector2 header.b=I1Qn22H5; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=2604:1380:4601:e00::3; helo=am.mirrors.kernel.org; envelope-from=linux-pci+bounces-2848-incoming=patchwork.ozlabs.org@vger.kernel.org; receiver=patchwork.ozlabs.org) Received: from am.mirrors.kernel.org (am.mirrors.kernel.org [IPv6:2604:1380:4601:e00::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4TPjzL4Jzsz1yQ0 for ; Wed, 31 Jan 2024 11:46:54 +1100 (AEDT) Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 5B6221F217FF for ; Wed, 31 Jan 2024 00:46:52 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 15A47641; Wed, 31 Jan 2024 00:46:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b="I1Qn22H5" X-Original-To: linux-pci@vger.kernel.org Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2065.outbound.protection.outlook.com [40.107.20.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1403BEBF; Wed, 31 Jan 2024 00:46:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.20.65 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706661969; cv=fail; b=SNjGdlNUe/h39P/9EB2vPSPtq9aEjMyz0Aq/MuRgC78l9Abjp9/tCsJD/GKEgHwFbaJUCJ9PapH4WW4nwhq6oUnLJOrU5An6rceerbPD0hJ1EkIs8x6fVHfH1HYuhaM8IYdbeQ2KbFm9SsI68IMQqycjZAR3tOk8HEEXdTaEbyY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706661969; c=relaxed/simple; bh=CSc9b/7O8Q2ywCcaQSNOAl8wC5iOA4e7Fn1jMqRoyvQ=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=r/E/Go1RRTthWAU3ihdeoazbEhJPlaAVMayByN/RCTjzWYrtOFrfoW31KsCU5iMV8Do9u/1cDQBcvsrB3YKMCEy4WvQM7qQWTdSikdsE+HrlAevuBoP1UbuP5CSipONk1wDrPS1EL+DdAGOeWBNrby/9VrTWMosmoiVmHBjcu04= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b=I1Qn22H5; arc=fail smtp.client-ip=40.107.20.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SDcTt2E88hUp3NrU6tCM/q2Y4vjZ8tMl3PSC24T6mxC4Kn0p4lPNs23FRnZISgESYfobutVjR95zKNZQRG1xi9yMGtQVACtjcdOYcbyL9ruONhnLvs3FRPiNx/De6n4OtXWiwhTpt259gtaDf129EZcgfqVWy2OxIikt0nBo7AYG6gNI83SN31r+fnhJHtoGhdNZ8uGHvVKNDm+ktclcK1/UVDZhjQ8YJJfHSVq5fH38FuxyLA9eYA5zWjzl2bUq9U4IEve99j/HxzYuIa6O5Moz1cfZq8kJ4F7766ZlLoqFx5fpwkEFtBd+ZTSaZYycTeiI0xPk62rDdy9ma38cZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HUvBZb1q4P51HNUpNUrXht5CZNZYfFhNGx2cTy486Ms=; b=H7K/dHIwZ5Bt4giZGNqEOnBM2UyKYwCir5WoHOzWgLDnHhtLxwrvA7b4WEyrbHD3NBozesalmsii7+MD5shiEoj6IEzSOUMRXVEnNGP+nRzmJwz8nFmf/pktgz+um2iYvkvx2O/Rjy7MrhotQQPtWqTOZ1pbTJI2s3Gy6Q3tsqhoCSwqo6wug5w5mlpyJTFvwvROp+pt4OzG0lnCabBdJo1X64otNtoOXCYtq8Ip2977pIJLcYG9/Ve8yadDwH59Em2D8Twbl2Oc8Ki0bs17wCFKsxdN0udne/m7YKDRzMqRGwAnUxCORxkkwladYR6BCwIc/9IwbBPmmTWsMGC9+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HUvBZb1q4P51HNUpNUrXht5CZNZYfFhNGx2cTy486Ms=; b=I1Qn22H5rdAUE+H0QL0Ut2i+qjQhfK+doxT4TPVYLP6uosJQZeMJg4jAjKZtTZQXqsE9Zji+xJeC3SB31xVR8yDMEg3vPq7ZTv4Em0srhGmRKDIwEhgcR3GsFfT/cn16XCSfxFm/zACu47WLs+6/Gddgbn6vZPnm/MhcVY2hKBU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by VI1PR04MB6877.eurprd04.prod.outlook.com (2603:10a6:803:131::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.34; Wed, 31 Jan 2024 00:46:05 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::c8b4:5648:8948:e85c]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::c8b4:5648:8948:e85c%3]) with mapi id 15.20.7228.029; Wed, 31 Jan 2024 00:46:05 +0000 From: Frank Li Date: Tue, 30 Jan 2024 19:45:28 -0500 Subject: [PATCH 3/6] PCI: dwc: Add outbound MSG TLPs support Message-Id: <20240130-pme_msg-v1-3-d52b0add5c7c@nxp.com> References: <20240130-pme_msg-v1-0-d52b0add5c7c@nxp.com> In-Reply-To: <20240130-pme_msg-v1-0-d52b0add5c7c@nxp.com> To: Bjorn Helgaas , Jingoo Han , Gustavo Pimentel , Manivannan Sadhasivam , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy?= =?utf-8?q?=C5=84ski?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , imx@lists.linux.dev Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Frank Li , Yoshihiro Shimoda , Serge Semin X-Mailer: b4 0.13-dev-2d940 X-Developer-Signature: v=1; a=ed25519-sha256; t=1706661950; l=2896; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=HsYYWicc5fOwAhzWsSAplVHxy6sgutdY8ja1Er1MKyk=; b=6M71McR98puiDwzSllTMoQVYo2KcrPwBY1JxhAbcnFPfPp7U5VwE8mr3YOr9iyUO9xPSRK+ic puKZ23iM6e+DLZaEVWuuA6EEhVtOyKSudc0ZfhQLRSlV4mOvlfdrcXX X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: SJ0PR03CA0225.namprd03.prod.outlook.com (2603:10b6:a03:39f::20) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|VI1PR04MB6877:EE_ X-MS-Office365-Filtering-Correlation-Id: 32d440c3-e25a-4898-aeda-08dc21f601b7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pMAEPAG8F6P2P1hNFXFEVMA3XOq2LClNx84h2mJsqtXFQq8uGARFmmyVkkxi3zKsvI5RROdaKZkX6J5zL9oyL9jzdo0RodqPmF0rlfky3tDgqJFbAF1UEoKtyfvmHmcrDBsflvJRFfX4FIN/6u1rdJpoysAzGegDyPY2JzRIsD78XsLRRcmnHb9zj1OMnNQCmgyBwxZxS0GWb1JZQKTwl9JYKW7yY8lSrTKYsWg+CoE/dW4bnyRl1uB7g8oiiI/FXp0yz4v9d9zA3bw4iTIOpqTS5f9pTFy9F4NcvBxobrj8r02TNB9Dd17xxDYf/Sg48b3a2EZaaIoVzX9jWCMmMu3daeOn1yl9RB2UUnaC/OLBAqJQP68NTpyhCfAI25ECG2Bv6CGtjpmZKKdNpcE3/m2ZQ5yXVh+KiIO368HBhOYPcIMxqphjG2J2qgCDv8U1wT8TafsLLzYNbX/3/TnKf1MnkSxbIFbJbVxuJxRMTFLA23JXTMpKik+s5jeLWfwtTNC2KhqWvlrUBxLAsJwMUQJN4c79oedpP/Z6ZFOpbiasrQBfKgiNa6PtFXGxK8oaEcv9E/PJaAHT/z2Cjh3UW+vHd8ULs7nNU3rI152C9YbdqeNYGYT2PAW9OKG0yoOWqHaYnuRFGCIHWi7iWpE5rA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(396003)(366004)(346002)(39860400002)(376002)(136003)(230922051799003)(186009)(64100799003)(1800799012)(451199024)(41300700001)(921011)(26005)(36756003)(316002)(66476007)(38350700005)(6512007)(52116002)(478600001)(83380400001)(2616005)(6666004)(6486002)(6506007)(38100700002)(86362001)(5660300002)(7416002)(2906002)(66556008)(54906003)(66946007)(8676002)(8936002)(4326008)(110136005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?9o2aAqNX6KhpJQaUfY9DyILPY6rP?= =?utf-8?q?V5iiQALpmIjRwesx8WkfPyo3DYtWppx4pHwkZxZxymkHi/tYMp2BKOESFMEZRlt8n?= =?utf-8?q?huqajDcy2ESuKFlCtFNpjVHNn7gcOZWRZvyVAoTPHyKeZl9Qs5Reu6ZDuTHJP6Wu8?= =?utf-8?q?z+DPZFQ+tW2VEJKUuHNUQzIzZyal+uXpCkgwrGb8pnEhyuLbUsWC1YT3ydKflvGLB?= =?utf-8?q?Ht3kOR8DaSkWXJifC9oLBeNnN5VOM5tghUgstnGP6IsdJ5kdymel65UbsxWIYl3o4?= =?utf-8?q?W4/+apxWWqjhZQXLF79nBfGBv/XKIKbwSL5nVmBxIEpMj3l31hxjy6LFT5LBIIXHT?= =?utf-8?q?za+zeF7YX2WJLRtKwZSyqnu4hG6HNs/UjowweFx2xAtTyYwFZKBD5/rmQFH4PzB5P?= =?utf-8?q?mwPhnDoHmLwBTOZ2p7SZg3SRf4WeWmhLrONP8MBKhaPsvl5r9EjAU9Pk/OquyBn2Z?= =?utf-8?q?YGhHfiRYxHor6fKBcUCud2dvw6RDTNNjWKuyhwaqdiRXPU54Q8Qw1/Qaf1FdEdUv0?= =?utf-8?q?8WUmaSxWQFhNvNHbPHmfoNVAL2yM9Wa8kZPFxYH3MG+pjCCVnNZOuFWJYUYhts4lr?= =?utf-8?q?8fD5pVI0j9jxIBwghuDWKWcqRA+e0XcLGq2/SczOsZFaK9cuekOzVTSCRXA5gplIP?= =?utf-8?q?JNKSRxwEhyEIN84n9MUKRBgZdCbwY2LPiJpY/gUDTdcy41FpAgdrAsCxRiiNsgyIj?= =?utf-8?q?AJeWgH6Ro7nTe12xbNuNcUjhmXG881+u8b2LFtLA47iD3+spKhwpzzCV/DifF7QRM?= =?utf-8?q?EeE5ahwmmGA/JUxlwPbyxfURk+i7B6lZ62nzx0rozGOZxPr0ni2mpnOZntZWoJ/7q?= =?utf-8?q?IDjZ6zD9uXirmzz4RWzWcrtx0vPikGKJpcvBExj39F4hCLImKrm3T4Oi85ZctJsul?= =?utf-8?q?WXdA1xF1i5kpMAMhcZhtgtPBlKDTkPTYUReo7dEac6elOJGmj3I2dhlnJNmuvPmo3?= =?utf-8?q?wDcvfGd2UPHXSVCApevF1hXNMgb0L6e7rU9I7Wk6tccIaZRfPpt72+9gxyxRnKgPJ?= =?utf-8?q?qtAs4l90W0xlUkJcQCCYgzvlSbTE1LtDzRf2z2z6H79I/ZrMhSGYnJimB3eNZ9dtW?= =?utf-8?q?VGU9a1uGvFT/JCPhJIdn/Y7ejgNA/bX1JHb1ys6+OToGCEHoHWd+XdERcEOL6VISO?= =?utf-8?q?qE1MkyIMe18F3qfQSInIrE3JZAbW24kcnnCimqj5vEhzDOxocOBY12y4+c5g1n5Gq?= =?utf-8?q?5a6lR0Edn/G+QC9LlTDd9p0/wtpUmSbndV4G9PYdqBmTelhRYdSJKFHFYBcCKpuuN?= =?utf-8?q?e4PRGQ4xzRb2bM6DebG56XY+N3AwuruNVkR3f+9gNtSGczoojsnTMXn5r3f7LXAO2?= =?utf-8?q?SBjrY4HbiqRl3ea4WT335T8cq9+l50zwp7iwWjg6Hbw2IVK1/ByyzVKHZnqRjwsui?= =?utf-8?q?lu9atTk/e7lyE8nY53lHEYdcBQQikZMcZVKmeBaHwr5pab31WZ8q1ovWTmzPusEJx?= =?utf-8?q?5VtybAiRB+B6kj+x4t3oIFlCWGwtaU8UOXEnPYQk4h0+RqkBP4O8LpQLoCeYFgGCn?= =?utf-8?q?tgwbrTNZcwSP?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 32d440c3-e25a-4898-aeda-08dc21f601b7 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2024 00:46:05.5321 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cCLUSoEvzbp5jd2rR+XZc90H4gwloETCb7YpocwdyKSpYwtnzNLP+oMxAN32oSrRHq2dCiNOWmrgDaI87VvgTg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6877 From: Yoshihiro Shimoda Add "code" and "routing" into struct dw_pcie_ob_atu_cfg for triggering INTx IRQs by iATU in the PCIe endpoint mode in near the future. PCIE_ATU_INHIBIT_PAYLOAD is set to issue TLP type of Msg instead of MsgD. So, this implementation supports the data-less messages only for now. Signed-off-by: Yoshihiro Shimoda Reviewed-by: Serge Semin Reviewed-by: Manivannan Sadhasivam --- drivers/pci/controller/dwc/pcie-designware.c | 9 +++++++-- drivers/pci/controller/dwc/pcie-designware.h | 4 ++++ 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/controller/dwc/pcie-designware.c index df2575ec5f44c..ba909fade9db1 100644 --- a/drivers/pci/controller/dwc/pcie-designware.c +++ b/drivers/pci/controller/dwc/pcie-designware.c @@ -499,7 +499,7 @@ int dw_pcie_prog_outbound_atu(struct dw_pcie *pci, dw_pcie_writel_atu_ob(pci, atu->index, PCIE_ATU_UPPER_TARGET, upper_32_bits(atu->pci_addr)); - val = atu->type | PCIE_ATU_FUNC_NUM(atu->func_no); + val = atu->type | atu->routing | PCIE_ATU_FUNC_NUM(atu->func_no); if (upper_32_bits(limit_addr) > upper_32_bits(cpu_addr) && dw_pcie_ver_is_ge(pci, 460A)) val |= PCIE_ATU_INCREASE_REGION_SIZE; @@ -507,7 +507,12 @@ int dw_pcie_prog_outbound_atu(struct dw_pcie *pci, val = dw_pcie_enable_ecrc(val); dw_pcie_writel_atu_ob(pci, atu->index, PCIE_ATU_REGION_CTRL1, val); - dw_pcie_writel_atu_ob(pci, atu->index, PCIE_ATU_REGION_CTRL2, PCIE_ATU_ENABLE); + val = PCIE_ATU_ENABLE; + if (atu->type == PCIE_ATU_TYPE_MSG) { + /* The data-less messages only for now */ + val |= PCIE_ATU_INHIBIT_PAYLOAD | atu->code; + } + dw_pcie_writel_atu_ob(pci, atu->index, PCIE_ATU_REGION_CTRL2, val); /* * Make sure ATU enable takes effect before any subsequent config diff --git a/drivers/pci/controller/dwc/pcie-designware.h b/drivers/pci/controller/dwc/pcie-designware.h index d21db82e586d5..703b50bc5e0f1 100644 --- a/drivers/pci/controller/dwc/pcie-designware.h +++ b/drivers/pci/controller/dwc/pcie-designware.h @@ -148,11 +148,13 @@ #define PCIE_ATU_TYPE_IO 0x2 #define PCIE_ATU_TYPE_CFG0 0x4 #define PCIE_ATU_TYPE_CFG1 0x5 +#define PCIE_ATU_TYPE_MSG 0x10 #define PCIE_ATU_TD BIT(8) #define PCIE_ATU_FUNC_NUM(pf) ((pf) << 20) #define PCIE_ATU_REGION_CTRL2 0x004 #define PCIE_ATU_ENABLE BIT(31) #define PCIE_ATU_BAR_MODE_ENABLE BIT(30) +#define PCIE_ATU_INHIBIT_PAYLOAD BIT(22) #define PCIE_ATU_FUNC_NUM_MATCH_EN BIT(19) #define PCIE_ATU_LOWER_BASE 0x008 #define PCIE_ATU_UPPER_BASE 0x00C @@ -303,6 +305,8 @@ struct dw_pcie_ob_atu_cfg { int index; int type; u8 func_no; + u8 code; + u8 routing; u64 cpu_addr; u64 pci_addr; u64 size;