| Message ID | 20230228043423.19335-1-xry111@xry111.site |
|---|---|
| State | New |
| Headers | show |
| Series | PCI: kirin: Select REGMAP_MMIO for PCIE_KIRIN | expand |
Gentle ping. On Tue, 2023-02-28 at 12:34 +0800, Xi Ruoyao wrote: > pcie-kirin.c invokes devm_regmap_init_mmio, so it's necessary to > select > REGMAP_MMIO or vmlinux fails to link with "undefined reference to > `__devm_regmap_init_mmio_clk`. > > Cc: stable@vger.kernel.org # at least for 6.1 and 6.2 > Signed-off-by: Xi Ruoyao <xry111@xry111.site> > --- > drivers/pci/controller/dwc/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pci/controller/dwc/Kconfig > b/drivers/pci/controller/dwc/Kconfig > index 434f6a4f4041..d29551261e80 100644 > --- a/drivers/pci/controller/dwc/Kconfig > +++ b/drivers/pci/controller/dwc/Kconfig > @@ -307,6 +307,7 @@ config PCIE_KIRIN > tristate "HiSilicon Kirin series SoCs PCIe controllers" > depends on PCI_MSI > select PCIE_DW_HOST > + select REGMAP_MMIO > help > Say Y here if you want PCIe controller support > on HiSilicon Kirin series SoCs.
On Tue, Mar 07, 2023 at 01:42:01PM +0800, Xi Ruoyao wrote: > Gentle ping. > > On Tue, 2023-02-28 at 12:34 +0800, Xi Ruoyao wrote: > > pcie-kirin.c invokes devm_regmap_init_mmio, so it's necessary to > > select > > REGMAP_MMIO or vmlinux fails to link with "undefined reference to > > `__devm_regmap_init_mmio_clk`. > > > > Cc: stable@vger.kernel.org # at least for 6.1 and 6.2 I merged this (with a rewritten commit log, Fixes tag and CC stable - please have a look and check how this has to be written for future submissions): https://lore.kernel.org/linux-pci/167844411812.1209684.12017386820985241641.b4-ty@kernel.org This patch is dropped. Thanks, Lorenzo > > Signed-off-by: Xi Ruoyao <xry111@xry111.site> > > --- > > drivers/pci/controller/dwc/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/pci/controller/dwc/Kconfig > > b/drivers/pci/controller/dwc/Kconfig > > index 434f6a4f4041..d29551261e80 100644 > > --- a/drivers/pci/controller/dwc/Kconfig > > +++ b/drivers/pci/controller/dwc/Kconfig > > @@ -307,6 +307,7 @@ config PCIE_KIRIN > > tristate "HiSilicon Kirin series SoCs PCIe controllers" > > depends on PCI_MSI > > select PCIE_DW_HOST > > + select REGMAP_MMIO > > help > > Say Y here if you want PCIe controller support > > on HiSilicon Kirin series SoCs. > > -- > Xi Ruoyao <xry111@xry111.site> > School of Aerospace Science and Technology, Xidian University
On Fri, 2023-03-10 at 11:45 +0100, Lorenzo Pieralisi wrote: > On Tue, Mar 07, 2023 at 01:42:01PM +0800, Xi Ruoyao wrote: > > Gentle ping. > > > > On Tue, 2023-02-28 at 12:34 +0800, Xi Ruoyao wrote: > > > pcie-kirin.c invokes devm_regmap_init_mmio, so it's necessary to > > > select > > > REGMAP_MMIO or vmlinux fails to link with "undefined reference to > > > `__devm_regmap_init_mmio_clk`. > > > > > > Cc: stable@vger.kernel.org # at least for 6.1 and 6.2 > > I merged this (with a rewritten commit log, Fixes tag and > CC stable - please have a look and check how this has to > be written for future submissions): > > https://lore.kernel.org/linux-pci/167844411812.1209684.12017386820985241641.b4-ty@kernel.org > > This patch is dropped. Oh, didn't noticed someone has already done this in 2022 :).
diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig index 434f6a4f4041..d29551261e80 100644 --- a/drivers/pci/controller/dwc/Kconfig +++ b/drivers/pci/controller/dwc/Kconfig @@ -307,6 +307,7 @@ config PCIE_KIRIN tristate "HiSilicon Kirin series SoCs PCIe controllers" depends on PCI_MSI select PCIE_DW_HOST + select REGMAP_MMIO help Say Y here if you want PCIe controller support on HiSilicon Kirin series SoCs.
pcie-kirin.c invokes devm_regmap_init_mmio, so it's necessary to select REGMAP_MMIO or vmlinux fails to link with "undefined reference to `__devm_regmap_init_mmio_clk`. Cc: stable@vger.kernel.org # at least for 6.1 and 6.2 Signed-off-by: Xi Ruoyao <xry111@xry111.site> --- drivers/pci/controller/dwc/Kconfig | 1 + 1 file changed, 1 insertion(+)